RE: Marshal: I went with something close to the example just to get a basic
regression test. I''ll add a note to remind me to revisit that area when
I go more in depth on super.
Hosting: As reviewed F2F, they are autogenerated, and I will look closer when I
implement them
Same for Float and the like.
JD
...there is no try
> -----Original Message-----
> From: Shri Borde
> Sent: Friday, July 24, 2009 1:44 PM
> To: Jim Deville; IronRuby External Code Reviewers; Dino Viehland
> Cc: ironruby-core at rubyforge.org
> Subject: RE: Code Review: bugclosing
>
> For http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=910,
> Tomas''s comment says that the Marshal attribute was not
significant. Do you
> still want to use the attribute in the test case?
>
> The Hosting tests are not really Interop, and could be under tests\Hosting,
> but doesn''t really matter. Also, there are DLR hosting tests. Do
take a look to
> see how much of that needs to be tested specially from an IronRuby point of
> view.
>
> Why are you adding tests for the individual methods in
IronRuby::Clr::Float? I
> would just add one test that it is the same as System::Float, and a smoke
test
> for one of the methods. Same for IronRuby::Clr::Integer, etc.
>
> Rest looks good.
>
> -----Original Message-----
> From: Jim Deville
> Sent: Friday, July 24, 2009 12:23 PM
> To: IronRuby External Code Reviewers; Dino Viehland
> Cc: ironruby-core at rubyforge.org
> Subject: Code Review: bugclosing
>
> tfpt review "/shelveset:bugclosing;REDMOND\jdeville"
> Comment :
> YAML does not properly deserialize Time values
>
> Pasted from
> <http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=910>
>
> overriding unsafe methods
>
> Pasted from
> <http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=964>
>
> Better error message for running ir.exe on pre-.Net 2.0 SP1
>
> Pasted from
> <http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=468>
>
> rand doesn''t work collectly
>
> Pasted from
> <http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1537>
>
> Rubygems failures
>
> Pasted from
> <http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1626>
>
> Adding a random object to Time which responds to to_f
>
> Pasted from
> <http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1211>
>
> ArgumentError when calling System.String..ctor(Char[], int, int)
>
> Pasted from
> <http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1678>
>
> Unverifiable code generated by mspec :lang
>
> Pasted from
> <http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1533>
>
> -X:PrivateBinding does not enable referring to classes that have internal
> visibility
>
> Pasted from
> <http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1506>
>
> Notes on these:
> * To get better error messages on pre-.NET 2.0sp1, I moved the error
> checking code from PythonConsoleHost up to ConsoleHost
> * As part of writing name_mangling specs, I created stubs for all of the
> IronRuby module. I''ll start filling those specs out going forward.
>