tfpt review "/shelveset:shrigitpull;REDMOND\jdeville"
Comment :
This shelveset is an external contribution from Shri. Tests have been modified
by me.
Added support to YAML.quick_emit to be called on nested objects where the
same emitter needs to be flowed through
Array.pack("a") was not dealing with nil input
yaml.rb should to "require stringio" like MRI does
Deleted a second copy of yaml.rb from the IronRuby.Libraries.Yaml folder
Added MutableString.Dump property to be able to inspect large strings in
VS.
ir.exe -X:ExceptionDetail was not working in interactive mode because
ir.exe catches the exception and does not call
RubyExceptionData.SetCompiledTrace like a rescue block in Ruby code would
do. Fixed this
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shrigitpull.diff
Type: application/octet-stream
Size: 107612 bytes
Desc: shrigitpull.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20090315/e03ebbe7/attachment-0001.obj>
Looks good ofcourse :)
-----Original Message-----
From: Jim Deville
Sent: Sunday, March 15, 2009 11:17 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: shrigitpull
tfpt review "/shelveset:shrigitpull;REDMOND\jdeville"
Comment :
This shelveset is an external contribution from Shri. Tests have been modified
by me.
Added support to YAML.quick_emit to be called on nested objects where the
same emitter needs to be flowed through
Array.pack("a") was not dealing with nil input
yaml.rb should to "require stringio" like MRI does
Deleted a second copy of yaml.rb from the IronRuby.Libraries.Yaml folder
Added MutableString.Dump property to be able to inspect large strings in
VS.
ir.exe -X:ExceptionDetail was not working in interactive mode because
ir.exe catches the exception and does not call
RubyExceptionData.SetCompiledTrace like a rescue block in Ruby code would
do. Fixed this