Ironruby core - Mar 2009 - Code Review: scripts

tfpt review "/shelveset:scripts;REDMOND\sborde"

  Comment  : 
  Code change:
  Small fix in Shell\CommandLine.cs to deal with newlines consistently
(user-reported issue).
  
  Scripts:
  Moves RunRSpec.cmd and irtests.bat from Merlin\Main\Scripts to
Merlin\Languages\Ruby\Scripts so that they are available in GIT.
  Also changed them so that they do not rely on Merlin\Main\test\scripts\ir.cmd
which does not exist in GIT and is needed only when Snap runs various modes like
with/without interpretation, etc.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: scripts.diff
Type: application/octet-stream
Size: 6648 bytes
Desc: scripts.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20090310/f4c350f6/attachment.obj>

Ruby Dev.bat: 
Can the RUBY19_EXE check for its existence first (so I can override it, for
example). I''d also like to not differentiate between GIT and non-GIT,
with my comment below, we don''t need the GIT env. Variable.

Common.rb:
I would say get rid of the nested if on line 42. If ROWAN_BIN, use .cmd,
otherwise, use.exe.


Otherwise looks good.

JD
> -----Original Message-----
> From: Shri Borde
> Sent: Tuesday, March 10, 2009 9:45 AM
> To: IronRuby External Code Reviewers; Rowan Code Reviewers
> Cc: ironruby-core at rubyforge.org
> Subject: Code Review: scripts
> 
>   tfpt review "/shelveset:scripts;REDMOND\sborde"
> 
>   Comment  :
>   Code change:
>   Small fix in Shell\CommandLine.cs to deal with newlines consistently
> (user-reported issue).
> 
>   Scripts:
>   Moves RunRSpec.cmd and irtests.bat from Merlin\Main\Scripts to
> Merlin\Languages\Ruby\Scripts so that they are available in GIT.
>   Also changed them so that they do not rely on
> Merlin\Main\test\scripts\ir.cmd which does not exist in GIT and is
> needed only when Snap runs various modes like with/without
> interpretation, etc.
>