I added a few comments to critical_tags.txt like this: fails("need to track which thread owns critical lock"):Thread.critical defers exit This will help the next person who tries to fix the bug, and also as just documentation. However, I realized that Jim regenerates the tag files whenever he pulls down new RubySpec tests. So such comments will get lost. Jim, is that correct? If so, I will just not add such comments until we change the process so that the tags are not periodically regenerated from scratch. Shri -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090106/20611127/attachment.html>
That is correct. The next time I sync up, I will look into the tools for tags that Brian has in Rubyspec. JD From: Shri Borde Sent: Tuesday, January 06, 2009 11:41 PM To: Jim Deville Cc: ironruby-core at rubyforge.org Subject: Comments in the RubySpec tag files I added a few comments to critical_tags.txt like this: fails("need to track which thread owns critical lock"):Thread.critical defers exit This will help the next person who tries to fix the bug, and also as just documentation. However, I realized that Jim regenerates the tag files whenever he pulls down new RubySpec tests. So such comments will get lost. Jim, is that correct? If so, I will just not add such comments until we change the process so that the tags are not periodically regenerated from scratch. Shri -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090107/bf54e1b9/attachment.html>
If you''re adding value to the RubySpec tests, the rubyspec guys are pretty good about giving commit access... spread the wealth! On Wed, Jan 7, 2009 at 2:40 AM, Shri Borde <Shri.Borde at microsoft.com> wrote:> I added a few comments to critical_tags.txt like this: > > > > fails*("need to track which thread owns critical lock")*:Thread.critical > defers exit > > > > This will help the next person who tries to fix the bug, and also as just > documentation. However, I realized that Jim regenerates the tag files > whenever he pulls down new RubySpec tests. So such comments will get lost. > Jim, is that correct? If so, I will just not add such comments until we > change the process so that the tags are not periodically regenerated from > scratch. > > > > Shri > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > >-- Michael Letterle [Polymath Prokrammer] http://blog.prokrams.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090107/117af0c8/attachment.html>
Jim has commit access and does provide patches to improve the framework. This thread is about the ironruby tags though, and it would not help anyone other than IronRuby. From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Michael Letterle Sent: Wednesday, January 07, 2009 11:02 AM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] Comments in the RubySpec tag files If you''re adding value to the RubySpec tests, the rubyspec guys are pretty good about giving commit access... spread the wealth! On Wed, Jan 7, 2009 at 2:40 AM, Shri Borde <Shri.Borde at microsoft.com<mailto:Shri.Borde at microsoft.com>> wrote: I added a few comments to critical_tags.txt like this: fails("need to track which thread owns critical lock"):Thread.critical defers exit This will help the next person who tries to fix the bug, and also as just documentation. However, I realized that Jim regenerates the tag files whenever he pulls down new RubySpec tests. So such comments will get lost. Jim, is that correct? If so, I will just not add such comments until we change the process so that the tags are not periodically regenerated from scratch. Shri _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org<mailto:Ironruby-core at rubyforge.org> http://rubyforge.org/mailman/listinfo/ironruby-core -- Michael Letterle [Polymath Prokrammer] http://blog.prokrams.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090107/2fcf8135/attachment.html>