FYI code review. I''m going to direct commit this, and it is already in SVN. tfpt review "/shelveset:compilefix;REDMOND\jdeville" Comment : Fix to allow rake to compile. -------------- next part -------------- A non-text attachment was scrubbed... Name: compilefix.diff Type: application/octet-stream Size: 1840 bytes Desc: compilefix.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090106/bcf96d12/attachment.obj>
tfpt review "/shelveset:compilefix;REDMOND\jdeville" Comment : This shelveset removes the project transforms from the Ruby rakefiles. This means that there is no longer a need to set MERLIN_ROOT for external contributors. -------------- next part -------------- A non-text attachment was scrubbed... Name: compilefix.diff Type: application/octet-stream Size: 67750 bytes Desc: compilefix.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090123/ccc257dc/attachment-0001.obj>
Ah deleting code, I love it. And goodbye IronRuby.source_context ... =) Looks good. ~js> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Friday, January 23, 2009 3:11 PM > To: IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: [Ironruby-core] Code Review: compilefix > > tfpt review "/shelveset:compilefix;REDMOND\jdeville" > Comment : > This shelveset removes the project transforms from the Ruby > rakefiles. This means that there is no longer a need to set MERLIN_ROOT > for external contributors. >
Sweet, going in as direct commit, followed by a push for external ;) JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jimmy Schementi > Sent: Tuesday, January 27, 2009 4:14 PM > To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers > Subject: Re: [Ironruby-core] Code Review: compilefix > > Ah deleting code, I love it. And goodbye IronRuby.source_context ... =) > > Looks good. > ~js > > > -----Original Message----- > > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > > bounces at rubyforge.org] On Behalf Of Jim Deville > > Sent: Friday, January 23, 2009 3:11 PM > > To: IronRuby External Code Reviewers > > Cc: ironruby-core at rubyforge.org > > Subject: [Ironruby-core] Code Review: compilefix > > > > tfpt review "/shelveset:compilefix;REDMOND\jdeville" > > Comment : > > This shelveset removes the project transforms from the Ruby > > rakefiles. This means that there is no longer a need to set > MERLIN_ROOT > > for external contributors. > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core