Ironruby core - Nov 2008 - Code Review: VisibilityAndOtherFixes2

tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
  Comment  :
  Implements
      - private method visibility
      - DATA constant
      - popen and duplex IO streams (will need some refactoring of RubyIO
object)

      Fixes:
      - warnings (verbosity levels, Kernel#warn)
      - Kernel#gets, print, puts (no dynamic call to IO#puts)
      - method reflection: Kernel#methods, Kernel#singleton_methods (methods
were missing in some cases)
      - $~ variable scoping (should be an inner-most non-block scope)
      - inclusion of module already included in a super class was handled
incorrectly

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: VisibilityAndOtherFixes2.diff
Type: application/octet-stream
Size: 288267 bytes
Desc: VisibilityAndOtherFixes2.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20081116/a01f2223/attachment-0001.obj>

On Sun, Nov 16, 2008 at 4:10 PM, Tomas Matousek <
Tomas.Matousek at microsoft.com> wrote:
>  tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
>  Comment  :
>  Implements
>      - private method visibility
>
>

*drools*

-- 
Michael Letterle
[Polymath Prokrammer]
http://blog.prokrams.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20081116/a1bbf7e8/attachment.html>

Test looks good.


JD

From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at
rubyforge.org] On Behalf Of Michael Letterle
Sent: Sunday, November 16, 2008 3:25 PM
To: ironruby-core at rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: Re: [Ironruby-core] Code Review: VisibilityAndOtherFixes2


On Sun, Nov 16, 2008 at 4:10 PM, Tomas Matousek <Tomas.Matousek at
microsoft.com<mailto:Tomas.Matousek at microsoft.com>> wrote:
 tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
 Comment  :
 Implements
     - private method visibility



*drools*

--
Michael Letterle
[Polymath Prokrammer]
http://blog.prokrams.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20081117/146d8511/attachment.html>

Changes look good.

-----Original Message-----
From: Tomas Matousek
Sent: Sunday, November 16, 2008 1:11 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: VisibilityAndOtherFixes2

  tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
  Comment  :
  Implements
      - private method visibility
      - DATA constant
      - popen and duplex IO streams (will need some refactoring of RubyIO
object)

      Fixes:
      - warnings (verbosity levels, Kernel#warn)
      - Kernel#gets, print, puts (no dynamic call to IO#puts)
      - method reflection: Kernel#methods, Kernel#singleton_methods (methods
were missing in some cases)
      - $~ variable scoping (should be an inner-most non-block scope)
      - inclusion of module already included in a super class was handled
incorrectly

Tomas