tfpt review "/shelveset:IDO2;REDMOND\tomat" Comment : Implements more of IDO in Ruby. Adds InvokeMember action to DynamicOperations and ObjectOperations. Tomas -------------- next part -------------- A non-text attachment was scrubbed... Name: IDO2.diff Type: application/octet-stream Size: 11708 bytes Desc: IDO2.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081027/fb4f356b/attachment.obj>
Ruby changes look good, but shouldn''t GetMember and InvokeMember be implemented on RubyModule.Meta instead of RubyClass.Meta? -----Original Message----- From: Tomas Matousek Sent: Monday, October 27, 2008 2:56 PM To: IronRuby External Code Reviewers; DLR Code Reviews Cc: ironruby-core at rubyforge.org Subject: Code Review: IDO2 tfpt review "/shelveset:IDO2;REDMOND\tomat" Comment : Implements more of IDO in Ruby. Adds InvokeMember action to DynamicOperations and ObjectOperations. Tomas