tfpt review "/shelveset:math;REDMOND\jdeville" Comment : Implements most of the missing math methods. Modifies specs around those. Math.erf and Math.erfc are still unimplemented, and all Math methods still don''t handle nil or coersion correctly. ~~~~ JD http://blog.jredville.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081014/c91e3b2c/attachment.html>
Doh, forgot the diff. JD From: Jim Deville Sent: Tuesday, October 14, 2008 2:49 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: math tfpt review "/shelveset:math;REDMOND\jdeville" Comment : Implements most of the missing math methods. Modifies specs around those. Math.erf and Math.erfc are still unimplemented, and all Math methods still don''t handle nil or coersion correctly. ~~~~ JD http://blog.jredville.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081014/e805b2f6/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: math.diff Type: application/octet-stream Size: 35318 bytes Desc: math.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081014/e805b2f6/attachment-0001.obj>
Looks good overall. You should probably resort the frexp, hypot and ldexp methods back into alphabetical order. From: Jim Deville Sent: Tuesday, October 14, 2008 2:50 PM To: Jim Deville; IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: math Doh, forgot the diff. JD From: Jim Deville Sent: Tuesday, October 14, 2008 2:49 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: math tfpt review "/shelveset:math;REDMOND\jdeville" Comment : Implements most of the missing math methods. Modifies specs around those. Math.erf and Math.erfc are still unimplemented, and all Math methods still don''t handle nil or coersion correctly. ~~~~ JD http://blog.jredville.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081014/c828d380/attachment.html>