tfpt review "/shelveset:Misc1;REDMOND\tomat" Replaces calls to Expression.Comma/Block with calls to AstFactory.Comma/Block that avoids copying and creating arrays of expressions. Fixes super call with no arguments. Implements SuperCallAction serialization. Makes -save option accept a path where to store the precompiled assembly. Tomas -------------- next part -------------- A non-text attachment was scrubbed... Name: Misc1.diff Type: application/octet-stream Size: 36636 bytes Desc: Misc1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081014/83900f54/attachment-0001.obj>
Changes are good. -----Original Message----- From: Tomas Matousek Sent: Tuesday, October 14, 2008 10:52 AM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: Misc1 tfpt review "/shelveset:Misc1;REDMOND\tomat" Replaces calls to Expression.Comma/Block with calls to AstFactory.Comma/Block that avoids copying and creating arrays of expressions. Fixes super call with no arguments. Implements SuperCallAction serialization. Makes -save option accept a path where to store the precompiled assembly. Tomas