tfpt review "/shelveset:Autoload6;REDMOND\tomat"
Comment :
Implements Kernel#autoload, Module#autoload and adds more specs for them.
Fixes incorrect evaluation order in post-test loop (begin ... end while
cond).
Adds helpers to Tokenizer class that check whether a given string is a valid
method/constant/class-variable/instance-variable name.
Fixes signature of Kernel#printf.
Adds support for HOME directory mapping to ''load'' and
''require''.
Fixes few symbol related bugs introduced by previous checkin.
Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Autoload6.diff
Type: application/octet-stream
Size: 173234 bytes
Desc: Autoload6.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20081006/a4fce93f/attachment-0001.obj>
Coding changes look good.
-----Original Message-----
From: Tomas Matousek
Sent: Monday, October 06, 2008 1:53 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: Autoload6
tfpt review "/shelveset:Autoload6;REDMOND\tomat"
Comment :
Implements Kernel#autoload, Module#autoload and adds more specs for them.
Fixes incorrect evaluation order in post-test loop (begin ... end while
cond).
Adds helpers to Tokenizer class that check whether a given string is a valid
method/constant/class-variable/instance-variable name.
Fixes signature of Kernel#printf.
Adds support for HOME directory mapping to ''load'' and
''require''.
Fixes few symbol related bugs introduced by previous checkin.
Tomas
Test looks good JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Curt Hagenlocher > Sent: Monday, October 06, 2008 3:05 PM > To: Tomas Matousek; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: Re: [Ironruby-core] Code Review: Autoload6 > > Coding changes look good. > > -----Original Message----- > From: Tomas Matousek > Sent: Monday, October 06, 2008 1:53 PM > To: IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: Code Review: Autoload6 > > tfpt review "/shelveset:Autoload6;REDMOND\tomat" > Comment : > Implements Kernel#autoload, Module#autoload and adds more specs for > them. > Fixes incorrect evaluation order in post-test loop (begin ... end > while cond). > Adds helpers to Tokenizer class that check whether a given string > is a valid method/constant/class-variable/instance-variable name. > Fixes signature of Kernel#printf. > Adds support for HOME directory mapping to ''load'' and ''require''. > Fixes few symbol related bugs introduced by previous checkin. > > Tomas > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core