Attached patch fixes 5 more unused local variable warnings. It should be uncontroversial. If some unused variable assignment is there for debugging or other purposes, I think it is advisable to write a comment saying it is so. If this is the case, please tell me. All warnings were found by Mono C# compiler. -- Seo Sanghyeon -------------- next part -------------- A non-text attachment was scrubbed... Name: warning2.diff Type: text/x-diff Size: 3728 bytes Desc: not available URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080815/cdb26988/attachment.bin>
I''ll reply to both patches with this mail. We actually can''t accept patches to anything in the DLR and Ruby parser and runtime. So really the patches have to be to the libraries, or the infrastructure. We also need to back out some of your commits. I can ask the DLR to make these changes for you though. Sorry about this. We can try to make it clearer if you have a suggestion on how to do it. -----Original Message----- From: Seo Sanghyeon <sanxiyn at gmail.com> Sent: August 14, 2008 1:58 PM To: ironruby-core at rubyforge.org <ironruby-core at rubyforge.org> Subject: [Ironruby-core] Code Review: warning2 Attached patch fixes 5 more unused local variable warnings. It should be uncontroversial. If some unused variable assignment is there for debugging or other purposes, I think it is advisable to write a comment saying it is so. If this is the case, please tell me. All warnings were found by Mono C# compiler. -- Seo Sanghyeon
2008/8/15 Jim Deville <jdeville at microsoft.com>:> We actually can''t accept patches to anything in the DLR and Ruby parser and runtime. So really the patches have to be to the libraries, or the infrastructure. We also need to back out some of your commits. I can ask the DLR to make these changes for you though.If this were any other project, by this time, I would have said "I quit. You suck. This is not open source". I do understand this is not any other project, but I am sad. -- Seo Sanghyeon
"Baby steps." Don''t think of it as just contributing to a project; think of it as helping to change a large multinational corporation in a way that benefits both it and the rest of the world. -----Original Message----- From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Seo Sanghyeon Sent: Friday, August 15, 2008 4:57 AM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] Code Review: warning2 2008/8/15 Jim Deville <jdeville at microsoft.com>:> We actually can''t accept patches to anything in the DLR and Ruby parser and runtime. So really the patches have to be to the libraries, or the infrastructure. We also need to back out some of your commits. I can ask the DLR to make these changes for you though.If this were any other project, by this time, I would have said "I quit. You suck. This is not open source". I do understand this is not any other project, but I am sad. -- Seo Sanghyeon _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core