Ironruby core - Aug 2008 - Code Review: MO-RubyActions-Subclasses

tfpt review "/shelveset:MO-RubyActions-Subclasses;REDMOND\tomat"
Comment  :
  Switches the rest of the Ruby custom actions to MetaObjects.
  Fixes subclass creation in mutable string operations. MRI doesn''t
invoke "new" nor "initialize" to create the resulting string
in string operations.
  Fixes class and subclass construction of Proc to match MRI.

Tomas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: MO-RubyActions-Subclasses.diff
Type: application/octet-stream
Size: 55187 bytes
Desc: MO-RubyActions-Subclasses.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20080805/11289e3e/attachment-0001.obj>

Looks good.

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at
rubyforge.org] On Behalf Of Tomas Matousek
Sent: Tuesday, August 05, 2008 11:38 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: [Ironruby-core] Code Review: MO-RubyActions-Subclasses

tfpt review "/shelveset:MO-RubyActions-Subclasses;REDMOND\tomat"
Comment  :
  Switches the rest of the Ruby custom actions to MetaObjects.
  Fixes subclass creation in mutable string operations. MRI doesn''t
invoke "new" nor "initialize" to create the resulting string
in string operations.
  Fixes class and subclass construction of Proc to match MRI.

Tomas