tfpt review "/shelveset:interpret1;REDMOND\jdeville" Comment : Modifies run.rb and common.rb to clean up command line flags and run tests under -D -X:Interpret, -D and -D -X:SaveAssemblies. All three are ran in snap with this change. This also modifies the rake.cmd file in $MERLIN_EXTERNAL to use %dp0~ instead of a fixed path. -------------- next part -------------- A non-text attachment was scrubbed... Name: interpret1.diff Type: application/octet-stream Size: 9744 bytes Desc: interpret1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080805/c21adabf/attachment.obj>
Looks good to me. -----Original Message----- From: Jim Deville Sent: Tuesday, August 05, 2008 1:37 PM To: IronRuby External Code Reviewers; Curt Hagenlocher; Jimmy Schementi Cc: ironruby-core at rubyforge.org Subject: Code Review: interpret1 tfpt review "/shelveset:interpret1;REDMOND\jdeville" Comment : Modifies run.rb and common.rb to clean up command line flags and run tests under -D -X:Interpret, -D and -D -X:SaveAssemblies. All three are ran in snap with this change. This also modifies the rake.cmd file in $MERLIN_EXTERNAL to use %dp0~ instead of a fixed path.
Yep, check it in! Tomas -----Original Message----- From: Curt Hagenlocher Sent: Tuesday, August 05, 2008 2:36 PM To: Jim Deville; IronRuby External Code Reviewers; Jimmy Schementi Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: interpret1 Looks good to me. -----Original Message----- From: Jim Deville Sent: Tuesday, August 05, 2008 1:37 PM To: IronRuby External Code Reviewers; Curt Hagenlocher; Jimmy Schementi Cc: ironruby-core at rubyforge.org Subject: Code Review: interpret1 tfpt review "/shelveset:interpret1;REDMOND\jdeville" Comment : Modifies run.rb and common.rb to clean up command line flags and run tests under -D -X:Interpret, -D and -D -X:SaveAssemblies. All three are ran in snap with this change. This also modifies the rake.cmd file in $MERLIN_EXTERNAL to use %dp0~ instead of a fixed path.