tfpt review "/shelveset:YamlRegex;REDMOND\olegtk" Comment : Fixes Ruby Regex support: implements RubyRegex.taguri() and loading regex from yaml. Implements loading literal Ruby ranges. Adds couple useful RubyUtils.Evaluate overloads (one that takes string instead of MutableString and one with no optional arguments). -- Oleg -------------- next part -------------- A non-text attachment was scrubbed... Name: YamlRegex.diff Type: application/octet-stream Size: 10472 bytes Desc: YamlRegex.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080701/16090de3/attachment-0001.obj>
Oleg Tkachenko
2008-Jul-02 20:01 UTC
[Ironruby-core] Code Review: YamlRegex - Please ignore
Submitted by mistake, please ignore this one. -- Oleg
I get an error when trying to review your shelveset: C:\M5\Merlin\Main>tfpt review /shelveset:YamlRegex;olegtk No shelvesets found matching YamlRegex;olegtk Tomas -----Original Message----- From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Oleg Tkachenko Sent: Tuesday, July 01, 2008 5:59 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: [Ironruby-core] Code Review: YamlRegex tfpt review "/shelveset:YamlRegex;REDMOND\olegtk" Comment : Fixes Ruby Regex support: implements RubyRegex.taguri() and loading regex from yaml. Implements loading literal Ruby ranges. Adds couple useful RubyUtils.Evaluate overloads (one that takes string instead of MutableString and one with no optional arguments). -- Oleg
I removed it, please ignore. -- Oleg ________________________________________ From: Tomas Matousek Sent: Wednesday, July 02, 2008 6:36 PM To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers Subject: RE: Code Review: YamlRegex I get an error when trying to review your shelveset: C:\M5\Merlin\Main>tfpt review /shelveset:YamlRegex;olegtk No shelvesets found matching YamlRegex;olegtk Tomas -----Original Message----- From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Oleg Tkachenko Sent: Tuesday, July 01, 2008 5:59 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: [Ironruby-core] Code Review: YamlRegex tfpt review "/shelveset:YamlRegex;REDMOND\olegtk" Comment : Fixes Ruby Regex support: implements RubyRegex.taguri() and loading regex from yaml. Implements loading literal Ruby ranges. Adds couple useful RubyUtils.Evaluate overloads (one that takes string instead of MutableString and one with no optional arguments). -- Oleg