Dave Remy
2008-Jul-01 01:30 UTC
[Ironruby-core] Code Review: StringElementReferenceAndSlice
tfpt review "/shelveset:StringElementReferenceAndSlice;REDMOND\dremy" Comment : Changes for [] (alias: slice) to run clean. One small fix to not flow taint. Also, fix a small bug that was using a deprecated implicit conversion between string and MutableString. -------------- next part -------------- A non-text attachment was scrubbed... Name: StringElementReferenceAndSlice.diff Type: application/octet-stream Size: 3015 bytes Desc: StringElementReferenceAndSlice.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080630/ca0078cf/attachment.obj>
Curt Hagenlocher
2008-Jul-01 15:51 UTC
[Ironruby-core] Code Review: StringElementReferenceAndSlice
Looks good. -----Original Message----- From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Dave Remy Sent: Montag, 30. Juni 2008 18:31 To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: [Ironruby-core] Code Review: StringElementReferenceAndSlice tfpt review "/shelveset:StringElementReferenceAndSlice;REDMOND\dremy" Comment : Changes for [] (alias: slice) to run clean. One small fix to not flow taint. Also, fix a small bug that was using a deprecated implicit conversion between string and MutableString.