tfpt review "/shelveset:StringCenterDeleteEach;REDMOND\dremy" Comment : Changes for string.center (adjustements for code review comments), string.delete, and string.each/each_line to pass specs. Also, forgot to update excludes for squeeze/squeeze! implementation in last checkin. -------------- next part -------------- A non-text attachment was scrubbed... Name: StringCenterDeleteEach.diff Type: application/octet-stream Size: 12782 bytes Desc: StringCenterDeleteEach.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080630/fd22aa92/attachment.obj>
Looks good. -----Original Message----- From: Dave Remy Sent: Monday, June 30, 2008 2:39 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: StringCenterDeleteEach tfpt review "/shelveset:StringCenterDeleteEach;REDMOND\dremy" Comment : Changes for string.center (adjustements for code review comments), string.delete, and string.each/each_line to pass specs. Also, forgot to update excludes for squeeze/squeeze! implementation in last checkin.