Ruby and DLR. tfpt review "/shelveset:RubyPrecompilation;REDMOND\tomat" Removes dependency of precompiled code on optimized scopes. Enables loading/saving precompiled assemblies in Ruby loader. Implements IExpressionSerializable on ProtocolConversionAction to enable its serialization to IL. Tomas -------------- next part -------------- A non-text attachment was scrubbed... Name: RubyPrecompilation.diff Type: application/octet-stream Size: 16112 bytes Desc: RubyPrecompilation.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080606/8008b29d/attachment-0001.obj>
The only concerning thing I see in the Ruby changes are the Assembly.LoadFrom - what''s up with that? It''s probably file for this simple case (because all of the dependencies will already be loaded) but it''s a little scary. Adding DLR Code Reviews just to make sure the DLR devs don''t miss this. -----Original Message----- From: Tomas Matousek Sent: Friday, June 06, 2008 10:11 AM To: IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: RubyPrecompilation Ruby and DLR. tfpt review "/shelveset:RubyPrecompilation;REDMOND\tomat" Removes dependency of precompiled code on optimized scopes. Enables loading/saving precompiled assemblies in Ruby loader. Implements IExpressionSerializable on ProtocolConversionAction to enable its serialization to IL. Tomas
The implementation is still experimental, so it expects IronRubyApplication.dll file located in the current directory. We need to design how pre-compilation is exposed to the users. Tomas -----Original Message----- From: Dino Viehland Sent: Friday, June 06, 2008 10:31 AM To: Tomas Matousek; IronRuby External Code Reviewers; Rowan Code Reviewers; DLR Code Reviews Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: RubyPrecompilation The only concerning thing I see in the Ruby changes are the Assembly.LoadFrom - what''s up with that? It''s probably file for this simple case (because all of the dependencies will already be loaded) but it''s a little scary. Adding DLR Code Reviews just to make sure the DLR devs don''t miss this. -----Original Message----- From: Tomas Matousek Sent: Friday, June 06, 2008 10:11 AM To: IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: RubyPrecompilation Ruby and DLR. tfpt review "/shelveset:RubyPrecompilation;REDMOND\tomat" Removes dependency of precompiled code on optimized scopes. Enables loading/saving precompiled assemblies in Ruby loader. Implements IExpressionSerializable on ProtocolConversionAction to enable its serialization to IL. Tomas