Ironruby core - May 2008 - Code Review: ThreadLib

atfpt review /shelveset:ThreadLib;REDMOND\tomat

A rough implementation of thread.so.

Ignores differences of Ruby Mutex and .NET Monitor for now:
- Ruby Mutex.lock in not reentrant by the same thread
- it could be locked/unlocked from non-owning thread (.NET Monitor throws an
exception in that case)

Also IronRuby runtime itself is not hardened against race conditions yet.

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ThreadLib.diff
Type: application/octet-stream
Size: 41477 bytes
Desc: ThreadLib.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20080515/1c12e8e7/attachment-0001.obj>

On Thu, 2008-05-15 at 21:03 -0700, Tomas Matousek wrote:
> - it could be locked/unlocked from non-owning thread (.NET Monitor
> throws an exception in that case)
Don''t worry about supporting that case.

Most of the people who abused Mutex by trying to use it like a semaphore
have been weeded out since I modified fastthread to raise an exception
for unlocks by non-owners.

(I believe the latest 1.8.6 patchlevels also throw an exception, if
you''re using the C Mutex implementation which is based on fastthread.)

-mental
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20080526/b405dad2/attachment.bin>