Hello, Do I need to build world when a new ZFS related commit took place or is a build kernel enough? eg svn commit: r208334: Modified: stable/8/cddl/contrib/opensolaris/cmd/zdb/zdb.c stable/8/cddl/contrib/opensolaris/cmd/ztest/ztest.c stable/8/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c stable/8/cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h stable/8/cddl/contrib/opensolaris/lib/libzpool/common/taskq.c stable/8/sys/cddl/boot/zfs/zfsimpl.h stable/8/sys/cddl/compat/opensolaris/sys/sysmacros.h stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dbuf.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_traverse.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_scrub.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu_traverse.h stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dsl_pool.h stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/spa.h stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/spa_impl.h stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/txg_impl.h stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_cache.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c Directory Properties: stable/8/cddl/contrib/opensolaris/ (props changed) stable/8/cddl/contrib/opensolaris/cmd/zdb/ (props changed) stable/8/cddl/contrib/opensolaris/cmd/zfs/ (props changed) stable/8/cddl/contrib/opensolaris/lib/libzfs/ (props changed) stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/dev/xen/xenpci/ (props changed) stable/8/sys/geom/sched/ (props changed)
On Thu, May 20, 2010 at 09:12:05AM +0200, Matthias Gamsjager wrote:> Hello, > > Do I need to build world when a new ZFS related commit took place or > is a build kernel enough? > > eg svn commit: r208334: > Modified: > stable/8/cddl/contrib/opensolaris/cmd/zdb/zdb.c > stable/8/cddl/contrib/opensolaris/cmd/ztest/ztest.c > stable/8/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c > stable/8/cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h > stable/8/cddl/contrib/opensolaris/lib/libzpool/common/taskq.cThis commit touched libzpool and /usr/sbin/zdb (neither is part of kernel), and other commits touched non-kernel parts also (e.g. r208288 touched the zpool command) So I would suggest that, yes, you should rebuild world also.
On Thu, May 20, 2010 at 12:12 AM, Matthias Gamsjager <mgamsjager@gmail.com> wrote:> Hello, > > Do I need to build world when a new ZFS related commit took place or > is a build kernel enough? > > eg svn commit: r208334:This one requires a full kernel+world build to fully benefit from the improvement. Most times if the change only covers sys/cdd/*/*.c, a kernel build is sufficient, but to avoid mismatches we do advise a full build if you are unsure. Cheers, -- Xin LI <delphij@delphij.net> http://www.delphij.net
On Thu, May 20, 2010 at 09:12:05AM +0200, Matthias Gamsjager wrote:> Do I need to build world when a new ZFS related commit took place or > is a build kernel enough?In general, if you aren't 100% certain of the implications of a series of commits, you should always rebuild/reinstall both world and kernel. No harm in asking of course, but it's better to be safe than sorry, as the repercussions of userland not matching kernel can be pretty severe depending on what changed. -- | Jeremy Chadwick jdc@parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. PGP: 4BD6C0CB |