hello, on RELENG_6 sys/_timeval.h defines (struct timeval).tv_sec as long. posix wants it to be a time_t. this seems to have been corrected a long time ago in HEAD (see [1]). i took time to 'make universe' in a RELENG_6 tree with the HEAD src/sys/sys/_timeval.h. i've found similar breakage. here's a patch which correct it the same way. this sounds like an idea with pros (conformance) and cons (abi change). anyone interested in those changes ? [1] http://docs.FreeBSD.org/cgi/mid.cgi?200512242222.jBOMMHRA056613 -------------- next part -------------- A non-text attachment was scrubbed... Name: struct_timeval.diff Type: application/octet-stream Size: 4637 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20070716/65b98e78/struct_timeval.obj
On Mon, Jul 16, 2007 at 01:10:46PM +0200, Matthieu Michaud wrote:> hello, > > on RELENG_6 sys/_timeval.h defines (struct timeval).tv_sec as long. > posix wants it to be a time_t. this seems to have been corrected a > long time ago in HEAD (see [1]). i took time to 'make universe' in a > RELENG_6 tree with the HEAD src/sys/sys/_timeval.h. i've found > similar breakage. here's a patch which correct it the same way. this > sounds like an idea with pros (conformance) and cons (abi change). > anyone interested in those changes ?the patch seems small, so i think it is a good thing to apply the change, as this should also simplify porting third party apps and reduce diffs with HEAD. cheers luigi