freebsd stable - Aug 2005 - Build failure in procfs module

Hi, Yar!


On Thu, 11 Aug 2005 19:34:09 +0400 Yar Tikhiy wrote:
> On Thu, Aug 04, 2005 at 12:28:35PM +0400, Boris Samorodov wrote:
> > On Mon, 18 Jul 2005 19:19:24 +0400 Yar Tikhiy wrote:
> > > On Thu, Jul 14, 2005 at 02:15:07PM +0400, Yar Tikhiy wrote:
> > > > 
> > > > I ran into a problem that might be triggered by Peter's
recent
> > > > changes to procfs.  Namely, the buildworld procedure would
fail in
> > > > the procfs module if MODULES_WITH_WORLD were set.  I noticed
it
> > > > first in CURRENT and then tested it in a clean environment
by
> > > > building a freshly CVSup'd RELENG_6 on a freshly
installed 5.4-RELEASE,
> > > > with MODULES_WITH_WORLD set.  I think it's a route of
upgrading
> > > > quite a few people will follow.
> > > > 
> > > > Here's the diagnostics:
> [snip]
> > > The problem appears to have to do with Peter's changes to
procfs:
> > > The procfs source files now include opt_compat.h, which is not
> > > available by default when building with MODULES_WITH_WORLD set.
> > > The attached patch seems to fix the problem in the conventional
> > > way.  However, I'm unsure which COMPAT_* options are really
needed
> > > to the procfs module.  COMPAT_43 should be enough according to my
> > > quick examining /sys/fs/procfs.
> > 
> > Was the case corrected in BETA2? A couple of days ago I upgraded from
> > CURRENT (middle of June 2005) to BETA1. The problem existed but the
> > patch helped.
> Alas, no one has displayed interest in fixing this bug since I left
> for vacation.  I committed the fix to CURRENT today although I don't
> use procfs, which is a kind of a situation I hate.  MFC to RELENG_6
> is due in 3 days.
Could you (or somebody else) MFC the patch to RELENG_6?

PS. Today was bitten by the problem second time. Shame on me, I didn't
recall it in time. :-(


WBR
-- 
bsam

On Tue, Aug 16, 2005 at 01:29:45AM +0400, Boris Samorodov
wrote:
> On Thu, 11 Aug 2005 19:34:09 +0400 Yar Tikhiy wrote:
> > On Thu, Aug 04, 2005 at 12:28:35PM +0400, Boris Samorodov wrote:
> > > On Mon, 18 Jul 2005 19:19:24 +0400 Yar Tikhiy wrote:
> > > > On Thu, Jul 14, 2005 at 02:15:07PM +0400, Yar Tikhiy wrote:
> > > > > 
> > > > > I ran into a problem that might be triggered by
Peter's recent
> > > > > changes to procfs.  Namely, the buildworld procedure
would fail in
> > > > > the procfs module if MODULES_WITH_WORLD were set.  I
noticed it
> > > > > first in CURRENT and then tested it in a clean
environment by
> > > > > building a freshly CVSup'd RELENG_6 on a freshly
installed 5.4-RELEASE,
> > > > > with MODULES_WITH_WORLD set.  I think it's a route
of upgrading
> > > > > quite a few people will follow.
> > > > > 
> > > > > Here's the diagnostics:
> > [snip]
> > > > The problem appears to have to do with Peter's changes
to procfs:
> > > > The procfs source files now include opt_compat.h, which is
not
> > > > available by default when building with MODULES_WITH_WORLD
set.
> > > > The attached patch seems to fix the problem in the
conventional
> > > > way.  However, I'm unsure which COMPAT_* options are
really needed
> > > > to the procfs module.  COMPAT_43 should be enough according
to my
> > > > quick examining /sys/fs/procfs.
> > > 
> > > Was the case corrected in BETA2? A couple of days ago I upgraded
from
> > > CURRENT (middle of June 2005) to BETA1. The problem existed but
the
> > > patch helped.
> 
> > Alas, no one has displayed interest in fixing this bug since I left
> > for vacation.  I committed the fix to CURRENT today although I
don't
> > use procfs, which is a kind of a situation I hate.  MFC to RELENG_6
> > is due in 3 days.
> 
> Could you (or somebody else) MFC the patch to RELENG_6?
RELENG_6 is frozen now, so I must receive RE's approval
before merging my change to the branch.  Discussion with
re@ and some expert developers is under way.  Applying for
the approval has appeared the best way to draw attention
to the issue :-)

-- 
Yar