joe on anna ~ $: uname -a FreeBSD anna.chthonixia.net 4.9-STABLE FreeBSD 4.9-STABLE #1: Thu Jan 1 12:56:25 EST 2004 root@anna.chthonixia.net:/usr/obj/usr/src/sys/ANNA i386 /usr/src I AM ROOT ttyp5 # make buildkernel KERNCONF=ANNA At about Tue Jan 13 15:46:02 EST 2004 proceeds normally until: cc -O -pipe -include /usr/obj/usr/src/sys/ANNA/opt_global.h -D_KERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/../include -mpreferred-stack-boundary=2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -c /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c: In function `union_lookup': /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c:598: `td' undeclared (first use in this function) /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c:598: (Each undeclared identifier is reported only once /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c:598: for each function it appears in.) vnode_if.h:876: warning: inlining failed in call to `VOP_UNLOCK' /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c:598: warning: called from here /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c: In function `union_inactive': /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c:1705: warning: unused variable `vpp' /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c: In function `union_unlock': /usr/src/sys/modules/union/../../miscfs/union/union_vnops.c:1803: warning: unused variable `un' *** Error code 1 Stop in /usr/src/sys/modules/union. *** Error code 1 Stop in /usr/src/sys/modules. *** Error code 1 Stop in /usr/obj/usr/src/sys/ANNA. *** Error code 1 Stop in /usr/src. *** Error code 1 -- The George W. Bush Five Point Economic Recovery Plan: Hunt, Kill, Eat, Hump, Shit.
Arrggh... I got so used to -STABLE being, well, "stable" that I sent
the
patch to fix this off to -current instead of -stable. Sorry.... :-(
Anyway, this worked for me on 2 machines, but I don't actually use
unionfs on either one:
Index: sys/miscfs/union/union_vnops.c
==================================================================RCS file:
/cvs/freebsd/src/sys/miscfs/union/Attic/union_vnops.c,v
retrieving revision 1.72.2.2
diff -u -r1.72.2.2 union_vnops.c
--- sys/miscfs/union/union_vnops.c 13 Jan 2004 06:51:55 -0000 1.72.2.2
+++ sys/miscfs/union/union_vnops.c 13 Jan 2004 14:02:09 -0000
@@ -595,7 +595,7 @@
*/
if (*ap->a_vpp != dvp) {
if (!lockparent || (cnp->cn_flags & ISLASTCN) == 0)
- VOP_UNLOCK(dvp, 0, td);
+ VOP_UNLOCK(dvp, 0, p);
}
if (cnp->cn_namelen == 1 &&
And copying a note from my misdirected post:
["td" is a "struct *thread", from KSE. What's defined
earlier in the
source is "struct *proc p".]
Peace,
david
--
David H. Wolfskill david@catwhisker.org
If you want true virus-protection for your PC, install a non-Microsoft OS
on it. Plausible candidates include FreeBSD, Linux, NetBSD, OpenBSD, and
Solaris (in alphabetical order).