Libguestfs - Mar 2012 - [PATCH] Remove call to set_autosync.

From: "Richard W.M. Jones" <rjones at redhat.com>

This is the default since libguestfs 1.6.  It does not need to be
explicitly set.

See also https://bugzilla.redhat.com/show_bug.cgi?id=799798#c6
---
 lib/Sys/VirtConvert/GuestfsHandle.pm |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/lib/Sys/VirtConvert/GuestfsHandle.pm
b/lib/Sys/VirtConvert/GuestfsHandle.pm
index 01d7eb0..c370007 100644
--- a/lib/Sys/VirtConvert/GuestfsHandle.pm
+++ b/lib/Sys/VirtConvert/GuestfsHandle.pm
@@ -103,9 +103,6 @@ sub new
         &$open();
     }
 
-    # Enable autosync to defend against data corruption on unclean shutdown
-    $g->set_autosync(1);
-
     $self->{g} = $g;
 
     $self->{onclose} = [];
-- 
1.7.9.1

On Mon, Mar 05, 2012 at 08:55:23AM +0000, Richard W.M. Jones
wrote:
> From: "Richard W.M. Jones" <rjones at redhat.com>
> 
> This is the default since libguestfs 1.6.  It does not need to be
> explicitly set.
> 
> See also https://bugzilla.redhat.com/show_bug.cgi?id=799798#c6
> ---
>  lib/Sys/VirtConvert/GuestfsHandle.pm |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/Sys/VirtConvert/GuestfsHandle.pm
b/lib/Sys/VirtConvert/GuestfsHandle.pm
> index 01d7eb0..c370007 100644
> --- a/lib/Sys/VirtConvert/GuestfsHandle.pm
> +++ b/lib/Sys/VirtConvert/GuestfsHandle.pm
> @@ -103,9 +103,6 @@ sub new
>          &$open();
>      }
>  
> -    # Enable autosync to defend against data corruption on unclean
shutdown
> -    $g->set_autosync(1);
> -
>      $self->{g} = $g;
>  
>      $self->{onclose} = [];
In case it's not clear, this is a virt-v2v patch ...  I meant to
put that in the subject line.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

On 03/05/2012 08:55 AM, Richard W.M. Jones wrote:
> From: "Richard W.M. Jones"<rjones at redhat.com>
>
> This is the default since libguestfs 1.6.  It does not need to be
> explicitly set.
>
> See also https://bugzilla.redhat.com/show_bug.cgi?id=799798#c6
> ---
>   lib/Sys/VirtConvert/GuestfsHandle.pm |    3 ---
>   1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/lib/Sys/VirtConvert/GuestfsHandle.pm
b/lib/Sys/VirtConvert/GuestfsHandle.pm
> index 01d7eb0..c370007 100644
> --- a/lib/Sys/VirtConvert/GuestfsHandle.pm
> +++ b/lib/Sys/VirtConvert/GuestfsHandle.pm
> @@ -103,9 +103,6 @@ sub new
>           &$open();
>       }
>
> -    # Enable autosync to defend against data corruption on unclean
shutdown
> -    $g->set_autosync(1);
> -
>       $self->{g} = $g;
>
>       $self->{onclose} = [];
ACK. Can you please push it?

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490