Nut upsdev - Dec 2011 - [nut-commits] svn commit r3363 - in trunk: data docs/man drivers

On Dec 17, 2011, at 3:53 AM, Arnaud Quette wrote:
> Author: aquette
> Date: Sat Dec 17 08:53:41 2011
> New Revision: 3363
> URL: http://trac.networkupstools.org/projects/nut/changeset/3363
> 
> Log:
> Try to fix language ID support for USB units from LDLC, Dynamix and no
names in blazer_usb (reworked patch, from Brian R. Smith and Aur?lien Grenotton)
...
> +			if (testvar("langid_fix")) {
> +				/* Hardcode lang to 0x4095 */
> +				ret = usb_get_string(udev, command[i].index, 0x4095, buf, buflen);
> +			}
Arnaud,

Could this code use the langid_fix value which is set in upsdrv_initups()
instead of 0x4095? Or am I misunderstanding how this is supposed to work?

- Charles

2011/12/17 Charles Lepple <clepple at gmail.com>
> On Dec 17, 2011, at 3:53 AM, Arnaud Quette wrote:
>
> > Author: aquette
> > Date: Sat Dec 17 08:53:41 2011
> > New Revision: 3363
> > URL: http://trac.networkupstools.org/projects/nut/changeset/3363
> >
> > Log:
> > Try to fix language ID support for USB units from LDLC, Dynamix and no
> names in blazer_usb (reworked patch, from Brian R. Smith and Aur?lien
> Grenotton)
> ...
> > +                     if (testvar("langid_fix")) {
> > +                             /* Hardcode lang to 0x4095 */
> > +                             ret = usb_get_string(udev,
> command[i].index, 0x4095, buf, buflen);
> > +                     }
>
> Arnaud,
>
> Could this code use the langid_fix value which is set in upsdrv_initups()
> instead of 0x4095? Or am I misunderstanding how this is supposed to work?

damn, could catch. I've triple checked everything, except that!
in the end, there is a debugx value that should help doing so automatically

A call for testing mail is underway...

thanks,
Arno
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20111217/943d8ad1/attachment.html>