rsync - Sep 2010 - DO NOT REPLY [Bug 7668] New: Add --omit-symlink-times option, same purpose as --omit-dir-times

https://bugzilla.samba.org/show_bug.cgi?id=7668

           Summary: Add --omit-symlink-times option, same purpose as --omit-
                    dir-times
           Product: rsync
           Version: 3.0.7
          Platform: All
        OS/Version: FreeBSD
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: korvus at comcast.net
         QAContact: rsync-qa at samba.org


When using rsnyc, files are always recreated (as the user performing the rsync)
on the destination when the source file has a later mtime, regardless of
changes.  Symlinks however, are NOT recreated when the mtime differs; instead,
the mtime is simply adjusted on the destination.  This is problematic because a
user who does not own a symlink can not adjust the mtime of that symlink to a
time that isn't time(NULL) (now) - see utimes(2).  Thus rsync fails with
"failed to set times on...".  The rest of the rsync completes, but
scripts
utilizing rsync may rely on the return codes.

This is likely the same reason that the --omit-dir-times option exists: it is
not trivial (or necessary) to recreate a directory to update the mtime.  I have
a patch which adds the --omit-symlink-times option to rsync, I will submit it
if anyone is interested in committing it.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7668





------- Comment #1 from carlos at fisica.ufpr.br  2010-09-07 09:25 CST -------
You mean this?

author  Wayne Davison <wayned at samba.org>        

         Thu, 26 Aug 2010 15:50:05 +0000 (08:50 -0700)

committer       Wayne Davison <wayned at samba.org>        

         Thu, 26 Aug 2010 18:12:58 +0000 (11:12 -0700)

commit  2624e005e2c2407c8e108230e6615d2aaba42617

tree    aefd03f05797d1b2dda9d2e27e1e64d92bdb79d6        tree

parent  c9bf436e5b80ad7d001773e3d750149c11f39411        commit | diff


Add --omit-link-times and use CAN_SET_SYMLINK_TIMES less.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7668


korvus at comcast.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME




------- Comment #2 from korvus at comcast.net  2010-09-07 09:52 CST -------
Yes, that is precisely the feature.  When I first posted to the rsync mailing
list about it on 08/06/2010, no one had stated that it was already being worked
on or even planned.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7668





------- Comment #3 from wayned at samba.org  2010-09-07 18:48 CST -------
I had meant to reply to your on-list email on this subject, but apparently
forgot.  I had been working on another symlink bug relating to time when your
email prompted me to add the option you suggested (with a name more in keeping
with rsync's other symlink-related options).

Thanks for the suggestion!


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=7668

Steve Polyack <korvus at comcast.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |

--- Comment #4 from Steve Polyack <korvus at comcast.net> 2011-09-28
17:30:26 UTC ---
This ticket from 2010 describing the --omit-link-times seems to have been lost.
 The commit and change that Carlos lists in Comment 1 does not seem to be
present in rsync-3.0.9 despite it being released a few days ago.

Has this change been reverted for some reason?  The option would be quite
useful.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

https://bugzilla.samba.org/show_bug.cgi?id=7668

Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
            Version|3.0.9                       |3.1.0
         Resolution|                            |WORKSFORME

--- Comment #5 from Wayne Davison <wayned at samba.org> 2011-09-28
20:17:09 UTC ---
New options are coming in 3.1.0.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.