Destroy ACL-s on destination when no ACL-s differens between source and destination. Bug is somehow related with function send_file_name() called with negative file descriptor f. There is no such bug in 2.6.9 version, but there options "-X -A --deleted" can't be used (we have "Internal error: wrong write used in receiver."). If I fix this, avoid calling send_acl() & send_xattr() with negative descriptor I get the same ACL bug in 2.6.9 . -- Stanislaw Gruszka ---------------------------------------------------- Sprawd? ile jest wart Tw?j samoch?d! W ycena aut jak na d?oni -> http://klik.wp.pl/?adr=www.wycenyaut.wp.pl&sid=1047
On Thu, Mar 08, 2007 at 03:00:38PM +0100, Stanis?aw Gruszka wrote:> Destroy ACL-s on destination when no ACL-s differens between source > and destination.Can you explain this a little more?> we have "Internal error: wrong write used in receiver."Yes, this is a known problem with the acls.patch and xattrs.patch in 2.6.9: http://lists.samba.org/archive/rsync/2006-November/016706.html http://lists.samba.org/archive/rsync/2006-November/016710.html ..wayne..
Dnia 8-03-2007 o godz. 15:00 Stanis?aw Gruszka napisa?(a):> Destroy ACL-s on destination when no ACL-s differens between > source and destination.Wayne, here is example: stasiu@sg /mnt/hda5 $ getfacl --omit-header export/file user::rw- user:apache:-w- group::r-- mask::rw- other::r-- stasiu@sg /mnt/hda5 $ getfacl --omit-header copy/file user::rw- group::r-- other::r-- stasiu@sg /mnt/hda5 $ rsync -av -X -A --delete 127.0.0.1::rsync-export copy receiving incremental file list sent 2859 bytes received 38449 bytes 6355.08 bytes/sec total size is 32768693 speedup is 793.28 stasiu@sg /mnt/hda5 $ getfacl --omit-header copy/file user::rw- user:apache:-w- group::r-- mask::rw- other::r-- stasiu@sg /mnt/hda5 $ rsync -av -X -A --delete 127.0.0.1::rsync-export copy receiving incremental file list sent 308 bytes received 35898 bytes 10344.57 bytes/sec total size is 32768693 speedup is 905.06 stasiu@sg /mnt/hda5 $ getfacl --omit-header copy/file user::rw- group::rw- other::r-- ---------------------------------------------------- Kelnerka, asystentka, ksi?gowa, informatyk – sprawd? mo?e to w?a?nie Ciebie poszukuj? pracodawcy! http://klik.wp.pl/?adr=http%3A%2F%2Fpraca.wp.pl%2Fwyniki_wyszukiwania.html&sid=1050
good catch !!> -----Original Message----- > From: Stanislaw Gruszka [mailto:stf_xl@wp.pl] > Sent: Friday, March 09, 2007 2:25 AM > To: rsync > Subject: Re: [BUG] clear ACL-s on destination > > > > Dnia 9-03-2007 o godz. 8:30 Stanis?aw Gruszka napisa?(a): > > > > Dnia 8-03-2007 o godz. 15:00 Stanis?aw Gruszka napisa?(a): > > > Destroy ACL-s on destination when no ACL-s differens between > > > source and destination. > > I found it, function rsync_xal_set() remove > system.posix_acl_access xattr which internally contains ACL-s. > > In rsync_xal_set() should be something like that: > > /* Remove any extraneous names, don't touch system xattr's. */ > for (name = namebuf; list_len > 0; name += name_len) { > name_len = strlen(name) + 1; > list_len -= name_len; > > for (i = 0; i < xalp->count; i++) { > if (strcmp(name, rxas[i].name) == 0 || > strncmp(name, "system.", 7) == 0) > break; > } > > > -- > Stanislaw Gruszka > > ---------------------------------------------------- > Castingi Elite Model Look. Ju? 17 i 18 marca w Twoim mie?cie. > Nie przegap szansy! Wi?cej informacji: > http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fd86.html&sid=1053 -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html