rsync - Apr 2005 - PATCH: cosmetic fix to output with --existing -vv

Currently, rsync --delete -avvn test1/ test2/ --existing 
will give output such as:

not creating new file "newdir"
not creating new file "newdir/newfile"
not creating new file "newdir/subdir"

It would make more sense if it said:

not creating new directory "newdir"
not creating new file "newdir/newfile"
not creating new directory "newdir/subdir"


This following simple patch fixes this.

Paul Slootman

--- generator.c.orig	2005-04-10 21:15:07.000000000 +0200
+++ generator.c	2005-04-10 21:15:08.000000000 +0200
@@ -665,7 +665,8 @@
 	if (only_existing && statret == -1 && stat_errno == ENOENT) {
 		/* we only want to update existing files */
 		if (verbose > 1) {
-			rprintf(FINFO, "not creating new file \"%s\"\n",
+			rprintf(FINFO, "not creating new %s \"%s\"\n",
+                                S_ISDIR(file->mode) ? "directory"
: "file",
 				safe_fname(fname));
 		}
 		return;

On Sun, Apr 10, 2005 at 09:22:13PM +0200, Paul Slootman
wrote:
> It would make more sense if it said:
> 
> not creating new directory "newdir"
Yeah, that's much nicer.  I've applied your fix to the CVS version.

Also, I was just looking at the patches for the Debian unstable version
of rsync 2.6.4, and I noticed these issues:

 - There is a patch to create the script "rsyncstats" even though an
   updated version of the script is present in the "support" subdir of
   the rsync tar file.

 - The change to support --address in client mode is incomplete.  The
   full patch for options.c is here:

   
http://build.samba.org/build.pl?function=text_diff;tree=rsync;date=1112680789;author=wayned

   and the doc changes are here:

   
http://build.samba.org/build.pl?function=text_diff;tree=rsync;date=1112680817;author=wayned

   Your version is not buggy (i.e. the option will work fine), just not
   complete, so perhaps you prefer simple over complete in this case.

..wayne..