rsync - Jun 2004 - [Bug 1463] poor performance with large block size

https://bugzilla.samba.org/show_bug.cgi?id=1463





------- Additional Comments From wayned@samba.org  2004-06-18 14:45 -------
Created an attachment (id=543)
 --> (https://bugzilla.samba.org/attachment.cgi?id=543&action=view)
Suggested patch from Craig Barratt

Wallace Matthews confirmed that this alleviates the poor performance.

Just need to confirm that the window isn't getting too large with this (I
will
check into this later unless someone else beats me to it).

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1463


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #543 is|0                           |1
           obsolete|                            |




------- Additional Comments From wayned@samba.org  2004-07-16 10:57 -------
Created an attachment (id=573)
 --> (https://bugzilla.samba.org/attachment.cgi?id=573&action=view)
Improved patch

I created a patch similar to Craig's that instead modifies the MAX_MAP_SIZE
value (using a new "max_map_size" variable) which is based on the
current
file's block size.  This means that we get more consistent sizing (since
"len"
can vary) and that the sequence of window_size checks works out as originally
intended (maxing out at either the end of the file or at offset + len,
whichever is greater).

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=1463


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From wayned@samba.org  2004-07-16 11:13 -------
I checked-in my improved patch, which should resolve this bug.

We may still wish to review the map_ptr() code to see if we can optimize it even
further, but this should be good enough for now.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.