Matthew Booth
2010-Oct-29 10:06 UTC
[Libguestfs] [PATCH] Fix build of po-docs during initial build
Building po-docs currently fails because po-docs/ja/Makefile.am requires files which are generated by po-docs/Makefile.am, which the latter does not create by default. This patch doesn't fix the dependencies properly, but fixes the problem by ensuring that po-docs/Makefile.am will build all LINGUA deps by default. --- po-docs/Makefile.am | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Fix-build-of-po-docs-during-initial-build.patch Type: text/x-patch Size: 308 bytes Desc: not available URL: <http://listman.redhat.com/archives/libguestfs/attachments/20101029/5ac4ea80/attachment.bin>
Richard W.M. Jones
2010-Oct-29 11:03 UTC
[Libguestfs] [PATCH] Fix build of po-docs during initial build
On Fri, Oct 29, 2010 at 11:06:23AM +0100, Matthew Booth wrote:> > Building po-docs currently fails because po-docs/ja/Makefile.am requires files > which are generated by po-docs/Makefile.am, which the latter does not create by > default. > > This patch doesn't fix the dependencies properly, but fixes the problem by > ensuring that po-docs/Makefile.am will build all LINGUA deps by default.NAK, it's wrong to update-po on an ordinary build. This would mean that the po files are constantly being rebuilt. They should only be rebuilt at 'make dist' time. Another problem is that if po4a is lacking, then no amount of 'update-po' can fix the build. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v