Libguestfs - Feb 2010 - [PATCH] add_cdrom: Update docs for adding ISO images.

Just a simple doc fix.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
-------------- next part --------------
>From 8d70639e27c79ce88c1e61898536c17cd71258e7 Mon Sep 17 00:00:00 2001
From: Richard Jones <rjones at redhat.com>
Date: Fri, 12 Feb 2010 11:27:44 +0000
Subject: [PATCH] add_cdrom: Update docs for adding ISO images.

See also RHBZ#563450 (NB: This commit does not fix the bug).
---
 src/generator.ml |   18 ++++++++++++++++--
 1 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/src/generator.ml b/src/generator.ml
index 44dc8a5..2cede47 100755
--- a/src/generator.ml
+++ b/src/generator.ml
@@ -505,10 +505,24 @@ This function adds a virtual CD-ROM disk image to the
guest.
 
 This is equivalent to the qemu parameter C<-cdrom filename>.
 
-Note that this call checks for the existence of C<filename>.  This
+Notes:
+
+=over 4
+
+=item *
+
+This call checks for the existence of C<filename>.  This
 stops you from specifying other types of drive which are supported
 by qemu such as C<nbd:> and C<http:> URLs.  To specify those, use
-the general C<guestfs_config> call instead.");
+the general C<guestfs_config> call instead.
+
+=item *
+
+If you just want to add an ISO file (often you use this as an
+efficient way to transfer large files into the guest), then you
+should probably use C<guestfs_add_drive_ro> instead.
+
+=back");
 
   ("add_drive_ro", (RErr, [String "filename"]), -1,
[FishAlias "add-ro"],
    [],
-- 
1.6.5.2

On 12/02/10 12:37, Richard W.M. Jones wrote:
> Subject: [PATCH] add_cdrom: Update docs for adding ISO images.
> 
> See also RHBZ#563450 (NB: This commit does not fix the bug).
> ---
>  src/generator.ml |   18 ++++++++++++++++--
>  1 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/src/generator.ml b/src/generator.ml
ACK.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490