On 11/14/2011 07:43 AM, Jon Ludlam wrote:> On 12 Nov 2011, at 09:17, Thomas Goirand wrote:
>> On 11/12/2011 12:16 AM, Jonathan Ludlam wrote:
>>> Secondly, there are a few more things that need to be done to your
>>> blktap
>>> packaging prior to uploading:
>>>
>>> * The xen-org/blktap.git repository builds and works for amd64
>>
>> This Git repository is not up to date. It isn't what I gave you to
>> review, and it's not using the 2.0.90 version that you gave me to
use.
>> I'll update it with the latest version shortly.
>>
>
> Are we talking about the same repository here? I'm talking about
> https://github.com/xen-org/blktap?
> I was just making sure that you included amd64 in the architectures,
> because there's no reason not to :-)
Sorry, I was saying that http://git.debian.org/git/pkg-xen/blktap.git,
but I wrote it in a very confusing manner. Now it is up-to-date anyway.
>> Vcs-Browser: http://git.debian.org/?p=pkg-xen/blktap.git
>> Vcs-Git: http://git.debian.org/git/pkg-xen/blktap.git
>>
>
> Oddly, the second link didn't work when I tried to check it out - the
> first gave an alternative
> (git://anonscm.debian.org/pkg-xen/blktap.git pkg-xen-blktap) that
> worked, though.
As much as I understand, git.debian.org redirects to anonscm on the web,
but git.debian.org should be used to clone/pull/push sources. The Debian
guys recently have split one unique server (alioth.debian.org) into 2,
and I am always confused. :)
Anyway, everything is working, got your patches in:
http://anonscm.debian.org/gitweb/?p=pkg-xen/blktap.git;a=shortlog;h=refs/heads/debian-sid
One last thing about your path patch. I am surprised that you are trying
to use the full path, eg /usr/sbin/vgs, instead of leaving the system
search path do its work. It looks necessary complication for me. Can you
explain?
Anyway, I think we're ready for an upload, right? If you confirm, then
I'll upload blktap.
> Ah sorry, didn't I mention it?
> it's https://github.com/jonludlam/blktap-dkms.git - the debian
> packaging stuff is on the debian branch. When we've fixed any issues,
> I'll stick it in the xen-org
> space on github as the 'official' blktap kernel module.
Cool!
I've started looking at it, and already, there are minor (but necessary
to make a successful upload) modification that I'm about to send to you.
I'm talking about things like debian/copyright, some tweaks in
debian/control (section, standard-version, etc.) missing
debian/source/format, etc. By the way, I have just filled an ITP for
this package.
Thomas Goirand (zigo)
