This is the second version of my patch, this one is much more clean, since it's using upstream Makefile. This is the most urgent patch, since we need it in order to build xen-api-libs / xen-api. Please really consider applying this patch. Thomas -------------- next part -------------- A non-text attachment was scrubbed... Name: 09_ocaml.diff Type: text/x-diff Size: 4680 bytes Desc: not available URL: <http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20110829/5a87c14a/attachment.diff>
On 08/29/2011 06:00 PM, Thomas Goirand wrote:> This is the second version of my patch, this one is much more clean, > since it's using upstream Makefile. This is the most urgent patch, since > we need it in order to build xen-api-libs / xen-api. Please really > consider applying this patch. > > ThomasSorry, last patch was wrong, here's the correct working one with valid path for the dll*.so files. Maybe it's possible to use debian/build/install-utils_$(ARCH) but at least here it's working... Thomas -------------- next part -------------- A non-text attachment was scrubbed... Name: 09_ocaml.diff Type: text/x-diff Size: 4685 bytes Desc: not available URL: <http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20110829/35161b8b/attachment.diff>
On 07/09/2011 15:21, St?phane Glondu wrote:> Le 31/08/2011 17:31, Thomas Goirand a ?crit : >> I have set debian-ocaml-maint at lists.debian.org as Cc: to this email, in >> the hope that the Debian OCaml task force can have a last look on my >> work. I''d appreciate comments, and I hope I didn''t do mistakes this >> time. Please keep in mind that I don''t know much about OCaml... > > I haven''t looked at everything, but it seems that your packages creates > a lot of subdirectories with seemingly generic names directly in > @OCamlStdlibDir@, which seems abusive. For example, I see uuidm, which > is already installed by libuuidm-ocaml-dev. IMHO, it would be saner to > e.g. create a single "xen" at @OCamlStdlibDir@ root, and subdirs there. > The same thing applies for the findlib namespace (META files). >Hum? good point. I also noticed the same and forgot about it. I was wondering if that uuidm is the same provided by libuuidm-ocaml-dev. Didn''t check that yet. I''ll let you (Thomas) do that. Cheers. -- Mehdi Dogguy ???? ????? mehdi@{dogguy.org,debian.org}
On 09/07/2011 09:26 PM, Mehdi Dogguy wrote:> On 07/09/2011 15:21, St?phane Glondu wrote: >> Le 31/08/2011 17:31, Thomas Goirand a ?crit : >>> I have set debian-ocaml-maint at lists.debian.org as Cc: to this email, in >>> the hope that the Debian OCaml task force can have a last look on my >>> work. I''d appreciate comments, and I hope I didn''t do mistakes this >>> time. Please keep in mind that I don''t know much about OCaml... >> >> I haven''t looked at everything, but it seems that your packages creates >> a lot of subdirectories with seemingly generic names directly in >> @OCamlStdlibDir@, which seems abusive. For example, I see uuidm, which >> is already installed by libuuidm-ocaml-dev. IMHO, it would be saner to >> e.g. create a single "xen" at @OCamlStdlibDir@ root, and subdirs there. >> The same thing applies for the findlib namespace (META files). >> > > Hum? good point. I also noticed the same and forgot about it. I was > wondering if that uuidm is the same provided by libuuidm-ocaml-dev. Didn''t > check that yet. I''ll let you (Thomas) do that. > > Cheers. >Mike, Jonathan, can we have your useful comment on this? Namely: - Is your uuidm a fork of libuuidm-ocaml-dev? Can you make it so we use that one instead of what''s in Xen 4.1.1? - Can we use @OCamlStdlibDir@/xen/libname for all the files that aren''t .so? Will it be an issue later? We really need your feedback here. Also, I tried once more to build xen-api-libs in SID, and it failed to build, even with the xen-api-libs-debian patches from Jonathan. Can you look into that so we can move forward with this packaging as well? Thomas