Elmar Hoffmann
2006-May-28 21:29 UTC
[Logcheck-devel] superflous localhost rule in oident rules
Hi, the rule explicitly matching localhost is superflous, as the general rule matching all hostnames/IP addresses right after it matches localhost aswell. The attached patch removes it. elmar -- .'"`. /"\ | :' : Elmar Hoffmann <elho at elho.net> ASCII Ribbon Campaign \ / `. `' GPG key available via pgp.net against HTML email X `- & vCards / \ -------------- next part -------------- Index: rulefiles/linux/ignore.d.server/oidentd ==================================================================RCS file: /cvsroot/logcheck/logcheck/rulefiles/linux/ignore.d.server/oidentd,v retrieving revision 1.5 diff -u -r1.5 oidentd --- rulefiles/linux/ignore.d.server/oidentd 18 Sep 2004 21:24:30 -0000 1.5 +++ rulefiles/linux/ignore.d.server/oidentd 28 May 2006 21:05:08 -0000 @@ -1,4 +1,3 @@ -^\w{3} [ :0-9]{11} [._[:alnum:]-]+ oidentd\[[0-9]+\]: Connection from localhost \(127.0.0.1\):[0-9]{1,5}$ ^\w{3} [ :0-9]{11} [._[:alnum:]-]+ oidentd\[[0-9]+\]: Connection from [._[:alnum:]-]+ \([0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\):[0-9]{1,5}$ ^\w{3} [ :0-9]{11} [._[:alnum:]-]+ oidentd\[[0-9]+\]: Connection from [0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}:[0-9]{1,5}$ ^\w{3} [ :0-9]{11} [._[:alnum:]-]+ oidentd\[[0-9]+\]: \[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\] Successful lookup \(by forward\): [0-9]+ \([0-9]+\) , [0-9]+ : [_[:alnum:]-]+$ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20060528/32a00e8d/attachment.pgp
Jamie L. Penman-Smithson
2006-Jun-04 19:34 UTC
[Logcheck-devel] superflous localhost rule in oident rules
On 28 May 2006, at 22:29, Elmar Hoffmann wrote:> the rule explicitly matching localhost is superflous, as the general > rule matching all hostnames/IP addresses right after it matches > localhost aswell. > The attached patch removes it.Thanks for the heads up, this'll be fixed in the next release. -j -------------- next part -------------- A non-text attachment was scrubbed... Name: PGP.sig Type: application/pgp-signature Size: 186 bytes Desc: This is a digitally signed message part Url : http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20060604/5fc60549/attachment.pgp