Nut upsdev - Aug 2007 - [nut-commits] svn commit r1049 - in trunk: . drivers

Alexander Gordeev wrote:
> Author: agordeev-guest
> Date: Mon Aug 13 13:09:43 2007
> New Revision: 1049
> 
> Log:
> drivers/megatec_usb.c: added credits to the banner message.
Is this really needed/desirable? I think this kind of information needs
to be put in the AUTHORS document. There are many more people on this
list that put a lot of effort in NUT, without claiming credit so openly.

Just my 2c.

Best regards, Arjen
> Modified:
>    trunk/ChangeLog
>    trunk/drivers/megatec_usb.c
> 
> Modified: trunk/ChangeLog
>
=============================================================================>
--- trunk/ChangeLog	(original)
> +++ trunk/ChangeLog	Mon Aug 13 13:09:43 2007
> @@ -1,3 +1,7 @@
> +Mon Aug 13 13:08:13 UTC 2007 / Alexander I. Gordeev <lasaine at
lvk.cs.msu.su>
> +
> + * drivers/megatec_usb.c: added credits to the banner message.
> +
>  Mon Aug 13 09:28:42 UTC 2007 / Arjen de Korte <arjen at
de-korte.org>
>  
>   * data/cmdvartab, docs/new-names.txt:
> 
> Modified: trunk/drivers/megatec_usb.c
>
=============================================================================>
--- trunk/drivers/megatec_usb.c	(original)
> +++ trunk/drivers/megatec_usb.c	Mon Aug 13 13:09:43 2007
> @@ -132,8 +132,8 @@
>  
>  void megatec_subdrv_banner()
>  {
> -	printf("Serial-over-USB transport layer for Megatec protocol driver
[%s]\n\n", progname);
> -	/* printf("Andrey Lelikov (c) 2006, Alexander Gordeev (c) 2006-2007,
Jon Gough (c) 2007\n\n"); */
> +	printf("Serial-over-USB transport layer for Megatec protocol driver
[%s]\n", progname);
> +	printf("Andrey Lelikov (c) 2006, Alexander Gordeev (c) 2006-2007,
Jon Gough (c) 2007\n\n");
>  }
>  
>  /* FIXME: Fix "serial" variable (which conflicts with
"serial" variable in megatec.c) */
> 
> _______________________________________________
> nut-commits mailing list
> nut-commits at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/nut-commits
>

On Mon, 13 Aug 2007 23:52:02 +0400, Arjen de Korte <arjen at de-korte.org>
wrote:
> Alexander Gordeev wrote:
>
>> Author: agordeev-guest
>> Date: Mon Aug 13 13:09:43 2007
>> New Revision: 1049
>>
>> Log:
>> drivers/megatec_usb.c: added credits to the banner message.
>
> Is this really needed/desirable? I think this kind of information needs
> to be put in the AUTHORS document. There are many more people on this
> list that put a lot of effort in NUT, without claiming credit so openly.
>
> Just my 2c.
>
> Best regards, Arjen
>
There was a request from Carlos Rodrigues (at the end of the message):

------- Forwarded message -------
From: "Carlos Rodrigues" <carlos.efr at mail.telepac.pt>
To: nut-upsuser at lists.alioth.debian.org, nut-upsdev at
lists.alioth.debian.org
Cc:
Subject: Re: [Nut-upsuser] energizerups and bestups -> megatec?
Date: Sat, 07 Jul 2007 16:52:30 +0400

On 7/7/07, D?niel Fraga <fragabr at gmail.com>
wrote:
> On Fri, 6 Jul 2007 19:33:07 +0100
> "Carlos Rodrigues" <carlos.efr at mail.telepac.pt> wrote:
>
> > And there's "energizerups"... How feasible is it to have
"megatec_usb"
> > obsolete this driver?
>
>         Hi Carlos, could you help me with a megatec_usb problem?
>
>         If I use one of thesse options (krauler or agiler) it returns
> the following:
>
> sudo ../bin/megatec_usb -u root -a tsshara -DD
[snip]

Actually, I'm not of much help in megatec_usb issues, since I'm not
the author of that driver. But the people in the know should be
reading this.

BTW (for the authors of megatec_usb), the banner for "megatec_usb"
only shows my name (from the core/serial layer), when it should also
show the authors/maintainers of the USB layer.



I believe this line will just stop the mess. People should not disturb
Carlos when they have megatec_usb specific problems.

--
   Alexander

>> Is this really needed/desirable? I think this kind of information needs
>> to be put in the AUTHORS document. There are many more people on this
>> list that put a lot of effort in NUT, without claiming credit so
openly.
>>
>> Just my 2c.
>
> I agree that this information should be in the AUTHORS document, but I
> also thing the driver banner should mention someone that's responsible
> for answering questions about it. Users tend to contact whoever gets
> its name printed on the console.
And that's exactly why I think this should not be in the banner. :-)
> I get a few emails about megatec_usb because my name gets printed by
> the megatec "core", and while I'm not bothered by it per se,
I can't
> usually give any decent answer, and the user would be better off just
> contacting the subdriver maintainer(s) directly.
The problem I have with putting this in the driver, is that in many cases,
drivers long outlive the commitment of their authors to maintain them.
Also, you may have other things on your mind and have no time to answer
questions. If people have questions, they should go to the 'nut-upsuser'
mailinglist, not contact authors directly.

Fortunately, there are currently just a handful of drivers that list an
author: megatec(_usb), solis and upscode2. I we should remove those from
the banner.

Best regards, Arjen
-- 
Eindhoven - The Netherlands
Key fingerprint - 66 4E 03 2C 9D B5 CB 9B  7A FE 7E C1 EE 88 BC 57