Good Day Has anybody here looked closely at the call cost calculation in ASTCC? Can you duplicate the way the cost of a call is calculated? I believe that there is an error in the code. I have fixed it, I think and submitted a patch but we need user comments. I would appreciate if anybody involved would slip over to chech out this link on the bugtracker and provide feedback. http://bugs.digium.com/view.php?id=4480 I may well be wrong but I believe the issue needs visiting. Somebody was asking me how it calculates costs as they thought they knew what a call should cost. I said "I'll show you". Mistake, I could not come up with an answer that made sense. Please let me know, Darren Wiebe
Darren Wiebe wrote:> Good Day > > Has anybody here looked closely at the call cost calculation in > ASTCC? Can you duplicate the way the cost of a call is calculated? I > believe that there is an error in the code. I have fixed it, I think > and submitted a patch but we need user comments. I would appreciate > if anybody involved would slip over to chech out this link on the > bugtracker and provide feedback. http://bugs.digium.com/view.php?id=4480 > I may well be wrong but I believe the issue needs visiting. Somebody > was asking me how it calculates costs as they thought they knew what a > call should cost. I said "I'll show you". Mistake, I could not come > up with an answer that made sense. >Darren, looking at the page you will find two patches. The description is very short. Which patch do you want us to instal? If one is wrong, would you please delete it. What should be the purpose of the patch? "Calc charges" does not give me a clear picture of it. Looking at the patch (picked one) I see that the entire "update database" is deleted. How should I than alter the tables? Another question regarding my tarriff patch, ... How to get this into CVS? bye Ronald> Please let me know, > > Darren Wiebe > _______________________________________________ > Asterisk-Users mailing list > Asterisk-Users@lists.digium.com > http://lists.digium.com/mailman/listinfo/asterisk-users > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users > > >-- Ronald Wiplinger (CEO of ELMIT) http://www.elmit.com +886 (0) 939--77-55-16 or FWD 511208 - I'm a SpamCon Foundation Member, #694, Verify it at http://www.spamcon.org PS: Spam prevention! Our system is protected with a spam prevention program. If you send us an e-mail, our system will send you a confirmation message back. Just reply to this confirmation message please. After receiving this confirmation message, our system will send the hold message (one) and all future messages (after the received confirmation message) to me without asking you again.
On Fri, June 17, 2005 5:19 pm, Darren Wiebe said:> Good Day > > Has anybody here looked closely at the call cost calculation in ASTCC? > Can you duplicate the way the cost of a call is calculated? I believe > that there is an error in the code. I have fixed it, I think and > submitted a patch but we need user comments. I would appreciate if > anybody involved would slip over to chech out this link on the > bugtracker and provide feedback. http://bugs.digium.com/view.php?id=4480 > I may well be wrong but I believe the issue needs visiting. Somebody > was asking me how it calculates costs as they thought they knew what a > call should cost. I said "I'll show you". Mistake, I could not come up > with an answer that made sense. >Darren, I took a quick look at the patch. I'm not certain, but it appears that you've taken out the formula that factors in the billing increment. This forumla, inything other than a 1 second incement, will always "add" time to the call for any number of seconds not equally divisible by the billing increment integer, resulting in a slightly higher cost than might be expected at first glance. This is the way it is supposed to work. As I said, I only glanced at it briefly. Could you describe your changes and the error you were seeing?