asterisk users - Jun 2003 - Queue App Patch

Hi there,

I am not a true C programmer.  PERL is my game, just hacked around at C 
for a long time.
Anyways, I digress...

Here is a patch, can you tell me:
1) Can you see any blaring security holes I may have created
2) Does it make sense.

It is for the queue app.  It will allow you to do a few things 
(currently not finished :)
1) Set an announcetimeout in queues.conf.
         This variable seemed unused in app_queue.c
         This is the time in seconds in which I will stop MOH, and play 
something like "You are currently caller # XXX"
2) I also have planned for small advertisements to cut into the MOH,  I 
am thinking of a separate directory, and
         playing a random advertisement every so often, hence the 
advert_timeout and advert_dir in queues.conf.


Please give me feedback, this is my first release of a patch to ANY 
community, I want to know how badly I suck :).
  Everyone that I have talked to in the asterisk community has been 
GREAT!

Thank you,

John Congdon
congdonj (IRC)

Hi everyone,

Here is an updated patch.

Changes:

A) Tells the caller their position in the queue:
      1) When they enter the queue
      2) When their position changes
You just need to record the "You are caller #" to YouArePos.gsm

B) Plays an announcement to the caller every XX seconds
     example)  All customer service reps are busy, please hold or press 
* to leave a message
You just need to record this message to QueueAnnouncement.gsm

Future Plans:
Kick out of queue after pre determined time


http://pbx.usedontmiss.com/queue_patch


Please let me know if I screwed anything up...

Thank you