Hi,
The 4.4p1 release is approaching now, so we are now asking people to
actively test snapshots or CVS and report back to the mailing list.
Snapshots are available from http://www.mindrot.org/openssh_snap or
from any of the mirrors listed on http://www.openssh.org/portable.html
The latter page also includes instructions for checking out portable
OpenSSH via anonymous CVS.
This release contains many bugfixes and feature improvements. Here
are some highlights:
- Implemented conditional configuration in sshd_config(5) using the
"Match" directive. This allows some configuration options to be
selectively overridden if specific criteria (based on user, group,
hostname and/or address) are met. So far a useful subset of post-
authentication options are supported and more are expected to be
added in future releases.
- Added a "ForceCommand" directive to sshd_config(5). Similar to the
command="..." option accepted in ~/.ssh/authorized_keys, this forces
the execution of the specified command regardless of what the user
requested. This is very useful in conjunction with the new "Match"
option.
- Add a "PermitOpen" directive to sshd_config(5). This mirrors the
permitopen="..." authorized_keys option, allowing fine-grained
control over the port-forwardings that a user is allowed to
establish.
- Add optional logging of transactions to sftp-server(8).
- ssh(1) will now record port numbers for hosts stored in
~/.ssh/authorized_keys when a non-standard port has been requested.
- Add an "ExitOnForwardFailure" options to cause ssh(1) to exit (with
a non-zero exit code) when requested port forwardings could not be
established.
- Extend the sshd_config(5) "SubSystem" directive to allow the
specification of commandline arguments.
- Add optional support for SELinux, controlled using the --with-selinux
configure option (experimental)
- Add optional support for Solaris process contracts, enabled using the
--with-solaris-contracts configure option (experimental)
- Add support for Diffie-Hellman group exchange key agreement with a
final hash of SHA256.
- Fixed a lot of bugs. See
http://bugzilla.mindrot.org/show_bug.cgi?id=1155 for an incomplete
list (more in the ChangeLog)
- Lots of manpage fixes and improvements
- Many code cleanups, including:
- Switching to safer memory allocation functions that avoid integer
overflows when allocating arrays
- Cleanups of header file usage (ongoing)
- Fixes to leaks reported by the Coverity static analysis tool
Running the regression tests supplied with Portable does not require
installation, just run:
$ ./configure && make tests
Testing on suitable non-production systems is also appreciated. Please send
reports of success or failure to openssh-unix-dev at mindrot.org, including
details of your platform, compiler and configure options.
Thanks,
Damien Miller
On Aug 30 23:41, Damien Miller wrote:> Hi, > > The 4.4p1 release is approaching now, so we are now asking people to > actively test snapshots or CVS and report back to the mailing list. > [...] > $ ./configure && make tests > > Testing on suitable non-production systems is also appreciated. Please send > reports of success or failure to openssh-unix-dev at mindrot.org, including > details of your platform, compiler and configure options.Cygwin 1.5.21, OpenSSL 0.9.8b OpenSSH has been configured with the following options: User binaries: /usr/bin System binaries: /usr/sbin Configuration files: /etc Askpass program: ${prefix}/sbin/ssh-askpass Manual pages: /usr/share/man/manX PID file: /var/run Privilege separation chroot path: /var/empty sshd default user PATH: /bin:/usr/sbin:/sbin:/usr/bin Manpage format: doc PAM support: no KerberosV support: no SELinux support: no Smartcard support: no S/KEY support: no TCP Wrappers support: yes MD5 password support: no libedit support: no IP address in $DISPLAY hack: no Translate v4 in v6 hack: no BSD Auth support: no Random number source: OpenSSL internal ONLY Host: i686-pc-cygwin Compiler: gcc Compiler flags: -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare Preprocessor flags: Linker flags: Libraries: -lwrap -lresolv -lcrypto -lz /usr/lib/textmode.o -lcrypt Configures and builds OOTB. make tests works mostly, but sftp-badcmds.sh test is broken and results in core dumps when evaluating the result of a glob() call. The reason is a bit complicated and what confused me first was the fact that this didn't happen under earlier versions of sftp. Actually, OpenSSH didn't use Cygwin's glob() implementation before (which is a relatively old NetBSD derived implementation), because the configure test for gl_matchc failed up to 4.3p2. The AC_EGREP_CPP autoconf test failed, while the new AC_TRY_COMPILE test in 4.4p1 now works, so starting with 4.4p1, OpenSSH uses Cygwin's glob function. But why does it core dump? The reason is that the old glob implementation in Cygwin doesn't know about the GLOB_NOMATCH return code. In case there's no match, it returns 0, with gl_matchc set to 0 and gl_pathv set to NULL. Unfortunately, this situation is not recognized as "File not found" condition in sftp. The result is that process_put as well as process_get SEGV when accessing g.gl_pathv[0]. What can we do? Of course we will update the glob function in Cygwin for the next Cygwin version, but that won't help for older and current versions of Cygwin. As a workaround in sftp, I applied the below patch, which also checks for gl_matchc being 0 to recognize a "File not found" condition. Would that be ok for sftp? Index: sftp.c ==================================================================RCS file: /cvs/openssh/sftp.c,v retrieving revision 1.97 diff -p -u -r1.97 sftp.c --- sftp.c 5 Aug 2006 02:39:40 -0000 1.97 +++ sftp.c 30 Aug 2006 15:55:30 -0000 @@ -535,7 +535,7 @@ process_get(struct sftp_conn *conn, char memset(&g, 0, sizeof(g)); debug3("Looking up %s", abs_src); - if (remote_glob(conn, abs_src, 0, NULL, &g)) { + if (remote_glob(conn, abs_src, 0, NULL, &g) || g.gl_matchc == 0) { error("File \"%s\" not found.", abs_src); err = -1; goto out; @@ -603,7 +603,7 @@ process_put(struct sftp_conn *conn, char memset(&g, 0, sizeof(g)); debug3("Looking up %s", src); - if (glob(src, 0, NULL, &g)) { + if (glob(src, 0, NULL, &g) || g.gl_matchc == 0) { error("File \"%s\" not found.", src); err = -1; goto out; Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat
On 08/30/2006 23:41, Damien Miller wrote: [...]> Testing on suitable non-production systems is also appreciated. Please send > reports of success or failure to openssh-unix-dev at mindrot.org, including > details of your platform, compiler and configure options.Building from SNAP-20060831 on SCO OSR6 w/MP2 and the MP2 Supplement, using system compiler, with configure invoked as: export CFLAGS="-I /u/include" ./configure \ --prefix=/u \ --with-ldflags="-s -L /u/lib" \ --with-ssl-dir=/u/etc/openssl \ --with-privsep-path=/u/var/empty \ --sysconfdir=/u/etc/openssh-4.4p1 \ --with-pid-dir=/u/etc/openssh-4.4p1 \ --with-tcp-wrappers \ --disable-lastlog \ --with-xauth=/usr/bin/X11/xauth Build fails at port-uw.c: cc -I /u/include -I. -I.. -I. -I./.. -I/u/etc/openssl/include -DHAVE_CONFIG_H -c port-uw.c UX:acomp: WARNING: "/usr/include/sys/socket.h", line 371: macro redefined: CMSG_DATA UX:acomp: WARNING: "/usr/include/sys/socket.h", line 386: macro redefined: CMSG_FIRSTHDR UX:acomp: WARNING: "/usr/include/netinet/in_f.h", line 105: macro redefined: INADDR_LOOPBACK UX:acomp: WARNING: "/usr/include/netinet/in6_f.h", line 100: macro redefined: IN6_IS_ADDR_V4MAPPED UX:acomp: ERROR: "../log.h", line 63: Syntax error before or at: va_list UX:acomp: ERROR: "../auth.h", line 109: Syntax error before or at: Key UX:acomp: ERROR: "../auth.h", line 112: Syntax error before or at: * UX:acomp: ERROR: "../auth.h", line 113: Syntax error before or at: * UX:acomp: ERROR: "../auth.h", line 114: Syntax error before or at: * UX:acomp: ERROR: "../auth.h", line 115: Syntax error before or at: Key UX:acomp: ERROR: "../auth.h", line 117: Syntax error before or at: Key UX:acomp: ERROR: "../auth.h", line 118: Syntax error before or at: Key UX:acomp: ERROR: "../auth.h", line 119: Syntax error before or at: Key UX:acomp: ERROR: "../auth.h", line 173: syntax error, probably missing ",", ";" or "=" UX:acomp: ERROR: "../auth.h", line 173: cannot recover from previous errors make[1]: *** [port-uw.o] Error 1 make[1]: Leaving directory `/u1/src/rac/openssh/openssh/openbsd-compat' make: *** [openbsd-compat/libopenbsd-compat.a] Error 2 -- Roger Cornelius rac at tenzing.org
Sometime ago, Damien Miller wrote: [...]> Testing on suitable non-production systems is also appreciated. Please send > reports of success or failure to openssh-unix-dev at mindrot.org, including > details of your platform, compiler and configure options. >The 20060830 snapshot configures, but fails to build on IRIX 6.5.29 usign the MIPSpro 7.4 compilers. export CC=c99 export CFLAGS="-g -O3 -mips3 -r14000" PREFIX=/usr/prg/pkg/openssh/4.4p1 OPENSSL=$HOME/build ZLIB=$HOME/build ./configure --prefix=$PREFIX \ --sysconfdir=/usr/prg/etc \ --with-ssl-dir=$OPENSSL \ --with-zlib=$ZLIB \ --with-tcp-wrappers=/usr/local \ --with-md5-passwords \ --with-pam There are numberous warnings, but here's the part that causes the compile to fail: c99 -g -O3 -mips3 -r14000 -I. -I.. -I. -I./.. -I/u/imorgan/build/include -I/usr/local/include -I/u/imorgan/build/include -DHAVE_CONFIG_H -c port-irix.c cc-1047 c99: WARNING File = /usr/include/sys/socket.h, Line = 645 Macro "CMSG_DATA" (declared at line 476 of "../defines.h") has an incompatible redefinition. #define CMSG_DATA(cmsg) ((uchar_t *)((cmsg) + 1)) ^ cc-1047 c99: WARNING File = /usr/include/sys/socket.h, Line = 654 Macro "CMSG_FIRSTHDR" (declared at line 484 of "../defines.h") has an incompatible redefinition. #define CMSG_FIRSTHDR(mhdr) ((struct cmsghdr *)(mhdr)->msg_control) ^ cc-1047 c99: WARNING File = /usr/include/sys/socket.h, Line = 656 Macro "CMSG_SPACE" (declared at line 471 of "../defines.h") has an incompatible redefinition. #define CMSG_SPACE(length) _ALIGN(sizeof(struct cmsghdr) + (length)) ^ cc-1047 c99: WARNING File = /usr/include/sys/socket.h, Line = 658 Macro "CMSG_LEN" (declared at line 466 of "../defines.h") has an incompatible redefinition. #define CMSG_LEN(length) (sizeof(struct cmsghdr) + length) ^ cc-1047 c99: WARNING File = /usr/include/sys/endian.h, Line = 46 Macro "LITTLE_ENDIAN" (declared at line 498 of "../defines.h") has an incompatible redefinition. #define LITTLE_ENDIAN _LITTLE_ENDIAN ^ cc-1047 c99: WARNING File = /usr/include/sys/endian.h, Line = 47 Macro "BIG_ENDIAN" (declared at line 501 of "../defines.h") has an incompatible redefinition. #define BIG_ENDIAN _BIG_ENDIAN ^ cc-1047 c99: WARNING File = /usr/include/sys/endian.h, Line = 52 Macro "BYTE_ORDER" (declared at line 504 of "../defines.h") has an incompatible redefinition. #define BYTE_ORDER _BYTE_ORDER ^ cc-1047 c99: WARNING File = /usr/include/netinet/in.h, Line = 228 Macro "INADDR_LOOPBACK" (declared at line 143 of "../defines.h") has an incompatible redefinition. #define INADDR_LOOPBACK (__uint32_t)0x7F000001 ^ cc-1047 c99: WARNING File = /usr/include/netinet/in.h, Line = 633 Macro "IN6_IS_ADDR_V4MAPPED" (declared at line 431 of "../defines.h") has an incompatible redefinition. #define IN6_IS_ADDR_V4MAPPED(p) IS_IPV4ADDR6(*p) ^ cc-1196 c99: WARNING File = port-irix.c, Line = 60 The indicated function is declared implicitly. fatal("Failed to create job container: %.100s", ^ cc-1020 c99: ERROR File = port-irix.c, Line = 61 The identifier "errno" is undefined. strerror(errno)); ^ cc-1196 c99: WARNING File = port-irix.c, Line = 66 The indicated function is declared implicitly. fatal("Failed to set up new array session: %.100s", ^ cc-1020 c99: ERROR File = port-irix.c, Line = 67 The identifier "errno" is undefined. strerror(errno)); ^ cc-1196 c99: WARNING File = port-irix.c, Line = 72 The indicated function is declared implicitly. debug("Failed to get project id, using projid 0"); ^ cc-1196 c99: WARNING File = port-irix.c, Line = 76 The indicated function is declared implicitly. fatal("Failed to initialize project %d for %s: %.100s", ^ cc-1020 c99: ERROR File = port-irix.c, Line = 77 The identifier "errno" is undefined. (int)projid, pw->pw_name, strerror(errno)); ^ cc-1196 c99: WARNING File = port-irix.c, Line = 81 The indicated function is declared implicitly. debug("Setting sat id to %d", (int) pw->pw_uid); ^ cc-1020 c99: ERROR File = port-irix.c, Line = 83 The identifier "errno" is undefined. debug("error setting satid: %.100s", strerror(errno)); ^ 4 errors detected in the compilation of "port-irix.c". *** Error code 2 (bu21) *** Error code 1 (bu21) -- Iain Morgan
Sometime ago, Damien Miller wrote: [...]> Testing on suitable non-production systems is also appreciated. Please send > reports of success or failure to openssh-unix-dev at mindrot.org, including > details of your platform, compiler and configure options. >Configures, builds and tests OK on SLES 9 (Itanium) using gcc 3.3.3. -- Iain Morgan
Hi,
"make tests" fails in dynamic-forward.sh on FreeBSD here. I just
retried 4.3p2, "make tests" runs ok with this version, including
dynamic-forward.sh
Hope this helps,
Flavien.
---
System : FreeBSD 5.4-STABLE i386
Version tested : openssh-SNAP-20060830.tar.gz
GCC version : gcc (GCC) 3.4.2 [FreeBSD] 20040728
$ ./configure --without-zlib-version-check && make tests
[...]
OpenSSH has been configured with the following options:
User binaries: /usr/local/bin
System binaries: /usr/local/sbin
Configuration files: /usr/local/etc
Askpass program: /usr/local/libexec/ssh-askpass
Manual pages: /usr/local/share/man/manX
PID file: /var/run
Privilege separation chroot path: /var/empty
At runtime, sshd will use the path defined in /etc/login.conf
Make sure the path to scp is present, otherwise scp will not work
Manpage format: doc
PAM support: no
KerberosV support: no
SELinux support: no
Smartcard support: no
S/KEY support: no
TCP Wrappers support: no
MD5 password support: no
libedit support: no
IP address in $DISPLAY hack: no
Translate v4 in v6 hack: no
BSD Auth support: no
Random number source: OpenSSL internal ONLY
Host: i386-unknown-freebsd5.4
Compiler: gcc
Compiler flags: -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare
Preprocessor flags:
Linker flags:
Libraries: -lcrypto -lutil -lz -lcrypt
[...]
run test sftp-glob.sh ...
sftp glob: ls file
sftp glob: ls dir
ok sftp glob
run test reconfigure.sh ...
ok simple connect after reconfigure
run test dynamic-forward.sh ...
nc: unexpected reply size 31 (expected 10)
ssh_exchange_identification: Connection closed by remote host
cmp: EOF on /usr/home/flavien/src/openssh/regress/ls.copy
corrupted copy of /bin/ls
nc: unexpected reply size 31 (expected 10)
ssh_exchange_identification: Connection closed by remote host
cmp: EOF on /usr/home/flavien/src/openssh/regress/ls.copy
corrupted copy of /bin/ls
failed dynamic forwarding
*** Error code 1
Stop in /usr/home/flavien/src/openssh/regress.
*** Error code 1
On Wed, 30 Aug 2006, Roger Cornelius wrote:> Build fails at port-uw.c:Thanks for the test. Could you please try this (big) diff? Index: audit-bsm.c ==================================================================RCS file: /var/cvs/openssh/audit-bsm.c,v retrieving revision 1.3 diff -u -p -r1.3 audit-bsm.c --- audit-bsm.c 16 Aug 2006 01:40:45 -0000 1.3 +++ audit-bsm.c 31 Aug 2006 01:39:29 -0000 @@ -39,6 +39,7 @@ #include <sys/types.h> +#include <stdarg.h> #include <unistd.h> #include "ssh.h" Index: audit.c ==================================================================RCS file: /var/cvs/openssh/audit.c,v retrieving revision 1.4 diff -u -p -r1.4 audit.c --- audit.c 5 Aug 2006 14:05:10 -0000 1.4 +++ audit.c 31 Aug 2006 01:40:27 -0000 @@ -26,6 +26,9 @@ #include "includes.h" +#include <stdarg.h> +#include <string.h> + #ifdef SSH_AUDIT_EVENTS #include "audit.h" Index: auth-bsdauth.c ==================================================================RCS file: /var/cvs/openssh/auth-bsdauth.c,v retrieving revision 1.10 diff -u -p -r1.10 auth-bsdauth.c --- auth-bsdauth.c 5 Aug 2006 02:39:39 -0000 1.10 +++ auth-bsdauth.c 31 Aug 2006 01:40:37 -0000 @@ -27,6 +27,8 @@ #include <sys/types.h> +#include <stdarg.h> + #ifdef BSD_AUTH #include "xmalloc.h" #include "key.h" Index: auth-chall.c ==================================================================RCS file: /var/cvs/openssh/auth-chall.c,v retrieving revision 1.18 diff -u -p -r1.18 auth-chall.c --- auth-chall.c 5 Aug 2006 02:39:39 -0000 1.18 +++ auth-chall.c 31 Aug 2006 01:41:13 -0000 @@ -27,6 +27,8 @@ #include <sys/types.h> +#include <stdarg.h> + #include "xmalloc.h" #include "key.h" #include "hostfile.h" Index: auth-pam.c ==================================================================RCS file: /var/cvs/openssh/auth-pam.c,v retrieving revision 1.139 diff -u -p -r1.139 auth-pam.c --- auth-pam.c 5 Aug 2006 04:07:20 -0000 1.139 +++ auth-pam.c 31 Aug 2006 01:41:19 -0000 @@ -54,6 +54,7 @@ #include <errno.h> #include <signal.h> +#include <stdarg.h> #include <string.h> #include <unistd.h> Index: auth-rsa.c ==================================================================RCS file: /var/cvs/openssh/auth-rsa.c,v retrieving revision 1.63 diff -u -p -r1.63 auth-rsa.c --- auth-rsa.c 5 Aug 2006 02:39:39 -0000 1.63 +++ auth-rsa.c 31 Aug 2006 01:41:39 -0000 @@ -24,6 +24,7 @@ #include <pwd.h> #include <stdio.h> +#include <stdarg.h> #include <string.h> #include "xmalloc.h" Index: auth-shadow.c ==================================================================RCS file: /var/cvs/openssh/auth-shadow.c,v retrieving revision 1.10 diff -u -p -r1.10 auth-shadow.c --- auth-shadow.c 5 Aug 2006 04:07:20 -0000 1.10 +++ auth-shadow.c 31 Aug 2006 01:41:45 -0000 @@ -26,6 +26,7 @@ #if defined(USE_SHADOW) && defined(HAS_SHADOW_EXPIRE) #include <shadow.h> +#include <stdarg.h> #include <string.h> #include "key.h" Index: auth-sia.c ==================================================================RCS file: /var/cvs/openssh/auth-sia.c,v retrieving revision 1.16 diff -u -p -r1.16 auth-sia.c --- auth-sia.c 5 Apr 2005 10:58:38 -0000 1.16 +++ auth-sia.c 31 Aug 2006 01:42:16 -0000 @@ -25,14 +25,6 @@ #include "includes.h" #ifdef HAVE_OSF_SIA -#include "ssh.h" -#include "auth.h" -#include "auth-sia.h" -#include "log.h" -#include "servconf.h" -#include "canohost.h" -#include "uidswap.h" - #include <sia.h> #include <siad.h> #include <pwd.h> @@ -40,7 +32,16 @@ #include <setjmp.h> #include <sys/resource.h> #include <unistd.h> +#include <stdarg.h> #include <string.h> + +#include "ssh.h" +#include "auth.h" +#include "auth-sia.h" +#include "log.h" +#include "servconf.h" +#include "canohost.h" +#include "uidswap.h" extern ServerOptions options; extern int saved_argc; Index: auth1.c ==================================================================RCS file: /var/cvs/openssh/auth1.c,v retrieving revision 1.119 diff -u -p -r1.119 auth1.c --- auth1.c 5 Aug 2006 02:39:39 -0000 1.119 +++ auth1.c 31 Aug 2006 01:42:25 -0000 @@ -14,6 +14,7 @@ #include <sys/types.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> #include <unistd.h> Index: auth2-chall.c ==================================================================RCS file: /var/cvs/openssh/auth2-chall.c,v retrieving revision 1.34 diff -u -p -r1.34 auth2-chall.c --- auth2-chall.c 5 Aug 2006 08:50:35 -0000 1.34 +++ auth2-chall.c 31 Aug 2006 01:42:31 -0000 @@ -28,6 +28,7 @@ #include <sys/types.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> Index: auth2-gss.c ==================================================================RCS file: /var/cvs/openssh/auth2-gss.c,v retrieving revision 1.17 diff -u -p -r1.17 auth2-gss.c --- auth2-gss.c 5 Aug 2006 05:25:00 -0000 1.17 +++ auth2-gss.c 31 Aug 2006 01:43:02 -0000 @@ -30,6 +30,8 @@ #include <sys/types.h> +#include <stdarg.h> + #include "xmalloc.h" #include "key.h" #include "hostfile.h" Index: auth2-kbdint.c ==================================================================RCS file: /var/cvs/openssh/auth2-kbdint.c,v retrieving revision 1.6 diff -u -p -r1.6 auth2-kbdint.c --- auth2-kbdint.c 5 Aug 2006 02:39:39 -0000 1.6 +++ auth2-kbdint.c 31 Aug 2006 01:43:25 -0000 @@ -27,6 +27,8 @@ #include <sys/types.h> +#include <stdarg.h> + #include "xmalloc.h" #include "packet.h" #include "key.h" Index: auth2-none.c ==================================================================RCS file: /var/cvs/openssh/auth2-none.c,v retrieving revision 1.16 diff -u -p -r1.16 auth2-none.c --- auth2-none.c 5 Aug 2006 08:46:48 -0000 1.16 +++ auth2-none.c 31 Aug 2006 01:43:31 -0000 @@ -30,6 +30,7 @@ #include <sys/uio.h> #include <fcntl.h> +#include <stdarg.h> #include <unistd.h> #include "xmalloc.h" Index: authfd.c ==================================================================RCS file: /var/cvs/openssh/authfd.c,v retrieving revision 1.75 diff -u -p -r1.75 authfd.c --- authfd.c 5 Aug 2006 02:39:39 -0000 1.75 +++ authfd.c 31 Aug 2006 01:43:38 -0000 @@ -47,6 +47,7 @@ #include <fcntl.h> #include <stdlib.h> #include <signal.h> +#include <stdarg.h> #include <string.h> #include <unistd.h> Index: authfile.c ==================================================================RCS file: /var/cvs/openssh/authfile.c,v retrieving revision 1.75 diff -u -p -r1.75 authfile.c --- authfile.c 5 Aug 2006 02:39:39 -0000 1.75 +++ authfile.c 31 Aug 2006 01:43:45 -0000 @@ -49,6 +49,7 @@ #include <errno.h> #include <fcntl.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: cipher-3des1.c ==================================================================RCS file: /var/cvs/openssh/cipher-3des1.c,v retrieving revision 1.7 diff -u -p -r1.7 cipher-3des1.c --- cipher-3des1.c 5 Aug 2006 02:39:39 -0000 1.7 +++ cipher-3des1.c 31 Aug 2006 01:43:50 -0000 @@ -29,6 +29,7 @@ #include <openssl/evp.h> +#include <stdarg.h> #include <string.h> #include "xmalloc.h" Index: cipher-aes.c ==================================================================RCS file: /var/cvs/openssh/cipher-aes.c,v retrieving revision 1.6 diff -u -p -r1.6 cipher-aes.c --- cipher-aes.c 25 Mar 2006 13:03:22 -0000 1.6 +++ cipher-aes.c 31 Aug 2006 01:44:19 -0000 @@ -28,8 +28,12 @@ #include "openbsd-compat/openssl-compat.h" #ifdef USE_BUILTIN_RIJNDAEL +#include <sys/types.h> #include <openssl/evp.h> + +#include <stdarg.h> + #include "rijndael.h" #include "xmalloc.h" #include "log.h" Index: cipher-bf1.c ==================================================================RCS file: /var/cvs/openssh/cipher-bf1.c,v retrieving revision 1.6 diff -u -p -r1.6 cipher-bf1.c --- cipher-bf1.c 5 Aug 2006 02:39:39 -0000 1.6 +++ cipher-bf1.c 31 Aug 2006 01:44:28 -0000 @@ -29,6 +29,7 @@ #include <openssl/evp.h> +#include <stdarg.h> #include <string.h> #include "xmalloc.h" Index: cipher-ctr.c ==================================================================RCS file: /var/cvs/openssh/cipher-ctr.c,v retrieving revision 1.12 diff -u -p -r1.12 cipher-ctr.c --- cipher-ctr.c 5 Aug 2006 02:39:39 -0000 1.12 +++ cipher-ctr.c 31 Aug 2006 01:44:33 -0000 @@ -18,6 +18,7 @@ #include <sys/types.h> +#include <stdarg.h> #include <string.h> #include <openssl/evp.h> Index: clientloop.c ==================================================================RCS file: /var/cvs/openssh/clientloop.c,v retrieving revision 1.160 diff -u -p -r1.160 clientloop.c --- clientloop.c 5 Aug 2006 02:39:40 -0000 1.160 +++ clientloop.c 31 Aug 2006 01:44:43 -0000 @@ -78,6 +78,7 @@ #include <paths.h> #endif #include <signal.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: dh.c ==================================================================RCS file: /var/cvs/openssh/dh.c,v retrieving revision 1.41 diff -u -p -r1.41 dh.c --- dh.c 5 Aug 2006 02:39:40 -0000 1.41 +++ dh.c 31 Aug 2006 01:44:47 -0000 @@ -30,6 +30,7 @@ #include <openssl/bn.h> #include <openssl/dh.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: dns.c ==================================================================RCS file: /var/cvs/openssh/dns.c,v retrieving revision 1.24 diff -u -p -r1.24 dns.c --- dns.c 5 Aug 2006 02:39:40 -0000 1.24 +++ dns.c 31 Aug 2006 01:44:52 -0000 @@ -31,6 +31,7 @@ #include <sys/socket.h> #include <netdb.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> Index: entropy.c ==================================================================RCS file: /var/cvs/openssh/entropy.c,v retrieving revision 1.57 diff -u -p -r1.57 entropy.c --- entropy.c 5 Aug 2006 05:50:20 -0000 1.57 +++ entropy.c 31 Aug 2006 01:45:06 -0000 @@ -34,6 +34,7 @@ #ifdef HAVE_FCNTL_H # include <fcntl.h> #endif +#include <stdarg.h> #include <unistd.h> #include <openssl/rand.h> Index: gss-serv-krb5.c ==================================================================RCS file: /var/cvs/openssh/gss-serv-krb5.c,v retrieving revision 1.16 diff -u -p -r1.16 gss-serv-krb5.c --- gss-serv-krb5.c 5 Aug 2006 02:39:40 -0000 1.16 +++ gss-serv-krb5.c 31 Aug 2006 01:45:11 -0000 @@ -31,6 +31,7 @@ #include <sys/types.h> +#include <stdarg.h> #include <string.h> #include "xmalloc.h" Index: gss-serv.c ==================================================================RCS file: /var/cvs/openssh/gss-serv.c,v retrieving revision 1.21 diff -u -p -r1.21 gss-serv.c --- gss-serv.c 5 Aug 2006 02:39:40 -0000 1.21 +++ gss-serv.c 31 Aug 2006 01:45:16 -0000 @@ -30,6 +30,7 @@ #include <sys/types.h> +#include <stdarg.h> #include <string.h> #include <unistd.h> Index: hostfile.c ==================================================================RCS file: /var/cvs/openssh/hostfile.c,v retrieving revision 1.42 diff -u -p -r1.42 hostfile.c --- hostfile.c 5 Aug 2006 02:39:40 -0000 1.42 +++ hostfile.c 31 Aug 2006 01:45:23 -0000 @@ -46,6 +46,7 @@ #include <openssl/sha.h> #include <resolv.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: kex.c ==================================================================RCS file: /var/cvs/openssh/kex.c,v retrieving revision 1.82 diff -u -p -r1.82 kex.c --- kex.c 5 Aug 2006 02:39:40 -0000 1.82 +++ kex.c 31 Aug 2006 01:45:27 -0000 @@ -28,6 +28,7 @@ #include <sys/param.h> #include <signal.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: kexdhc.c ==================================================================RCS file: /var/cvs/openssh/kexdhc.c,v retrieving revision 1.9 diff -u -p -r1.9 kexdhc.c --- kexdhc.c 5 Aug 2006 02:39:40 -0000 1.9 +++ kexdhc.c 31 Aug 2006 01:45:32 -0000 @@ -27,6 +27,7 @@ #include <sys/types.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> #include <signal.h> Index: kexdhs.c ==================================================================RCS file: /var/cvs/openssh/kexdhs.c,v retrieving revision 1.7 diff -u -p -r1.7 kexdhs.c --- kexdhs.c 5 Aug 2006 02:39:40 -0000 1.7 +++ kexdhs.c 31 Aug 2006 01:45:38 -0000 @@ -26,6 +26,8 @@ #include "includes.h" #include <sys/types.h> + +#include <stdarg.h> #include <string.h> #include <signal.h> Index: kexgexc.c ==================================================================RCS file: /var/cvs/openssh/kexgexc.c,v retrieving revision 1.9 diff -u -p -r1.9 kexgexc.c --- kexgexc.c 5 Aug 2006 02:39:40 -0000 1.9 +++ kexgexc.c 31 Aug 2006 01:45:43 -0000 @@ -28,6 +28,7 @@ #include <sys/types.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> #include <signal.h> Index: kexgexs.c ==================================================================RCS file: /var/cvs/openssh/kexgexs.c,v retrieving revision 1.8 diff -u -p -r1.8 kexgexs.c --- kexgexs.c 5 Aug 2006 02:39:40 -0000 1.8 +++ kexgexs.c 31 Aug 2006 01:45:48 -0000 @@ -28,6 +28,7 @@ #include <sys/param.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> #include <signal.h> Index: key.c ==================================================================RCS file: /var/cvs/openssh/key.c,v retrieving revision 1.68 diff -u -p -r1.68 key.c --- key.c 5 Aug 2006 02:39:40 -0000 1.68 +++ key.c 31 Aug 2006 01:45:52 -0000 @@ -39,6 +39,7 @@ #include <openssl/evp.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> Index: loginrec.c ==================================================================RCS file: /var/cvs/openssh/loginrec.c,v retrieving revision 1.79 diff -u -p -r1.79 loginrec.c --- loginrec.c 5 Aug 2006 02:39:40 -0000 1.79 +++ loginrec.c 31 Aug 2006 01:46:02 -0000 @@ -156,6 +156,7 @@ #include <errno.h> #include <fcntl.h> #include <pwd.h> +#include <stdarg.h> #include <string.h> #include <unistd.h> Index: mac.c ==================================================================RCS file: /var/cvs/openssh/mac.c,v retrieving revision 1.12 diff -u -p -r1.12 mac.c --- mac.c 5 Aug 2006 02:39:40 -0000 1.12 +++ mac.c 31 Aug 2006 01:46:07 -0000 @@ -29,6 +29,7 @@ #include <openssl/hmac.h> +#include <stdarg.h> #include <string.h> #include <signal.h> Index: monitor.c ==================================================================RCS file: /var/cvs/openssh/monitor.c,v retrieving revision 1.117 diff -u -p -r1.117 monitor.c --- monitor.c 18 Aug 2006 14:22:41 -0000 1.117 +++ monitor.c 31 Aug 2006 01:46:14 -0000 @@ -40,6 +40,7 @@ #endif #include <pwd.h> #include <signal.h> +#include <stdarg.h> #include <stdlib.h> #include <string.h> Index: monitor_wrap.c ==================================================================RCS file: /var/cvs/openssh/monitor_wrap.c,v retrieving revision 1.69 diff -u -p -r1.69 monitor_wrap.c --- monitor_wrap.c 18 Aug 2006 14:22:41 -0000 1.69 +++ monitor_wrap.c 31 Aug 2006 01:46:19 -0000 @@ -33,6 +33,7 @@ #include <errno.h> #include <pwd.h> #include <signal.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> #include <unistd.h> Index: readconf.c ==================================================================RCS file: /var/cvs/openssh/readconf.c,v retrieving revision 1.135 diff -u -p -r1.135 readconf.c --- readconf.c 5 Aug 2006 02:39:40 -0000 1.135 +++ readconf.c 31 Aug 2006 01:46:27 -0000 @@ -24,6 +24,7 @@ #include <errno.h> #include <netdb.h> #include <signal.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> #include <unistd.h> Index: rsa.c ==================================================================RCS file: /var/cvs/openssh/rsa.c,v retrieving revision 1.31 diff -u -p -r1.31 rsa.c --- rsa.c 5 Aug 2006 02:39:40 -0000 1.31 +++ rsa.c 31 Aug 2006 01:46:37 -0000 @@ -64,6 +64,7 @@ #include <sys/types.h> +#include <stdarg.h> #include <string.h> #include "xmalloc.h" Index: scard-opensc.c ==================================================================RCS file: /var/cvs/openssh/scard-opensc.c,v retrieving revision 1.16 diff -u -p -r1.16 scard-opensc.c --- scard-opensc.c 4 May 2006 06:24:34 -0000 1.16 +++ scard-opensc.c 31 Aug 2006 01:53:28 -0000 @@ -26,8 +26,12 @@ #include "includes.h" #if defined(SMARTCARD) && defined(USE_OPENSC) +#include <sys/types.h> + #include <openssl/evp.h> #include <openssl/x509.h> + +#include <stdarg.h> #include <opensc/opensc.h> #include <opensc/pkcs15.h> Index: scard.c ==================================================================RCS file: /var/cvs/openssh/scard.c,v retrieving revision 1.34 diff -u -p -r1.34 scard.c --- scard.c 5 Aug 2006 02:39:40 -0000 1.34 +++ scard.c 31 Aug 2006 01:53:34 -0000 @@ -29,6 +29,7 @@ #include <sys/types.h> #include <sectok.h> +#include <stdarg.h> #include <string.h> #include <openssl/evp.h> Index: session.c ==================================================================RCS file: /var/cvs/openssh/session.c,v retrieving revision 1.347 diff -u -p -r1.347 session.c --- session.c 30 Aug 2006 01:07:40 -0000 1.347 +++ session.c 31 Aug 2006 01:53:56 -0000 @@ -53,6 +53,7 @@ #endif #include <pwd.h> #include <signal.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: ssh-add.c ==================================================================RCS file: /var/cvs/openssh/ssh-add.c,v retrieving revision 1.96 diff -u -p -r1.96 ssh-add.c --- ssh-add.c 5 Aug 2006 02:39:40 -0000 1.96 +++ ssh-add.c 31 Aug 2006 01:54:01 -0000 @@ -45,6 +45,7 @@ #include <fcntl.h> #include <pwd.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: ssh-agent.c ==================================================================RCS file: /var/cvs/openssh/ssh-agent.c,v retrieving revision 1.167 diff -u -p -r1.167 ssh-agent.c --- ssh-agent.c 5 Aug 2006 02:40:11 -0000 1.167 +++ ssh-agent.c 31 Aug 2006 01:54:08 -0000 @@ -58,6 +58,7 @@ # include <paths.h> #endif #include <signal.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <time.h> Index: ssh-dss.c ==================================================================RCS file: /var/cvs/openssh/ssh-dss.c,v retrieving revision 1.23 diff -u -p -r1.23 ssh-dss.c --- ssh-dss.c 5 Aug 2006 02:39:40 -0000 1.23 +++ ssh-dss.c 31 Aug 2006 01:55:42 -0000 @@ -30,6 +30,7 @@ #include <openssl/bn.h> #include <openssl/evp.h> +#include <stdarg.h> #include <string.h> #include "xmalloc.h" Index: ssh-keygen.c ==================================================================RCS file: /var/cvs/openssh/ssh-keygen.c,v retrieving revision 1.164 diff -u -p -r1.164 ssh-keygen.c --- ssh-keygen.c 5 Aug 2006 02:39:40 -0000 1.164 +++ ssh-keygen.c 31 Aug 2006 01:55:48 -0000 @@ -29,6 +29,7 @@ # include <paths.h> #endif #include <pwd.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: ssh-keysign.c ==================================================================RCS file: /var/cvs/openssh/ssh-keysign.c,v retrieving revision 1.36 diff -u -p -r1.36 ssh-keysign.c --- ssh-keysign.c 5 Aug 2006 02:39:40 -0000 1.36 +++ ssh-keysign.c 31 Aug 2006 01:55:52 -0000 @@ -30,6 +30,7 @@ #include <paths.h> #endif #include <pwd.h> +#include <stdarg.h> #include <stdlib.h> #include <string.h> #include <unistd.h> Index: ssh-rsa.c ==================================================================RCS file: /var/cvs/openssh/ssh-rsa.c,v retrieving revision 1.39 diff -u -p -r1.39 ssh-rsa.c --- ssh-rsa.c 5 Aug 2006 02:39:40 -0000 1.39 +++ ssh-rsa.c 31 Aug 2006 01:55:57 -0000 @@ -22,6 +22,7 @@ #include <openssl/evp.h> #include <openssl/err.h> +#include <stdarg.h> #include <string.h> #include "xmalloc.h" Index: ssh.c ==================================================================RCS file: /var/cvs/openssh/ssh.c,v retrieving revision 1.282 diff -u -p -r1.282 ssh.c --- ssh.c 5 Aug 2006 02:39:41 -0000 1.282 +++ ssh.c 31 Aug 2006 01:56:06 -0000 @@ -60,6 +60,7 @@ #endif #include <pwd.h> #include <signal.h> +#include <stdarg.h> #include <stddef.h> #include <stdio.h> #include <stdlib.h> Index: sshconnect.c ==================================================================RCS file: /var/cvs/openssh/sshconnect.c,v retrieving revision 1.168 diff -u -p -r1.168 sshconnect.c --- sshconnect.c 5 Aug 2006 02:39:41 -0000 1.168 +++ sshconnect.c 31 Aug 2006 01:56:11 -0000 @@ -32,6 +32,7 @@ #include <paths.h> #endif #include <pwd.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: sshconnect1.c ==================================================================RCS file: /var/cvs/openssh/sshconnect1.c,v retrieving revision 1.70 diff -u -p -r1.70 sshconnect1.c --- sshconnect1.c 5 Aug 2006 02:39:41 -0000 1.70 +++ sshconnect1.c 31 Aug 2006 01:56:37 -0000 @@ -21,6 +21,7 @@ #include <openssl/bn.h> #include <openssl/md5.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: sshconnect2.c ==================================================================RCS file: /var/cvs/openssh/sshconnect2.c,v retrieving revision 1.152 diff -u -p -r1.152 sshconnect2.c --- sshconnect2.c 30 Aug 2006 01:08:34 -0000 1.152 +++ sshconnect2.c 31 Aug 2006 01:56:42 -0000 @@ -33,6 +33,7 @@ #include <errno.h> #include <pwd.h> #include <signal.h> +#include <stdarg.h> #include <stdio.h> #include <string.h> #include <unistd.h> Index: sshd.c ==================================================================RCS file: /var/cvs/openssh/sshd.c,v retrieving revision 1.355 diff -u -p -r1.355 sshd.c --- sshd.c 30 Aug 2006 17:24:41 -0000 1.355 +++ sshd.c 31 Aug 2006 01:56:50 -0000 @@ -65,6 +65,7 @@ #include <grp.h> #include <pwd.h> #include <signal.h> +#include <stdarg.h> #include <stdio.h> #include <stdlib.h> #include <string.h> Index: openbsd-compat/bsd-cray.c ==================================================================RCS file: /var/cvs/openssh/openbsd-compat/bsd-cray.c,v retrieving revision 1.15 diff -u -p -r1.15 bsd-cray.c --- openbsd-compat/bsd-cray.c 24 Jul 2006 05:08:36 -0000 1.15 +++ openbsd-compat/bsd-cray.c 31 Aug 2006 01:57:00 -0000 @@ -52,6 +52,7 @@ #include <sys/secstat.h> #include <sys/stat.h> #include <sys/session.h> +#include <stdarg.h> #include <stdlib.h> #include <string.h> #include <unistd.h> Index: openbsd-compat/port-aix.c ==================================================================RCS file: /var/cvs/openssh/openbsd-compat/port-aix.c,v retrieving revision 1.38 diff -u -p -r1.38 port-aix.c --- openbsd-compat/port-aix.c 30 Aug 2006 12:33:10 -0000 1.38 +++ openbsd-compat/port-aix.c 31 Aug 2006 01:57:07 -0000 @@ -41,6 +41,7 @@ # include <netdb.h> #endif #include <uinfo.h> +#include <stdarg.h> #include <string.h> #include <unistd.h> #include <sys/socket.h> Index: openbsd-compat/port-linux.c ==================================================================RCS file: /var/cvs/openssh/openbsd-compat/port-linux.c,v retrieving revision 1.2 diff -u -p -r1.2 port-linux.c --- openbsd-compat/port-linux.c 24 Jul 2006 04:51:01 -0000 1.2 +++ openbsd-compat/port-linux.c 31 Aug 2006 01:57:13 -0000 @@ -24,6 +24,7 @@ #include "includes.h" #include <errno.h> +#include <stdarg.h> #include <string.h> #ifdef WITH_SELINUX Index: openbsd-compat/port-solaris.c ==================================================================RCS file: /var/cvs/openssh/openbsd-compat/port-solaris.c,v retrieving revision 1.1 diff -u -p -r1.1 port-solaris.c --- openbsd-compat/port-solaris.c 30 Aug 2006 17:24:42 -0000 1.1 +++ openbsd-compat/port-solaris.c 31 Aug 2006 01:57:17 -0000 @@ -29,6 +29,7 @@ #ifdef HAVE_FCNTL_H # include <fcntl.h> #endif +#include <stdarg.h> #include <string.h> #include <unistd.h> Index: openbsd-compat/port-uw.c ==================================================================RCS file: /var/cvs/openssh/openbsd-compat/port-uw.c,v retrieving revision 1.3 diff -u -p -r1.3 port-uw.c --- openbsd-compat/port-uw.c 9 Sep 2005 04:56:34 -0000 1.3 +++ openbsd-compat/port-uw.c 31 Aug 2006 02:02:41 -0000 @@ -26,15 +26,26 @@ #include "includes.h" #ifdef HAVE_LIBIAF +#include <sys/types.h> #ifdef HAVE_CRYPT_H -#include <crypt.h> +# include <crypt.h> #endif +#include <pwd.h> +#include <stdarg.h> +#include <stdlib.h> +#include <stdio.h> +#include <string.h> + +#include "xmalloc.h" #include "packet.h" #include "buffer.h" +#include "auth-options.h" #include "log.h" #include "servconf.h" +#include "key.h" +#include "hostfile.h" #include "auth.h" -#include "auth-options.h" +#include "ssh.h" int nischeck(char *);
On Wed, 30 Aug 2006, Damien Miller wrote:> Running the regression tests supplied with Portable does not require > installation, just run: > > $ ./configure && make tests > > Testing on suitable non-production systems is also appreciated. Please send > reports of success or failure to openssh-unix-dev at mindrot.org, including > details of your platform, compiler and configure options.On RHL73 with gcc 2.96, 'make tests' doesn't finish and appears to get stuck (strace shows the process is in wait()). There were a number of compilation warnings. The ones coming from ciphers and macs appear to be old, but these are new and at least implicit decls should be easily fixable: warning: __nonnull__' attribute directive ignored (50+ times) uidswap.c: In function Permanently_drop_suid': uidswap.c:142: warning: implicit declaration of function Setresuid' uidswap.c: In function Permanently_set_uid': uidswap.c:224: warning: implicit declaration of function Setresgid' md5crypt.c: In function To64': md5crypt.c:31: warning: implicit declaration of function Memset' md5crypt.c: In function s_md5_salt': md5crypt.c:43: warning: implicit declaration of function Strncmp' md5crypt.c:43: warning: implicit declaration of function Strlen' md5crypt.c: In function Md5_crypt': md5crypt.c:73: warning: implicit declaration of function Memcpy' OpenSSH has been configured with the following options: User binaries: /usr/local/bin System binaries: /usr/local/sbin Configuration files: /usr/local/etc Askpass program: /usr/local/libexec/ssh-askpass Manual pages: /usr/local/share/man/manX PID file: /var/run Privilege separation chroot path: /var/empty sshd default user PATH: /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin Manpage format: doc PAM support: yes KerberosV support: no SELinux support: no Smartcard support: no S/KEY support: no TCP Wrappers support: yes MD5 password support: yes libedit support: no IP address in $DISPLAY hack: no Translate v4 in v6 hack: yes BSD Auth support: no Random number source: OpenSSL internal ONLY Host: i686-pc-linux-gnu Compiler: gcc Compiler flags: -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -std=gnu99 Preprocessor flags: Linker flags: Libraries: -lresolv -lcrypto -lutil -lz -lnsl -lcrypt The last messages are: ... run test dynamic-forward.sh ... skipped (no suitable ProxyCommand found) run test forwarding.sh ... bind: Address already in use Waiting for forwarded connections to terminate... The following connections are open: #9 direct-tcpip: listening port 3322 for 127.0.0.1 port 3372, connect from 127.0.0.1 port 44310 (t4 r17 i0/0 o0/0 fd 18/18 cfd -1) #10 direct-tcpip: listening port 3372 for 127.0.0.1 port 3321, connect from 127.0.0.1 port 44311 (t4 r18 i0/0 o0/0 fd 19/19 cfd -1) #11 direct-tcpip: listening port 3321 for 127.0.0.1 port 3371, connect from 127.0.0.1 port 44312 (t4 r19 i0/0 o0/0 fd 20/20 cfd -1) #12 direct-tcpip: listening port 3371 for 127.0.0.1 port 3320, connect from 127.0.0.1 port 44313 (t4 r20 i0/0 o0/0 fd 21/21 cfd -1) #13 direct-tcpip: listening port 3320 for 127.0.0.1 port 3370, connect from 127.0.0.1 port 44314 (t4 r21 i0/0 o0/0 fd 22/22 cfd -1) #14 direct-tcpip: listening port 3370 for 127.0.0.1 port 3312, connect from 127.0.0.1 port 44315 (t4 r22 i0/0 o0/0 fd 23/23 cfd -1) #15 direct-tcpip: listening port 3312 for 127.0.0.1 port 3362, connect from 127.0.0.1 port 44316 (t4 r23 i0/0 o0/0 fd 24/24 cfd -1) #16 direct-tcpip: listening port 3362 for 127.0.0.1 port 3311, connect from 127.0.0.1 port 44317 (t4 r24 i0/0 o0/0 fd 25/25 cfd -1) #17 direct-tcpip: listening port 3311 for 127.0.0.1 port 3361, connect from 127.0.0.1 port 44318 (t4 r25 i0/0 o0/0 fd 26/26 cfd -1) #18 direct-tcpip: listening port 3361 for 127.0.0.1 port 3310, connect from 127.0.0.1 port 44319 (t4 r26 i0/0 o0/0 fd 27/27 cfd -1) [[ almost 10 minute timeout ]] ssh_exchange_identification: Connection closed by remote host cmp: EOF on /home/pekkas/op/openssh/regress/ls.copy corrupted copy of /bin/ls bind: Address already in use [[ about 5 minute timeout ]] failed local and remote forwarding make[1]: *** [t-exec] Error 1 make[1]: Leaving directory `/home/pekkas/op/openssh/regress' make: *** [tests] Error 2 I suspect (but didn't check) bind() errors may be due to the way mapped addresses affect bind() (I'm also using v6). HTH, -- Pekka Savola "You each name yourselves king, yet the Netcore Oy kingdom bleeds." Systems. Networks. Security. -- George R.R. Martin: A Clash of Kings
On Wed, Aug 30, 2006 at 11:41:53PM +1000, Damien Miller wrote:> actively test snapshots or CVS and report back to the mailing list.CVS 060831 10:38 UTC+2 gcc version 4.1.1 (Gentoo 4.1.1), OpenSSL 0.9.7j OpenSSH has been configured with the following options: User binaries: /usr/local/bin System binaries: /usr/local/sbin Configuration files: /usr/local/etc Askpass program: /usr/local/libexec/ssh-askpass Manual pages: /usr/local/share/man/manX PID file: /var/run Privilege separation chroot path: /var/empty sshd default user PATH: /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin Manpage format: doc PAM support: no OSF SIA support: no KerberosV support: no SELinux support: no Smartcard support: no S/KEY support: no TCP Wrappers support: no MD5 password support: no libedit support: no Solaris process contract support: no IP address in $DISPLAY hack: no Translate v4 in v6 hack: yes BSD Auth support: no Random number source: OpenSSL internal ONLY Host: i686-pc-linux-gnu Compiler: gcc Compiler flags: -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -std=gnu99 Preprocessor flags: Linker flags: Libraries: -lresolv -lcrypto -lutil -lz -lnsl -lcrypt Builds with warnings: servconf.c: In function 'process_server_config_line': servconf.c:980: warning: dereferencing type-punned pointer will break strict-aliasing rules servconf.c:991: warning: dereferencing type-punned pointer will break strict-aliasing rules I don't know C well enough to say what the best solution to this is. SyslogFacility and LogLevel are enums, ServerOptions.log_facility and .log_level are defined as SyslogFacility and LogLevel respectively. The above lines read (int *) &options->log_facility and (int *) &options->log_level. sftp.c: In function 'parse_dispatch_command': sftp.c:1028: warning: 'n_arg' may be used uninitialized in this function sftp.c:1027: warning: 'iflag' may be used uninitialized in this function sftp.c:1027: warning: 'lflag' may be used uninitialized in this function sftp.c:1027: warning: 'pflag' may be used uninitialized in this function parse_args() sets these, but can return with error before doing so. iflag is used to set err_abort=0 before the return code of parse_args() is checked. Attached patch initializes the above variables. All tests ok. //Peter -------------- next part -------------- --- sftp.c.orig 2006-08-31 10:44:33.000000000 +0200 +++ sftp.c 2006-08-31 10:44:57.000000000 +0200 @@ -1024,8 +1024,8 @@ int err_abort) { char *path1, *path2, *tmp; - int pflag, lflag, iflag, cmdnum, i; - unsigned long n_arg; + int pflag = 0, lflag = 0, iflag = 0, cmdnum, i; + unsigned long n_arg = 0; Attrib a, *aa; char path_buf[MAXPATHLEN]; int err = 0;
Fedora Core 5, with MIT Kerberos5 1.5.1 builds and make tests OK. Same
compiler warnings as Peter Stuge reports with Debian. I haven't fully
tested kerberos auth & tickets yet.
OpenSSH has been configured with the following options:
User binaries: /usr/local/bin
System binaries: /usr/local/sbin
Configuration files: /usr/local/etc
Askpass program: /usr/local/libexec/ssh-askpass
Manual pages: /usr/local/share/man/manX
PID file: /var/run
Privilege separation chroot path: /var/empty
sshd default user PATH:
/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin
Manpage format: doc
PAM support: no
KerberosV support: yes
SELinux support: no
Smartcard support: no
S/KEY support: no
TCP Wrappers support: no
MD5 password support: no
libedit support: no
IP address in $DISPLAY hack: no
Translate v4 in v6 hack: yes
BSD Auth support: no
Random number source: OpenSSL internal ONLY
Host: i686-pc-linux-gnu
Compiler: gcc
Compiler flags: -g -O2 -Wall -Wpointer-arith -Wuninitialized
-Wsign-compare -Wno-pointer-sign -std=gnu99
Preprocessor flags: -I/opt/kerberos/krb5-1.5.1/include
-I/opt/kerberos/krb5-1.5.1/include/gssapi
Linker flags: -L/opt/kerberos/krb5-1.5.1/lib
Libraries: -lresolv -lcrypto -lutil -lz -lnsl -lcrypt
-lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err
Hi All,
Test results in HP-UX Platforms:
Platform :
---------
HP-UX 11.00 PA-RISC
HP-UX 11.11 PA-RISC
HP-UX 11.23 IPF
Config options:
---------------
./configure --prefix=${SSHPATH} \
--with-pam \
--with-ssl-dir=${SSLPATH} \
--with-tcp-wrappers=${TCPWRAPPATH} \
--with-zlib=${ZLIBPATH} \
--with-kerberos5 \
--with-rand-helper \
--with-md5-passwords \
--with-4in6 \
--with-audit=debug
The openssh-SNAP-20060830 configures successfully. But build failed with the
following error:
/usr/ccs/bin/ld: Unsatisfied symbols:
ntohl (first referenced in sshconnect.o) (code)
ntohs (first referenced in ssh.o) (code)
htonl (first referenced in sshconnect.o) (code)
htons (first referenced in
openbsd-compat//libopenbsd-compat.a(rresvport.o)) (code)
*** Error exit code 1
Stop.
Problem Description:
----------------------
* The ntohl, ntohs, htonl, htons routines are defined as macros instead of
functions in <netinet/in.h> , linker raises "functions" not
found error.
Fix:
-----
Including the <arpa/inet.h> in includes.h file may fix this problem
Thanks,
Santhi.
----- Original Message -----
From: "Damien Miller" <djm at mindrot.org>
To: <openssh-unix-dev at mindrot.org>
Sent: Wednesday, August 30, 2006 7:11 PM
Subject: Testing for the 4.4p1 release
> Hi,
>
> The 4.4p1 release is approaching now, so we are now asking people to
> actively test snapshots or CVS and report back to the mailing list.
>
> Snapshots are available from http://www.mindrot.org/openssh_snap or
> from any of the mirrors listed on http://www.openssh.org/portable.html
> The latter page also includes instructions for checking out portable
> OpenSSH via anonymous CVS.
>
> This release contains many bugfixes and feature improvements. Here
> are some highlights:
>
> - Implemented conditional configuration in sshd_config(5) using the
> "Match" directive. This allows some configuration options to be
> selectively overridden if specific criteria (based on user, group,
> hostname and/or address) are met. So far a useful subset of post-
> authentication options are supported and more are expected to be
> added in future releases.
> - Added a "ForceCommand" directive to sshd_config(5). Similar to
the
> command="..." option accepted in ~/.ssh/authorized_keys, this
forces
> the execution of the specified command regardless of what the user
> requested. This is very useful in conjunction with the new
"Match"
> option.
> - Add a "PermitOpen" directive to sshd_config(5). This mirrors
the
> permitopen="..." authorized_keys option, allowing fine-grained
> control over the port-forwardings that a user is allowed to
> establish.
> - Add optional logging of transactions to sftp-server(8).
> - ssh(1) will now record port numbers for hosts stored in
> ~/.ssh/authorized_keys when a non-standard port has been requested.
> - Add an "ExitOnForwardFailure" options to cause ssh(1) to exit
(with
> a non-zero exit code) when requested port forwardings could not be
> established.
> - Extend the sshd_config(5) "SubSystem" directive to allow the
> specification of commandline arguments.
> - Add optional support for SELinux, controlled using the --with-selinux
> configure option (experimental)
> - Add optional support for Solaris process contracts, enabled using the
> --with-solaris-contracts configure option (experimental)
> - Add support for Diffie-Hellman group exchange key agreement with a
> final hash of SHA256.
> - Fixed a lot of bugs. See
> http://bugzilla.mindrot.org/show_bug.cgi?id=1155 for an incomplete
> list (more in the ChangeLog)
> - Lots of manpage fixes and improvements
> - Many code cleanups, including:
> - Switching to safer memory allocation functions that avoid integer
> overflows when allocating arrays
> - Cleanups of header file usage (ongoing)
> - Fixes to leaks reported by the Coverity static analysis tool
>
> Running the regression tests supplied with Portable does not require
> installation, just run:
>
> $ ./configure && make tests
>
> Testing on suitable non-production systems is also appreciated. Please
send> reports of success or failure to openssh-unix-dev at mindrot.org, including
> details of your platform, compiler and configure options.
>
> Thanks,
> Damien Miller
>
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev at mindrot.org
> http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
>
Sometime ago, Damien Miller wrote: [...]> Testing on suitable non-production systems is also appreciated. Please send > reports of success or failure to openssh-unix-dev at mindrot.org, including > details of your platform, compiler and configure options. >Configures, builds and tests OK on Solaris 9 with Sun Forte 7 C 5.4 compiler. However, there are a lot of warnings. A breakdown of the warnings follows: 162 "/usr/include/netinet/in.h", line 455: warning: macro redefined: IN6_IS_ADDR_V4MAPPED 162 "/usr/include/netinet/in.h", line 274: warning: macro redefined: INADDR_LOOPBACK 4 "/usr/include/iso/stddef_iso.h", line 73: warning: macro redefined: offsetof 1 "sftp-client.c", line 81: warning: assignment type mismatch: 1 "sftp-client.c", line 1066: warning: argument #3 is incompatible with prototype: 1 "serverloop.c", line 831: warning: argument #4 is incompatible with prototype: 1 "monitor.c", line 1306: warning: implicit function declaration: close 1 "loginrec.c", line 1609: warning: statement not reached 1 "hostfile.c", line 91: warning: argument #2 is incompatible with prototype: 1 "hostfile.c", line 134: warning: argument #1 is incompatible with prototype: 1 "hostfile.c", line 133: warning: argument #1 is incompatible with prototype: 1 "hostfile.c", line 130: warning: argument #2 is incompatible with prototype: 1 "hostfile.c", line 129: warning: argument #2 is incompatible with prototype: 1 "bsd-cray.c", line 818: warning: empty translation unit -- Iain Morgan
Hi, On Wed, Aug 30, 2006 at 11:41:53PM +1000, Damien Miller wrote:> The 4.4p1 release is approaching now, so we are now asking people to > actively test snapshots or CVS and report back to the mailing list.Tested CVS as of "Thu Aug 31 15:22:40 CEST 2006" on Host: sparc64-unknown-netbsd2.0.3. Compiler: gcc Compiler flags: -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare - configures and compiles just fine - "make tests" runs through without errors gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany gert at greenie.muc.de fax: +49-89-35655025 gert at net.informatik.tu-muenchen.de
OS X 10.4.7
Using: openssh-SNAP-20060901.tar.gz
Config: No options
Overview:
Host: powerpc-apple-darwin8.7.0
Compiler: gcc
Compiler flags: -g -O2 -Wall -Wpointer-arith -Wuninitialized
-Wsign-compare -Wno-pointer-sign
Preprocessor flags:
Linker flags:
Libraries: -lcrypto -lz
Warnings:
servconf.c: In function 'process_server_config_line':
servconf.c:624: warning: 'value' may be used uninitialized in this
function
servconf.c:626: warning: 'port' may be used uninitialized in this
function
readconf.c: In function 'process_config_line':
readconf.c:327: warning: 'scale' may be used uninitialized in this
function
readconf.c:327: warning: 'value' may be used uninitialized in this
function
kexdhc.c: In function 'kexdh_client':
kexdhc.c:48: warning: 'dh' may be used uninitialized in this function
sftp.c: In function 'sdirent_comp':
sftp.c:679: warning: control reaches end of non-void function
Tests: Passed all tests
On Thu, 31 Aug 2006, santhi wrote:> /usr/ccs/bin/ld: Unsatisfied symbols: > ntohl (first referenced in sshconnect.o) (code) > ntohs (first referenced in ssh.o) (code) > htonl (first referenced in sshconnect.o) (code) > htons (first referenced in > openbsd-compat//libopenbsd-compat.a(rresvport.o)) (code) > *** Error exit code 1 > > Stop. > > Problem Description: > ---------------------- > * The ntohl, ntohs, htonl, htons routines are defined as macros instead of > functions in <netinet/in.h> , linker raises "functions" not found error. > > Fix: > ----- > Including the <arpa/inet.h> in includes.h file may fix this problemThanks for the report - does the following diff help? Index: openbsd-compat/bindresvport.c ==================================================================RCS file: /var/cvs/openssh/openbsd-compat/bindresvport.c,v retrieving revision 1.7 diff -u -p -r1.7 bindresvport.c --- openbsd-compat/bindresvport.c 24 Jul 2006 04:51:01 -0000 1.7 +++ openbsd-compat/bindresvport.c 1 Sep 2006 05:41:51 -0000 @@ -33,8 +33,10 @@ #include "includes.h" #ifndef HAVE_BINDRESVPORT_SA +#include <sys/types.h> +#include <sys/socket.h> -#include "includes.h" +#include <netinet/in.h> #include <errno.h> #include <string.h> Index: openbsd-compat/rresvport.c ==================================================================RCS file: /var/cvs/openssh/openbsd-compat/rresvport.c,v retrieving revision 1.10 diff -u -p -r1.10 rresvport.c --- openbsd-compat/rresvport.c 24 Aug 2006 09:53:41 -0000 1.10 +++ openbsd-compat/rresvport.c 1 Sep 2006 05:40:41 -0000 @@ -35,6 +35,11 @@ #ifndef HAVE_RRESVPORT_AF +#include <sys/types.h> +#include <sys/socket.h> + +#include <netinet/in.h> + #include <errno.h> #include <stdlib.h> #include <string.h>
> On Thu, 31 Aug 2006, santhi wrote: > > > /usr/ccs/bin/ld: Unsatisfied symbols: > > ntohl (first referenced in sshconnect.o) (code) > > ntohs (first referenced in ssh.o) (code) > > htonl (first referenced in sshconnect.o) (code) > > htons (first referenced in > > openbsd-compat//libopenbsd-compat.a(rresvport.o)) (code) > > *** Error exit code 1 > > > > Stop. > > > > Problem Description: > > ---------------------- > > * The ntohl, ntohs, htonl, htons routines are defined as macros insteadof> > functions in <netinet/in.h> , linker raises "functions" not found error. > > > > Fix: > > ----- > > Including the <arpa/inet.h> in includes.h file may fix this problem > > Thanks for the report - does the following diff help? > > Index: openbsd-compat/bindresvport.c > ==================================================================> RCS file: /var/cvs/openssh/openbsd-compat/bindresvport.c,v > retrieving revision 1.7 > diff -u -p -r1.7 bindresvport.c > --- openbsd-compat/bindresvport.c 24 Jul 2006 04:51:01 -0000 1.7 > +++ openbsd-compat/bindresvport.c 1 Sep 2006 05:41:51 -0000 > @@ -33,8 +33,10 @@ > #include "includes.h" > > #ifndef HAVE_BINDRESVPORT_SA > +#include <sys/types.h> > +#include <sys/socket.h> > > -#include "includes.h" > +#include <netinet/in.h> > > #include <errno.h> > #include <string.h> > Index: openbsd-compat/rresvport.c > ==================================================================> RCS file: /var/cvs/openssh/openbsd-compat/rresvport.c,v > retrieving revision 1.10 > diff -u -p -r1.10 rresvport.c > --- openbsd-compat/rresvport.c 24 Aug 2006 09:53:41 -0000 1.10 > +++ openbsd-compat/rresvport.c 1 Sep 2006 05:40:41 -0000 > @@ -35,6 +35,11 @@ > > #ifndef HAVE_RRESVPORT_AF > > +#include <sys/types.h> > +#include <sys/socket.h> > + > +#include <netinet/in.h> > + > #include <errno.h> > #include <stdlib.h> > #include <string.h>Affected files are 01) channels.c 02) ssh.c 03) openbsd-compat/bindresvport.c 04) openbsd-compat/fake-rfc2553.c 05) openbsd-compat/getrrsetbyname.c 06) openbsd-compat/rresvport.c 07) sshconnect.c 08) openbsd-compat/port-tun.c 09) ssh-rand-helper.c 10) ssh-keyscan.c 11) openbsd-compat/bsd-cray.c 12) openbsd-compat/inet_aton.c Among the above files, the patch is applied to "bindresvport.c" and "rresvport.c". But we get the same linker error, while we compile other files. Any suggestions? Note: We found that <arpa/inet.h> file is missing in includes.h file. Thanks, Santhi.
Damien Miller wrote:> > The 4.4p1 release is approaching now, so we are now asking people to > actively test snapshots or CVS and report back to the mailing list.[AIX 5.2 ML4, IBM VAC 6 compiler, openssh-SNAP-20060902] Builds (with some warnings) and tests OK (some exceptions). See below for details. $ ./configure --libexecdir='${exec_prefix}/bin' --sysconfdir=/etc/ssh --with-pid-dir=/etc/ssh --with-privsep-path=/var/empty/sshd --with-tcp-wrappers=/local/admin --with-zlib=/usr/local --with-xauth=/usr/bin/X11/xauth --with-cflags="-O3 -qstrict" OpenSSH has been configured with the following options: User binaries: /usr/local/bin System binaries: /usr/local/sbin Configuration files: /etc/ssh Askpass program: /usr/local/bin/ssh-askpass Manual pages: /usr/local/share/man/manX PID file: /etc/ssh Privilege separation chroot path: /var/empty/sshd sshd default user PATH: /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin Manpage format: man PAM support: no OSF SIA support: no KerberosV support: no SELinux support: no Smartcard support: no S/KEY support: no TCP Wrappers support: yes MD5 password support: no libedit support: no Solaris process contract support: no IP address in $DISPLAY hack: no Translate v4 in v6 hack: no BSD Auth support: no Random number source: OpenSSL internal ONLY Host: powerpc-ibm-aix5.2.0.0 Compiler: cc -qlanglvl=extc89 Compiler flags: -g -O3 -qstrict Preprocessor flags: -I/local/admin/include -I/usr/local/include Linker flags: -L/local/admin/lib -L/usr/local/lib -blibpath:/usr/lib:/lib Libraries: -lwrap -lcrypto -lz At compile time, most (all) files produce the following warnings: "/usr/include/syms.h", line 288.9: 1506-236 (W) Macro name T_NULL has been redefined. "/usr/include/syms.h", line 288.9: 1506-358 (I) "T_NULL" is defined on line 150 of /usr/include/arpa/onameser_compat.h. And some files also produce: "/usr/include/paths.h", line 50.9: 1506-236 (W) Macro name _PATH_BSHELL has been redefined. "/usr/include/paths.h", line 50.9: 1506-358 (I) "_PATH_BSHELL" is defined on line 322 of defines.h. "/usr/include/paths.h", line 52.9: 1506-236 (W) Macro name _PATH_CSHELL has been redefined. "/usr/include/paths.h", line 52.9: 1506-358 (I) "_PATH_CSHELL" is defined on line 325 of defines.h. "/usr/include/paths.h", line 57.9: 1506-236 (W) Macro name _PATH_MAILDIR has been redefined. "/usr/include/paths.h", line 57.9: 1506-358 (I) "_PATH_MAILDIR" is defined on line 359 of defines.h. All tests OK except for: agent-getpeereid.sh [skipped: need SUDO to switch to uid nobody] agent-ptrace.sh [skipped (not supported on this platform)] dynamic-forward.sh [skipped (no suitable ProxyCommand found)] I can provide full compile log, but didn't want to mail it to the list. -- Hello World. David Bronder - Systems Admin Segmentation Fault ITS-SPA, Univ. of Iowa Core dumped, disk trashed, quota filled, soda warm. david-bronder at uiowa.edu
Damien Miller wrote:> > The 4.4p1 release is approaching now, so we are now asking people to > actively test snapshots or CVS and report back to the mailing list.[AIX 5.1 ML5, IBM VAC 6 compiler, openssh-SNAP-20060902] Fails to build. See below for details. Same result with a stripped down configure line (just adding --with-zlib=/usr/local). ----- $ ./configure --libexecdir='${exec_prefix}/bin' --sysconfdir=/etc/ssh --with-pid-dir=/etc/ssh --with-privsep-path=/var/empty/sshd --with-tcp-wrappers=/local/admin --with-zlib=/usr/local --with-xauth=/usr/bin/X11/xauth --with-cflags="-O3 -qstrict" OpenSSH has been configured with the following options: User binaries: /usr/local/bin System binaries: /usr/local/sbin Configuration files: /etc/ssh Askpass program: /usr/local/bin/ssh-askpass Manual pages: /usr/local/share/man/manX PID file: /etc/ssh Privilege separation chroot path: /var/empty/sshd sshd default user PATH: /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin Manpage format: man PAM support: no OSF SIA support: no KerberosV support: no SELinux support: no Smartcard support: no S/KEY support: no TCP Wrappers support: yes MD5 password support: no libedit support: no Solaris process contract support: no IP address in $DISPLAY hack: no Translate v4 in v6 hack: no BSD Auth support: no Random number source: OpenSSL internal ONLY Host: powerpc-ibm-aix5.1.0.0 Compiler: cc -qlanglvl=ansi Compiler flags: -g -O3 -qstrict Preprocessor flags: -I/local/admin/include -I/usr/local/include Linker flags: -L/local/admin/lib -L/usr/local/lib -blibpath:/usr/lib:/lib Libraries: -lwrap -lcrypto -lz WARNING: the operating system that you are using does not appear to support either the getpeereid() API nor the SO_PEERCRED getsockopt() option. These facilities are used to enforce security checks to prevent unauthorised connections to ssh-agent. Their absence increases the risk that a malicious user can connect to your agent. ----- I can provide full compile log, but didn't want to mail it to the list. Here are some highlights. Lots of the following warnings: "/usr/include/usersec.h", line 625.32: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. "/usr/include/usersec.h", line 626.34: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. Then for the last two files before failing: cc -qlanglvl=ansi -g -O3 -qstrict -I. -I. -I/local/admin/include -I/usr/local/include -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/bin/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/bin/ssh-keysign\" -D_PATH_SSH_PIDDIR=\"/etc/ssh\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty/sshd\" -DSSH_RAND_HELPER=\"/usr/local/bin/ssh-rand-helper\" -DHAVE_CONFIG_H -c packet.c "/usr/include/usersec.h", line 625.32: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. "/usr/include/usersec.h", line 626.34: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. "packet.c", line 162.12: 1506-010 (E) Macro TAILQ_HEAD invoked with a null argument for parameter name. cc -qlanglvl=ansi -g -O3 -qstrict -I. -I. -I/local/admin/include -I/usr/local/include -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/bin/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/bin/ssh-keysign\" -D_PATH_SSH_PIDDIR=\"/etc/ssh\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty/sshd\" -DSSH_RAND_HELPER=\"/usr/local/bin/ssh-rand-helper\" -DHAVE_CONFIG_H -c readpass.c "/usr/include/usersec.h", line 625.32: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. "/usr/include/usersec.h", line 626.34: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. "/usr/include/paths.h", line 50.9: 1506-213 (S) Macro name _PATH_BSHELL cannot be redefined. "/usr/include/paths.h", line 50.9: 1506-358 (I) "_PATH_BSHELL" is defined on line 322 of defines.h. "/usr/include/paths.h", line 52.9: 1506-213 (S) Macro name _PATH_CSHELL cannot be redefined. "/usr/include/paths.h", line 52.9: 1506-358 (I) "_PATH_CSHELL" is defined on line 325 of defines.h. "/usr/include/paths.h", line 57.9: 1506-213 (S) Macro name _PATH_MAILDIR cannot be redefined. "/usr/include/paths.h", line 57.9: 1506-358 (I) "_PATH_MAILDIR" is defined on line 359 of defines.h. make: The error code from the last command is 1. Stop. -- Hello World. David Bronder - Systems Admin Segmentation Fault ITS-SPA, Univ. of Iowa Core dumped, disk trashed, quota filled, soda warm. david-bronder at uiowa.edu
On Fri, Sep 01, 2006 at 08:14:51PM -0500, David Bronder wrote:> Damien Miller wrote: > > > > The 4.4p1 release is approaching now, so we are now asking people to > > actively test snapshots or CVS and report back to the mailing list. > > [AIX 5.1 ML5, IBM VAC 6 compiler, openssh-SNAP-20060902]Thanks for testing.> Fails to build. See below for details. Same result with a stripped > down configure line (just adding --with-zlib=/usr/local).[...]> Compiler: cc -qlanglvl=ansiI noticed that in your other report in which it worked, you had "cc -qlanglvl=extc89" instead. Does this make a difference to the TAILQ_HEAD error below? (It appears that this line of the code has not changed for years.)> "/usr/include/usersec.h", line 625.32: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition.The patch below should fix those. [...]> "packet.c", line 162.12: 1506-010 (E) Macro TAILQ_HEAD invoked with a null argument for parameter name.Please see my query above about compiler flags.> "/usr/include/paths.h", line 50.9: 1506-213 (S) Macro name _PATH_BSHELL cannot be redefined. > "/usr/include/paths.h", line 50.9: 1506-358 (I) "_PATH_BSHELL" is defined on line 322 of defines.h.Hmm, the "cannot be redefined" sounds like we need to fix those before the release. Index: openbsd-compat/port-aix.h ==================================================================RCS file: /usr/local/src/security/openssh/cvs/openssh_cvs/openbsd-compat/port-aix.h,v retrieving revision 1.26 diff -u -p -r1.26 port-aix.h --- openbsd-compat/port-aix.h 28 May 2005 10:28:40 -0000 1.26 +++ openbsd-compat/port-aix.h 2 Sep 2006 03:13:36 -0000 @@ -38,7 +38,7 @@ #ifdef WITH_AIXAUTHENTICATE # include <login.h> # include <userpw.h> -# if defined(HAVE_SYS_AUDIT_H) && defined(AIX_LOGINFAILED_4ARG) +# if defined(HAVE_SYS_AUDIT_H) # include <sys/audit.h> # endif # include <usersec.h> -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.
On Wed, Aug 30, 2006 at 11:41:53PM +1000, Damien Miller wrote:> The 4.4p1 release is approaching now, so we are now asking people to > actively test snapshots or CVS and report back to the mailing list.It seems that *really* old systems that don't declare writev will not build because the function can't be passed as an argument to atomiciov. The patch below fixes this, and while I don't think it would affect any other platforms I'm not sure it's worth putting in at this point. Index: configure.ac ==================================================================RCS file: /usr/local/src/security/openssh/cvs/openssh_cvs/configure.ac,v retrieving revision 1.357 diff -u -p -r1.357 configure.ac --- configure.ac 1 Sep 2006 10:29:11 -0000 1.357 +++ configure.ac 3 Sep 2006 08:41:34 -0000 @@ -1328,6 +1328,11 @@ AC_CHECK_DECLS(O_NONBLOCK, , , #endif ]) +AC_CHECK_DECLS(writev, , , [ +#include <sys/types.h> +#include <sys/uio.h> + ]) + AC_CHECK_FUNCS(setresuid, [ dnl Some platorms have setresuid that isn't implemented, test for this AC_MSG_CHECKING(if setresuid seems to work) Index: openbsd-compat/openbsd-compat.h ==================================================================RCS file: /usr/local/src/security/openssh/cvs/openssh_cvs/openbsd-compat/openbsd-compat.h,v retrieving revision 1.41 diff -u -p -r1.41 openbsd-compat.h --- openbsd-compat/openbsd-compat.h 30 Aug 2006 17:24:42 -0000 1.41 +++ openbsd-compat/openbsd-compat.h 2 Sep 2006 13:18:16 -0000 @@ -131,6 +131,11 @@ int getgrouplist(const char *, gid_t, gi int BSDgetopt(int argc, char * const *argv, const char *opts); #endif +#if defined(HAVE_DECL_WRITEV) && HAVE_DECL_WRITEV == 0 +# include <sys/types.h> +# include <sys/uio.h> +int writev(int, struct iovec *, int); +#endif /* Home grown routines */ #include "bsd-misc.h" -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement.
Damien Miller wrote:> Hi, > > The 4.4p1 release is approaching now, so we are now asking people to > actively test snapshots or CVS and report back to the mailing list. >scp manual page: make -f Makefile.in distprep scp.1 -> scp.0 mdoc error: .Ex defunct, use .D1 (#202) ... Roumen
Hi, I followed Darren & Kirill advices, and upgraded netcat to RELENG_5. Now "make tests" run fine on FreeBSD 5.4. Thanks ! Flavien.> > "make tests" fails in dynamic-forward.sh on FreeBSD here. I just > retried 4.3p2, "make tests" runs ok with this version, including > dynamic-forward.sh > > Hope this helps, > > > Flavien. > --- > System : FreeBSD 5.4-STABLE i386 > Version tested : openssh-SNAP-20060830.tar.gz > GCC version : gcc (GCC) 3.4.2 [FreeBSD] 20040728 > > $ ./configure --without-zlib-version-check && make tests > [...] > OpenSSH has been configured with the following options: > User binaries: /usr/local/bin > System binaries: /usr/local/sbin > Configuration files: /usr/local/etc > Askpass program: /usr/local/libexec/ssh-askpass > Manual pages: /usr/local/share/man/manX > PID file: /var/run > Privilege separation chroot path: /var/empty > At runtime, sshd will use the path defined in /etc/login.conf > Make sure the path to scp is present, otherwise scp will not work > Manpage format: doc > PAM support: no > KerberosV support: no > SELinux support: no > Smartcard support: no > S/KEY support: no > TCP Wrappers support: no > MD5 password support: no > libedit support: no > IP address in $DISPLAY hack: no > Translate v4 in v6 hack: no > BSD Auth support: no > Random number source: OpenSSL internal ONLY > > Host: i386-unknown-freebsd5.4 > Compiler: gcc > Compiler flags: -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare > Preprocessor flags: > Linker flags: > Libraries: -lcrypto -lutil -lz -lcrypt > > [...] > run test sftp-glob.sh ... > sftp glob: ls file > sftp glob: ls dir > ok sftp glob > run test reconfigure.sh ... > ok simple connect after reconfigure > run test dynamic-forward.sh ... > nc: unexpected reply size 31 (expected 10) > ssh_exchange_identification: Connection closed by remote host > cmp: EOF on /usr/home/flavien/src/openssh/regress/ls.copy > corrupted copy of /bin/ls > nc: unexpected reply size 31 (expected 10) > ssh_exchange_identification: Connection closed by remote host > cmp: EOF on /usr/home/flavien/src/openssh/regress/ls.copy > corrupted copy of /bin/ls > failed dynamic forwarding > *** Error code 1 > > Stop in /usr/home/flavien/src/openssh/regress. > *** Error code 1
On Sun, Sep 03, 2006 at 10:17:54PM +0300, Roumen Petrov wrote:> Damien Miller wrote: > >Hi, > > > >The 4.4p1 release is approaching now, so we are now asking people to > >actively test snapshots or CVS and report back to the mailing list. > > > > scp manual page: > > make -f Makefile.in distprep > scp.1 -> scp.0 > mdoc error: .Ex defunct, use .D1 (#202) > ... >what exactly are you using that does not recognise ".Ex"? jmc
Jason McIntyre wrote:> On Sun, Sep 03, 2006 at 10:17:54PM +0300, Roumen Petrov wrote: > >>Damien Miller wrote: >> >>>Hi, >>> >>>The 4.4p1 release is approaching now, so we are now asking people to >>>actively test snapshots or CVS and report back to the mailing list. >>> >> >>scp manual page: >> >>make -f Makefile.in distprep >>scp.1 -> scp.0 >>mdoc error: .Ex defunct, use .D1 (#202) >>... >> > > > what exactly are you using that does not recognise ".Ex"? > jmc >This should be from GNU troff - defined in "doc-old.tmac": ........ .de Ex .tm Ex defunct, Use .Dl: \\$1 \\$2 \\$3 \\$4 \\$5 \\$6 \\$7 \\$8 \\$9 ........ web access to groff cvs: http://savannah.gnu.org/cvs/?group=groff It seems that .Ex in groff is different from OpenBSD. Roumen
Once upon a time, Damien Miller <djm at mindrot.org> said:> The 4.4p1 release is approaching now, so we are now asking people to > actively test snapshots or CVS and report back to the mailing list.I tested SNAP-20060906 on Tru64. The attached patch is required for compilation. Also, the check in regress/multiplex.sh for DISABLE_FD_PASSING is incorrect. DISABLE_FD_PASSING is defined on Tru64 with SIA enabled (to skip post-auth privsep), but multiplexing works fine (commenting out that test in multiplex.sh allows it run okay). FD passing works fine as well on Tru64. -- Chris Adams <cmadams at hiwaay.net> Systems and Network Administrator - HiWAAY Internet Services I don't speak for anybody but myself - that's enough trouble. -------------- next part -------------- diff -urN openssh-SNAP-20060906/auth-sia.c openssh/auth-sia.c --- openssh-SNAP-20060906/auth-sia.c Thu Sep 7 15:27:59 2006 +++ openssh/auth-sia.c Thu Sep 7 15:28:19 2006 @@ -36,6 +36,8 @@ #include <string.h> #include "ssh.h" +#include "key.h" +#include "hostfile.h" #include "auth.h" #include "auth-sia.h" #include "log.h"
On Thu, Aug 31, 2006 at 08:50:04AM +0300, Pekka Savola wrote:> On Wed, 30 Aug 2006, Damien Miller wrote: > > Running the regression tests supplied with Portable does not require > > installation, just run: > > > > $ ./configure && make tests > > > > Testing on suitable non-production systems is also appreciated. Please send > > reports of success or failure to openssh-unix-dev at mindrot.org, including > > details of your platform, compiler and configure options.Thanks for testing and sorry it took so long to get back to you.> On RHL73 with gcc 2.96, 'make tests' doesn't finish and appears to get > stuck (strace shows the process is in wait()). There were a number of > compilation warnings. The ones coming from ciphers and macs appear to > be old, but these are new and at least implicit decls should be easily > fixable: > > warning: __nonnull__' attribute directive ignored (50+ times)We could do something like the patch below.> uidswap.c: In function Permanently_drop_suid': > uidswap.c:142: warning: implicit declaration of function Setresuid' > uidswap.c: In function Permanently_set_uid': > uidswap.c:224: warning: implicit declaration of function Setresgid'Last time I looked, setresuid and setresgid were not defined in any system header on old Linuxes.> md5crypt.c: In function To64': > md5crypt.c:31: warning: implicit declaration of function Memset' > md5crypt.c: In function s_md5_salt': > md5crypt.c:43: warning: implicit declaration of function Strncmp' > md5crypt.c:43: warning: implicit declaration of function Strlen' > md5crypt.c: In function Md5_crypt': > md5crypt.c:73: warning: implicit declaration of function Memcpy'These have been fixed by including string.h. [...]> from 127.0.0.1 port 44319 (t4 r26 i0/0 o0/0 fd 27/27 cfd -1) > [[ almost 10 minute timeout ]] > ssh_exchange_identification: Connection closed by remote host > cmp: EOF on /home/pekkas/op/openssh/regress/ls.copy > corrupted copy of /bin/ls > bind: Address already in use > [[ about 5 minute timeout ]]Now this I'm not sure about. Index: defines.h ==================================================================RCS file: /usr/local/src/security/openssh/cvs/openssh/defines.h,v retrieving revision 1.137 diff -u -p -r1.137 defines.h --- defines.h 18 Aug 2006 22:38:24 -0000 1.137 +++ defines.h 10 Sep 2006 05:04:31 -0000 @@ -449,6 +449,10 @@ struct winsize { # define __bounded__(x, y, z) #endif +#ifndef __nonnull__ +# define __nonnull__ +#endif + /* *-*-nto-qnx doesn't define this macro in the system headers */ #ifdef MISSING_HOWMANY # define howmany(x,y) (((x)+((y)-1))/(y)) -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement. _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev at mindrot.org http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
On Sun, 10 Sep 2006, Darren Tucker wrote:>> On RHL73 with gcc 2.96, 'make tests' doesn't finish and appears to get >> stuck (strace shows the process is in wait()). There were a number of >> compilation warnings. The ones coming from ciphers and macs appear to >> be old, but these are new and at least implicit decls should be easily >> fixable: >> >> warning: __nonnull__' attribute directive ignored (50+ times) > > We could do something like the patch below.I retried with the latest snapshot and the patch. The patch doesn't work, it results in a a compilation error: In file included from bsd-misc.c:31: ../xmalloc.h:26: parse error before ('>> uidswap.c: In function Permanently_drop_suid': >> uidswap.c:142: warning: implicit declaration of function Setresuid' >> uidswap.c: In function Permanently_set_uid': >> uidswap.c:224: warning: implicit declaration of function Setresgid' > > Last time I looked, setresuid and setresgid were not defined in any system > header on old Linuxes.True, I don't see them myself either..> These have been fixed by including string.h.cipher-aes.c also seems to need it, or some other relevant .h include, as it complains about memcpy and memset.> [...] >> from 127.0.0.1 port 44319 (t4 r26 i0/0 o0/0 fd 27/27 cfd -1) >> [[ almost 10 minute timeout ]] >> ssh_exchange_identification: Connection closed by remote host >> cmp: EOF on /home/pekkas/op/openssh/regress/ls.copy >> corrupted copy of /bin/ls >> bind: Address already in use >> [[ about 5 minute timeout ]] > > Now this I'm not sure about.This is still the same. -- Pekka Savola "You each name yourselves king, yet the Netcore Oy kingdom bleeds." Systems. Networks. Security. -- George R.R. Martin: A Clash of Kings _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev at mindrot.org http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
On Mon, Sep 11, 2006 at 09:16:24AM +0300, Pekka Savola wrote:> On Sun, 10 Sep 2006, Darren Tucker wrote: > >> On RHL73 with gcc 2.96, 'make tests' doesn't finish and appears to get > >> stuck (strace shows the process is in wait()). There were a number of > >> compilation warnings. The ones coming from ciphers and macs appear to > >> be old, but these are new and at least implicit decls should be easily > >> fixable: > >> > >> warning: __nonnull__' attribute directive ignored (50+ times) > > > > We could do something like the patch below. > > I retried with the latest snapshot and the patch.Thanks.> The patch doesn't work, it results in a a compilation error: > In file included from bsd-misc.c:31: > ../xmalloc.h:26: parse error before ('Yeah, that patch is a bad idea, so I think we'll probably leave this alone for now. I can't think of a way to reliably detect which __attribute__ 's are supported. [...]> > These have been fixed by including string.h. > > cipher-aes.c also seems to need it, or some other relevant .h include, > as it complains about memcpy and memset.Indeed it does, however it's only obvious with older OpenSSL version where that code is compiled in. Fixed, thanks.> > [...] > >> from 127.0.0.1 port 44319 (t4 r26 i0/0 o0/0 fd 27/27 cfd -1) > >> [[ almost 10 minute timeout ]] > >> ssh_exchange_identification: Connection closed by remote host > >> cmp: EOF on /home/pekkas/op/openssh/regress/ls.copy > >> corrupted copy of /bin/ls > >> bind: Address already in use > >> [[ about 5 minute timeout ]] > > > > Now this I'm not sure about. > > This is still the same.During the timeout phase, is there a defunct process in the process list, and if so what process does its ppid correspond to? -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement. _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev at mindrot.org http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
On Mon, 11 Sep 2006, Darren Tucker wrote:>>> [...] >>>> from 127.0.0.1 port 44319 (t4 r26 i0/0 o0/0 fd 27/27 cfd -1) >>>> [[ almost 10 minute timeout ]] >>>> ssh_exchange_identification: Connection closed by remote host >>>> cmp: EOF on /home/pekkas/op/openssh/regress/ls.copy >>>> corrupted copy of /bin/ls >>>> bind: Address already in use >>>> [[ about 5 minute timeout ]] >>> >>> Now this I'm not sure about. >> >> This is still the same. > > During the timeout phase, is there a defunct process in the process list, > and if so what process does its ppid correspond to?During the timeout, the processes look something like this: pekkas 11767 8459 0 14:10 pts/4 00:00:00 sh /home/pekkas/o/openssh/regres pekkas 11798 1 0 14:10 ? 00:00:00 /home/pekkas/o/openssh/sshd -f / pekkas 11826 1 0 14:10 ? 00:00:00 /home/pekkas/o/openssh/ssh -1 -F pekkas 11827 11767 0 14:10 pts/4 00:00:00 /home/pekkas/o/openssh/ssh -2 -F PPID=1 looks odd, and indeed if I kill them the timeout stops, but the compilation result is the same error. -- Pekka Savola "You each name yourselves king, yet the Netcore Oy kingdom bleeds." Systems. Networks. Security. -- George R.R. Martin: A Clash of Kings _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev at mindrot.org http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Hi again. David Bronder wrote:> Damien Miller wrote: >> The 4.4p1 release is approaching now, so we are now asking people to >> actively test snapshots or CVS and report back to the mailing list. > > [AIX 5.1 ML5, IBM VAC 6 compiler, openssh-SNAP-20060902] > > Fails to build. See below for details. Same result with a stripped > down configure line (just adding --with-zlib=/usr/local).[...]> I can provide full compile log, but didn't want to mail it to the list. > Here are some highlights. > > Lots of the following warnings: > > "/usr/include/usersec.h", line 625.32: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. > "/usr/include/usersec.h", line 626.34: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. > > Then for the last two files before failing: > > cc -qlanglvl=ansi -g -O3 -qstrict -I. -I. -I/local/admin/include -I/usr/local/include -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/bin/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/bin/ssh-keysign\" -D_PATH_SSH_PIDDIR=\"/etc/ssh\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty/sshd\" -DSSH_RAND_HELPER=\"/usr/local/bin/ssh-rand-helper\" -DHAVE_CONFIG_H -c packet.c > "/usr/include/usersec.h", line 625.32: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. > "/usr/include/usersec.h", line 626.34: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. > "packet.c", line 162.12: 1506-010 (E) Macro TAILQ_HEAD invoked with a null argument for parameter name. > cc -qlanglvl=ansi -g -O3 -qstrict -I. -I. -I/local/admin/include -I/usr/local/include -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/bin/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/bin/ssh-keysign\" -D_PATH_SSH_PIDDIR=\"/etc/ssh\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty/sshd\" -DSSH_RAND_HELPER=\"/usr/local/bin/ssh-rand-helper\" -DHAVE_CONFIG_H -c readpass.c > "/usr/include/usersec.h", line 625.32: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition. > "/usr/include/usersec.h", line 626.34: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition.I have just committed a change to configure that should work around that by removing the "-qlanglvl=ansi" if it finds the compiler won't let macros be redefined. (Not ideal, but it should work.) The changes will be in snap 20060919 and later. I think the "struct aud_rec" ones were a side effect of the compiler flags, but if you see them again (they'll only appear in port-aix.c now) then please let me know.> "/usr/include/paths.h", line 50.9: 1506-213 (S) Macro name _PATH_BSHELL cannot be redefined. > "/usr/include/paths.h", line 50.9: 1506-358 (I) "_PATH_BSHELL" is defined on line 322 of defines.h. > "/usr/include/paths.h", line 52.9: 1506-213 (S) Macro name _PATH_CSHELL cannot be redefined. > "/usr/include/paths.h", line 52.9: 1506-358 (I) "_PATH_CSHELL" is defined on line 325 of defines.h. > "/usr/include/paths.h", line 57.9: 1506-213 (S) Macro name _PATH_MAILDIR cannot be redefined. > "/usr/include/paths.h", line 57.9: 1506-358 (I) "_PATH_MAILDIR" is defined on line 359 of defines.h.Those will probably still be there but as warnings. We'll see what we can do to clean those up after the release. Thanks. -- Darren Tucker (dtucker at zip.com.au) GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69 Good judgement comes with experience. Unfortunately, the experience usually comes from bad judgement. _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev at mindrot.org http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Darren Tucker wrote:> > David Bronder wrote: > > Damien Miller wrote: > >> The 4.4p1 release is approaching now, so we are now asking people to > >> actively test snapshots or CVS and report back to the mailing list. > > > > [AIX 5.1 ML5, IBM VAC 6 compiler, openssh-SNAP-20060902] > > > > Fails to build. See below for details. Same result with a stripped > > down configure line (just adding --with-zlib=/usr/local). > [...] > > I have just committed a change to configure that should work around that > by removing the "-qlanglvl=ansi" if it finds the compiler won't let > macros be redefined. (Not ideal, but it should work.) > > The changes will be in snap 20060919 and later. I think the "struct > aud_rec" ones were a side effect of the compiler flags, but if you see > them again (they'll only appear in port-aix.c now) then please let me know.Just gave it another spin with openssh-SNAP-20060919 and it looks OK. The "struct aud_rec" messages are gone, and the regression tests passed.> > "/usr/include/paths.h", line 50.9: 1506-213 (S) Macro name _PATH_BSHELL cannot be redefined. > > "/usr/include/paths.h", line 50.9: 1506-358 (I) "_PATH_BSHELL" is defined on line 322 of defines.h. > > "/usr/include/paths.h", line 52.9: 1506-213 (S) Macro name _PATH_CSHELL cannot be redefined. > > "/usr/include/paths.h", line 52.9: 1506-358 (I) "_PATH_CSHELL" is defined on line 325 of defines.h. > > "/usr/include/paths.h", line 57.9: 1506-213 (S) Macro name _PATH_MAILDIR cannot be redefined. > > "/usr/include/paths.h", line 57.9: 1506-358 (I) "_PATH_MAILDIR" is defined on line 359 of defines.h. > > Those will probably still be there but as warnings. We'll see what we > can do to clean those up after the release.The macro warnings were still there, but as you said, just indicating the macros had been redefined (rather than not being able to redefine them). Thanks again! -- Hello World. David Bronder - Systems Admin Segmentation Fault ITS-SPA, Univ. of Iowa Core dumped, disk trashed, quota filled, soda warm. david-bronder at uiowa.edu _______________________________________________ openssh-unix-dev mailing list openssh-unix-dev at mindrot.org http://lists.mindrot.org/mailman/listinfo/openssh-unix-dev