openssh unix dev - May 2001 - ssh-keygen segfault (2.9p1)

On Fri, May 25, 2001 at 02:21:06PM +0200, Nigel Kukard
wrote:
> Hi,
> 
> 	[nkukard at wigglytuff .ssh]$ ssh-keygen -pf test_id 
> 	Enter old passphrase:
> 	'ey has comment 'ii
> 	Enter new passphrase (empty for no passphrase): 
> 	Enter same passphrase again: 
> 	Segmentation fault (core dumped)
> 	[nkukard at wigglytuff .ssh]$
> 
> 
> That is the error i get when trying to change the passphrase on one of my
> keys, i'm just wonder if its summin i did wrong, a bug or anything
> else. Most important is there a way i can fix it?
please try this patch

Index: authfile.c
==================================================================RCS file:
/home/markus/cvs/ssh/authfile.c,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- authfile.c	2001/04/18 23:44:51	1.32
+++ authfile.c	2001/05/16 20:51:57	1.33
@@ -555,7 +555,8 @@
 	lseek(fd, (off_t) 0, SEEK_SET);		/* rewind */
 	if (pub == NULL) {
 		/* closes fd */
-		return key_load_private_pem(fd, KEY_UNSPEC, passphrase, NULL);
+		return key_load_private_pem(fd, KEY_UNSPEC, passphrase,
+		    commentp);
 	} else {
 		/* it's a SSH v1 key if the public key part is readable */
 		key_free(pub);

On Fri, 25 May 2001, Markus Friedl wrote:
> On Fri, May 25, 2001 at 02:21:06PM +0200, Nigel Kukard wrote:
> > Hi,
> > 
> > 	[nkukard at wigglytuff .ssh]$ ssh-keygen -pf test_id 
> > 	Enter old passphrase:
> > 	'ey has comment 'ii
> > 	Enter new passphrase (empty for no passphrase): 
> > 	Enter same passphrase again: 
> > 	Segmentation fault (core dumped)
> > 	[nkukard at wigglytuff .ssh]$
> > 
> > 
> > That is the error i get when trying to change the passphrase on one of
my
> > keys, i'm just wonder if its summin i did wrong, a bug or anything
> > else. Most important is there a way i can fix it?
> 
> please try this patch

Works perfectly!!!!!, i really appreciate it!!!
> 
> Index: authfile.c
> ==================================================================> RCS
file: /home/markus/cvs/ssh/authfile.c,v
> retrieving revision 1.32
> retrieving revision 1.33
> diff -u -r1.32 -r1.33
> --- authfile.c	2001/04/18 23:44:51	1.32
> +++ authfile.c	2001/05/16 20:51:57	1.33
> @@ -555,7 +555,8 @@
>  	lseek(fd, (off_t) 0, SEEK_SET);		/* rewind */
>  	if (pub == NULL) {
>  		/* closes fd */
> -		return key_load_private_pem(fd, KEY_UNSPEC, passphrase, NULL);
> +		return key_load_private_pem(fd, KEY_UNSPEC, passphrase,
> +		    commentp);
>  	} else {
>  		/* it's a SSH v1 key if the public key part is readable */
>  		key_free(pub);
>