openssh bugs - Feb 2008 - [Bug 1443] New: Missing terminating CR in identification string (RFC non-compliance)

https://bugzilla.mindrot.org/show_bug.cgi?id=1443

           Summary: Missing terminating CR in identification string (RFC   
                    non-compliance)                                        
    Classification: Unclassified                                           
           Product: Portable OpenSSH                                       
           Version: 4.7p1                                                  
          Platform: All                                                    
        OS/Version: Linux                                                  
            Status: NEW                                                    
          Severity: minor                                                  
          Priority: P2                                                     
         Component: ssh                                                    
        AssignedTo: bitbucket at mindrot.org                                  
        ReportedBy: alexreg at gmail.com                                      


Client should terminate ID string sent during protocol version exchange
with CR LF (carriage return, line feed) rather than only LF, as is done
in the current version. RFC 2453
(http://tools.ietf.org/html/rfc4253#section-4.2) suggests that CR LF
should be used to terminate the sent line while either CR LF or just LF
may be expected in a received ID string (for compatibility with older
protocol versions).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1443


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |1452




-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1443





--- Comment #1 from Darren Tucker <dtucker at zip.com.au>  2008-06-15
04:19:07 ---
Created an attachment (id=1523)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1523)
Send and receive proto banners with CR LF for proto 2

This patch changes the banner to use CR LF when running as a pure
protocol 2 server (which is the default for new installs these days)
and in the client when it's talking to a server with protocol 2
(regardless of whether or not the server advertises 1.99 or 2.0).

It doesn't change the behaviour when acting as a protocol 1.5 or 1.99
server, or as a 1.5 client.

This will need serious interop testing, though.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1443


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1523|                            |ok+
               Flag|                            |




-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1443


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Darren Tucker <dtucker at zip.com.au>  2008-07-01
17:25:29 ---
Thanks for the report.  The patch has been applied and this change will
be in the 5.1 release.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1443


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




--- Comment #3 from Damien Miller <djm at mindrot.org>  2008-07-22
12:21:14 ---
Mass update RESOLVED->CLOSED after release of openssh-5.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.