openssh bugs - Dec 2007 - [Bug 1395] New: "session_input_channel_req: no session" should be a debug message

https://bugzilla.mindrot.org/show_bug.cgi?id=1395

           Summary: "session_input_channel_req: no session" should be
a
                    debug message
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 4.7p1
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: patch
          Severity: minor
          Priority: P2
         Component: sshd
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: bjh21 at bjh21.me.uk


Created an attachment (id=1385)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1385)
Possible patch to turn this into a debug message (compile-tested only)

When sshd receives a channel request on a non-session channel, it
writes a log message about it.  This is in contrast to channel requests
on non-session channels, which only merit a debug message.  This is a
bit of a nuisance because development versions of PuTTY use an
undefined channel request ("winadj at putty.projects.tartarus.org") to
work out the right window size to use on a channel, causing a slew of:

Dec  3 18:03:07 viking sshd[6386]: session_input_channel_req: no
session 1 req winadj at putty.projects.tartarus.org

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1395


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org




--- Comment #1 from Damien Miller <djm at mindrot.org>  2008-01-20
09:53:37 ---
why is putty sending window probe requests on these channels anyway?

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1395





--- Comment #2 from Ben Harris <bjh21 at bjh21.me.uk>  2008-01-22 05:10:43
---
It's PuTTY's mechanism for deciding what channel window size it should 
use.  From the relevant wishlist item:

The basic idea is that when the connection isn't being limited by our 
ability to process data, we want to ensure that the window size as seen
by 
the server never drops to zero. Measuring the server's view of the
window 
size is done by arranging for it to acknowledge every 
SSH_MSG_CHANNEL_WINDOW_ADJUST, or rather an SSH_MSG_CHANNEL_REQUEST
sent 
just before it. That way we can tell when it its outgoing data stream
it 
recieved the window adjustment, and thus how small the server's view of 
the window got.
<http://www.chiark.greenend.org.uk/~sgtatham/putty/wishlist/flow-control>

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1395





--- Comment #3 from Ben Harris <bjh21 at bjh21.me.uk>  2008-01-22 05:13:19
---
Note in case it's causing confusion: this is the flow-control window,
as set by SSH_MSG_CHANNEL_WINDOW_ADJUST, not the terminal window, as
set by SSH_MSG_CHANNEL_REQUEST("window-change").

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1395


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |1452




-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1395


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1385|0                           |1
        is obsolete|                            |




--- Comment #4 from Damien Miller <djm at mindrot.org>  2008-06-30
22:12:32 ---
Created an attachment (id=1537)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1537)
only pass requests on session channels through to session handler

I think this fix is better: only pass channel requests on session
channels through to the session channel handler.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1395


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.7p1                       |5.0p1




--- Comment #5 from Damien Miller <djm at mindrot.org>  2008-06-30
22:16:42 ---
fix has been committed, will be in openssh-5.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1395


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1395


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




--- Comment #6 from Damien Miller <djm at mindrot.org>  2008-07-22
12:20:29 ---
Mass update RESOLVED->CLOSED after release of openssh-5.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.