Syslinux - Jul 2010 - No config file and Syslinux 4 regression

I have tested isolinux without a config file and discovered the following:

ISOLINUX 3.86 30-g9cc609c ETCD Copyright (C) 1994-2010 H. Peter Anvin et al
No DEFAULT or UI configuration directive found!
boot:

and

ISOLINUX 4.02 4.02* ETCD Copyright (C) 1994-2010 H. Peter Anvin et al
ERROR: No configuration file found

seems to hang here. no_default_msg gets printed too, but is overwritten since
the cursor
doesn't seem to advance.

And if there is no config file we end up at load_config_file instead of
no_config_file.

Sebastian

Sebastian Herbszt wrote:
>I have tested isolinux without a config file and discovered the following:
> 
> ISOLINUX 3.86 30-g9cc609c ETCD Copyright (C) 1994-2010 H. Peter Anvin et al
> No DEFAULT or UI configuration directive found!
> boot:
> 
> and
> 
> ISOLINUX 4.02 4.02* ETCD Copyright (C) 1994-2010 H. Peter Anvin et al
> ERROR: No configuration file found
> 
> seems to hang here. no_default_msg gets printed too, but is overwritten
since the cursor
> doesn't seem to advance.
> 
> And if there is no config file we end up at load_config_file instead of
no_config_file.
> 
> Sebastian
The following fixes it; maybe it should be added to ui.inc.

Sebastian

diff --git a/core/isolinux.asm b/core/isolinux.asm
index 1ef68d8..37ed8d4 100644
--- a/core/isolinux.asm
+++ b/core/isolinux.asm
@@ -1188,6 +1188,11 @@ ROOT_FS_OPS:
 ;
                pm_call load_config

+               mov di,GetCStack
+               mov si,[di+gc_file]
+               and si,si
+               jz no_config_file
+
 ;
 ; Now we have the config file open.  Parse the config file and
 ; run the user interface.