Feng Tang
2009-Dec-18 13:44 UTC
[syslinux] [RFC][PATCH] fsc: convert the highmem.inc from assembly to C code
All, Here is a RFC patch for converting the highmem.inc to C code, which doesn't touch the core part. please help to review, thanks Thanks, Feng
H. Peter Anvin
2009-Dec-18 17:07 UTC
[syslinux] [RFC][PATCH] fsc: convert the highmem.inc from assembly to C code
On 12/18/2009 05:44 AM, Feng Tang wrote:> All, > > Here is a RFC patch for converting the highmem.inc to C code, which doesn't > touch the core part. please help to review, thanks > > Thanks, > FengHi Feng, It would be better if we could re-use the code already in com32/lib/syslinux/memscan.c; one of the goals of C rewrite is to reduce the amount of duplicate code that we have. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
Liu Aleaxander
2009-Dec-19 12:49 UTC
[syslinux] [RFC][PATCH] fsc: convert the highmem.inc from assembly to C code
Hi feng, On Fri, Dec 18, 2009 at 9:44 PM, Feng Tang <feng.tang at intel.com> wrote:> +static void *hex_dump(void *start, int dlen, const char *str) > +{ > + ? ? ? uint32_t *data = start; > + ? ? ? uint32_t i; > + > + ? ? ? printf("Dump info for %s:\n", str); > + ? ? ? for (i = 0; i < dlen; i++) > + ? ? ? ? ? ? ? printf(" %08x ", data[i]); > + ? ? ? printf("\n"); > +}I submitted a hexdump lib patch a few days ago, and it is really good for debugging. You can check it at here: http://syslinux.zytor.com/archives/2009-December/013585.html . And, hpa, I haven't merged it into my git tree, since I think it would be better to let it be sited in com32/lib/ directory as a generic lib function. So, hpa, what's your opinion? Thanks! -- regards Liu Aleaxander