Syslinux - Nov 2006 - tftp-hpa does not reload the remap file when receiving SIGHUP

... because the signal handling code is enclosed in "#ifdef
HAVE_REGEX"
instead of "#ifdef WITH_REGEX"

The following patch against head of "network/tftp/tftp-hap.git" on
"kernel.org"
fixes this issues (you are using blanks for indention and not tabs. right?).

Cheers
Axel

diff --git a/tftpd/tftpd.c b/tftpd/tftpd.c
index 09d8733..8ea41d5 100644
--- a/tftpd/tftpd.c
+++ b/tftpd/tftpd.c
@@ -555,7 +555,7 @@ main(int argc, char **argv)
     if ( caught_sighup ) {
       caught_sighup = 0;
       if ( standalone ) {
-#ifdef HAVE_REGEX
+#ifdef WITH_REGEX
        if ( rewrite_file ) {
          freerules(rewrite_rules);
          rewrite_rules = read_remap_rules(rewrite_file);

Hi,

Dyks, Axel (XL) wrote:
> ... because the signal handling code is enclosed in "#ifdef
HAVE_REGEX"
> instead of "#ifdef WITH_REGEX"
> 
> The following patch against head of "network/tftp/tftp-hap.git"
on "kernel.org"
> fixes this issues (you are using blanks for indention and not tabs.
right?).
> 
> Cheers
> Axel
> 
> diff --git a/tftpd/tftpd.c b/tftpd/tftpd.c
> index 09d8733..8ea41d5 100644
> --- a/tftpd/tftpd.c
> +++ b/tftpd/tftpd.c
> @@ -555,7 +555,7 @@ main(int argc, char **argv)
>      if ( caught_sighup ) {
>        caught_sighup = 0;
>        if ( standalone ) {
> -#ifdef HAVE_REGEX
> +#ifdef WITH_REGEX
>         if ( rewrite_file ) {
>           freerules(rewrite_rules);
>           rewrite_rules = read_remap_rules(rewrite_file);
> 
is there something wrong with the patch or my post?
Has nobody else noticed that SIGHUP does not work as expected?

Cheers,
Axel