dtrace discuss - Jun 2009 - New probes review request for COMSTAR FC target

Hi Experts,

Please help me review two new probes interface for COMSTAR FC target.
It''s a complement for [PSARC/2009/291 FastTrack]
Here''s the doc:
http://fogbroom.prc/bjroot/users/allan/tmp/fasttrack-dtrace-provider.txt

Your comments before Jun 26 will be very much appreciated!

Thanks,
Allan

On Wed 24 Jun 2009 at 01:08PM, Allan Ou wrote:
> Hi Experts,
> 
> Please help me review two new probes interface for COMSTAR FC target.
> It''s a complement for [PSARC/2009/291 FastTrack]
> Here''s the doc:
> http://fogbroom.prc/bjroot/users/allan/tmp/fasttrack-dtrace-provider.txt
> 
> Your comments before Jun 26 will be very much appreciated!
Allan,

Since this is public list, you will have to post your text file
either via email, or to opensolaris.org somewhere.  Otherwise,
community members cannot read it.

It is probably easiest to just send it in email.

Thanks!

        -dp

-- 
Daniel Price, Solaris Kernel Engineering    http://blogs.sun.com/dp

Dan Price ??:
> On Wed 24 Jun 2009 at 01:08PM, Allan Ou wrote:
>   
>> Hi Experts,
>>
>> Please help me review two new probes interface for COMSTAR FC target.
>> It''s a complement for [PSARC/2009/291 FastTrack]
>> Here''s the doc:
>>
http://fogbroom.prc/bjroot/users/allan/tmp/fasttrack-dtrace-provider.txt
>>
>> Your comments before Jun 26 will be very much appreciated!
>>     
>
> Allan,
>
> Since this is public list, you will have to post your text file
> either via email, or to opensolaris.org somewhere.  Otherwise,
> community members cannot read it.
>
> It is probably easiest to just send it in email.
>
> Thanks!
>
>         -dp
>
>   
Hi Dan,

Thank you for reminding me.

Here''s the doccument:

4. Technical Description

The fc provider provides probes for tracing fibre channel port provider
activity.

This is a kernel provider built into the COMSTAR fc target port provider.

This project proposes to add two new providers to trace RSCN and ABTS packets

4.1 Probes overview

Fibre Channel Event Type        Probes
------------------------        ------
rscn receive                    fc:::rscn-receive
abts receive                    fc:::abts-receive


4.2 Probe argument commonality

These new providers follow the arguments rules of PSARC case 2009/291,
no new arguments defined.


4.3 Detailed probes specification

4.3.1 RSCN Packet Probes

fc:::rscn-receive trace all RSCN packets target port received

Probes              Variable   Type               Description
-----               ---------  ----               -----------
fc:::rscn-receive   args[0]    conninfo_t *       connection info
fc:::rscn-receive   args[1]    fc_port_info_t *   local port info
fc:::rscn-receive   args[2]    int                port id

args[2] is the port id which retrived from RSCN pages

4.3.2 ABTS Packet Probes

Probes               Variable  Type               Description
------               --------  ----               -----------
fc:::abts-receive    args[0]   conninfo_t *       connection info
fc:::abts-receive    args[1]   fc_port_info_t *   local port info
fc:::abts-receive    args[2]   fc_port_info_t *   remote port info


Documentation and examples can be found here:

  http://wikis.sun.com/display/DTrace/fibre+channel+Provider


5. Reference Documents:

   PSARC/2009/291 DTrace COMSTAR Fibre Channel Target Provider
   PSARC/2007/523 COMSTAR: Common Multiprotocol SCSI Target


6. Resources and Schedule
    6.4. Steering Committee requested information
        6.4.1. Consolidation C-team Name:
               ON
    6.5. ARC review type: FastTrack
    6.6. ARC Exposure: open


Thanks,
Allan