Ian Campbell
2011-Oct-13 09:46 UTC
[Xen-devel] [PATCH] build: error out on non-absolute $(XEN_ROOT)
# HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1318499065 -3600 # Node ID 82b2eeea91d059dd79cf7621d487a0cf7d29933e # Parent e5cc23098360f3ff137da9b128b02114468c5654 build: error out on non-absolute $(XEN_ROOT) Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r e5cc23098360 -r 82b2eeea91d0 Config.mk --- a/Config.mk Thu Oct 13 10:44:03 2011 +0100 +++ b/Config.mk Thu Oct 13 10:44:25 2011 +0100 @@ -4,6 +4,10 @@ ifeq ($(filter /%,$(XEN_ROOT)),) $(error XEN_ROOT must be absolute) endif +ifeq ($(filter /%,$(XEN_ROOT)),) +$(error XEN_ROOT must be absolute) +endif + -include $(XEN_ROOT)/.config # A debug build of Xen and tools? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2011-Oct-13 10:05 UTC
Re: [Xen-devel] [PATCH] build: error out on non-absolute $(XEN_ROOT)
On 13/10/2011 10:46, "Ian Campbell" <ian.campbell@citrix.com> wrote:> # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1318499065 -3600 > # Node ID 82b2eeea91d059dd79cf7621d487a0cf7d29933e > # Parent e5cc23098360f3ff137da9b128b02114468c5654 > build: error out on non-absolute $(XEN_ROOT)Notice something about the surrounding context of this diff? ;-) -- Keir> Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > diff -r e5cc23098360 -r 82b2eeea91d0 Config.mk > --- a/Config.mk Thu Oct 13 10:44:03 2011 +0100 > +++ b/Config.mk Thu Oct 13 10:44:25 2011 +0100 > @@ -4,6 +4,10 @@ ifeq ($(filter /%,$(XEN_ROOT)),) > $(error XEN_ROOT must be absolute) > endif > > +ifeq ($(filter /%,$(XEN_ROOT)),) > +$(error XEN_ROOT must be absolute) > +endif > + > -include $(XEN_ROOT)/.config > > # A debug build of Xen and tools? > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2011-Oct-13 10:49 UTC
Re: [Xen-devel] [PATCH] build: error out on non-absolute $(XEN_ROOT)
On Thu, 2011-10-13 at 11:05 +0100, Keir Fraser wrote:> On 13/10/2011 10:46, "Ian Campbell" <ian.campbell@citrix.com> wrote: > > > # HG changeset patch > > # User Ian Campbell <ian.campbell@citrix.com> > > # Date 1318499065 -3600 > > # Node ID 82b2eeea91d059dd79cf7621d487a0cf7d29933e > > # Parent e5cc23098360f3ff137da9b128b02114468c5654 > > build: error out on non-absolute $(XEN_ROOT) > > Notice something about the surrounding context of this diff? ;-)Ah yes, I even wondered about it cause I thought I''d seen it go in.> > -- Keir > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > > > diff -r e5cc23098360 -r 82b2eeea91d0 Config.mk > > --- a/Config.mk Thu Oct 13 10:44:03 2011 +0100 > > +++ b/Config.mk Thu Oct 13 10:44:25 2011 +0100 > > @@ -4,6 +4,10 @@ ifeq ($(filter /%,$(XEN_ROOT)),) > > $(error XEN_ROOT must be absolute) > > endif > > > > +ifeq ($(filter /%,$(XEN_ROOT)),) > > +$(error XEN_ROOT must be absolute) > > +endif > > + > > -include $(XEN_ROOT)/.config > > > > # A debug build of Xen and tools? > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel