I''ve attached a new version of AWS patch. It ''partially'' fixes 1889, meaning that it allows embedding ActiveRecord objects inside of AWS::Structs. So far this patch fixes: 2553, 3421, 2078, 2390, 2633, 2769, 3055, 3576, 3321, 1889, 3567. The only ticket I didn''t have chance to work on is 2392. Can somebody from the core team take a look at this patch and comment or apply? Thank you. -- Kent _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
> Can somebody from the core team take a look at this patch and comment or apply?One thing that immediately strikes me is: Where are all the tests? It''s hard to have strong confidence in patches fixing this many things without test coverage. Could you have a look at adding some tests to ensure that this works? Perhaps others in need of AWS could help? -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
> Can somebody from the core team take a look at this patch and comment or apply?Also, let''s open a new ticket for this mega patch and close down the others. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
That is exaclty want I''m working on right now :). I''ll send a new patch when all tests are done. -- Kent On 3/1/06, David Heinemeier Hansson <david.heinemeier@gmail.com> wrote:> > Can somebody from the core team take a look at this patch and comment or apply? > > One thing that immediately strikes me is: Where are all the tests? > It''s hard to have strong confidence in patches fixing this many things > without test coverage. Could you have a look at adding some tests to > ensure that this works? Perhaps others in need of AWS could help? > -- > David Heinemeier Hansson > http://www.loudthinking.com -- Broadcasting Brain > http://www.basecamphq.com -- Online project management > http://www.backpackit.com -- Personal information manager > http://www.rubyonrails.com -- Web-application framework > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core >
On 3/1/06, David Heinemeier Hansson <david.heinemeier@gmail.com> wrote:> > Can somebody from the core team take a look at this patch and comment or apply? > > Also, let''s open a new ticket for this mega patch and close down the others. > --It sounds like a good plan. Do you want me to do that? -- Kent
> That is exaclty want I''m working on right now :). I''ll send a new > patch when all tests are done.Excellent, thanks. Let''s make sure the new patch goes on a ticket so we have the public record. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
> It sounds like a good plan. Do you want me to do that?Please, that''d be great. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
David, I''ve create a new ticket #4038 and uploaded a new patch with test cases. -- Kent On 3/1/06, David Heinemeier Hansson <david.heinemeier@gmail.com> wrote:> > It sounds like a good plan. Do you want me to do that? > > Please, that''d be great.
> I''ve create a new ticket #4038 and uploaded a new patch with test cases.Smashing work, Kent. As a last thing, could I get you to write a summary of all the fixes that have been made? Preferably even as a patch to the CHANGELOG file for AWS if you want to make it real easy to apply ;) -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
I''ve uploaded a new patch. I''ve also added test cases and closed #2392. Cheers. -- Kent On 3/1/06, David Heinemeier Hansson <david.heinemeier@gmail.com> wrote:> > I''ve create a new ticket #4038 and uploaded a new patch with test cases. > > Smashing work, Kent. As a last thing, could I get you to write a > summary of all the fixes that have been made? Preferably even as a > patch to the CHANGELOG file for AWS if you want to make it real easy > to apply ;)
On 3/1/06, Kent Sibilev <ksruby@gmail.com> wrote:> I''ve attached a new version of AWS patch. It ''partially'' fixes 1889, > meaning that it allows embedding ActiveRecord objects inside of > AWS::Structs. > > So far this patch fixes: 2553, 3421, 2078, 2390, 2633, 2769, 3055, > 3576, 3321, 1889, 3567. >Hi. Thanks Kent and others for stepping up to do this, I''m glad someone was able to cover this. Just to give you all an idea of what''s up (not that you haven''t managed to do just fine without me :) I''ve been putting off writing this email for far too long, and its way overdue. So overdue. I don''t really have time to do any development on AWS (as you may have noticed). Scope change of my position at work means I have significantly less free spare time, so its hard for me to fit in stuff like AWS in my spare time, or into work time (as I was doing before). I most humbly apologize to anyone inconvenienced by my extended absence, it was not my intention to leave this unclarified for so long. As I will not have time to maintain this, I hereby want to cede any copyright I may have over all parts of AWS to the Rails project (or David Heinemeier Hansson if the Rails project is not a legal entity), just so there''s no ambiguity should anyone wish to effect a license change or any such thing in the future. If someone wants to run with this, the codebase as it stands, while working, is fragile in its dependency on SOAP4R. The main reason for this is that it uses SOAP4R as a "SOAP message serialization/deserialization engine" and not much else, the reason for that being I needed more control of how messages were dispatched into method calls on controllers/services, as well as being able to have SOAP4R deserialize/serialize into the object types we expect. The result of this approach is that we need a bit more access to SOAP4R internals than I believe the author intended people to have, and hence its fragility. It may be worth for someone investigating if there are alternate approaches to my implementation for the newer releases of SOAP4R. In addition, it could benefit from a rewrite. I have no doubt it could be made much more compact, with less "meta" magic (other than that necessary for the current style of declaration and annotation) to make the flow easier to follow. I''ll be adopting a seriously low profile from now onwards. Keep on having fun, folks :) Regards, Leon
> Keep on having fun, folks :)Thanks a lot for all your work on this, Leon. I know that there are many people who are very grateful for AWS. You''re welcome back any time! -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework