"bitsweat" made AR/Oracle cry... http://dev.rubyonrails.org/changeset/4391 ------------------------------------------------------------------------ r4391 | bitsweat | 2006-05-31 18:43:20 -0700 (Wed, 31 May 2006) | 1 line Records and arrays of records are bound as quoted ids. ------------------------------------------------------------------------ U activerecord/test/finder_test.rb U activerecord/lib/active_record/connection_adapters/abstract/quoting.rb U activerecord/lib/active_record/base.rb U activerecord/CHANGELOG Updated to revision 4391. 1) Failure: test_bind_record(FinderTest) [./test/finder_test.rb:205]: <"1,1,1"> expected but was <"''--- !ruby/struct: \nquoted_id: 1\n'',''--- !ruby/struct: \nquoted_id: 1\n'',''--- !ruby/struct: \nquoted_id: 1\n''">. 2) Error: test_find_by_records(FinderTest): ActiveRecord::StatementInvalid: OCIError: ORA-01722: invalid number: SELECT * FROM posts WHERE (id in (''--- !ruby/object:Post attributes: body: Such a lovely day title: Welcome to the weblog taggings_count: 0 type: Post id: 1 author_id: 1 '',''--- !ruby/object:SpecialPost attributes: body: Like I hopefully always am title: So I was thinking taggings_count: 0 type: SpecialPost id: 2 author_id: 1 '')) ./test/../lib/active_record/connection_adapters/abstract_adapter.rb:120:in `log'' ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:275:in `execute'' ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:475:in `select'' ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:266:in `select_all'' ./test/../lib/active_record/base.rb:390:in `find_by_sql'' ./test/../lib/active_record/base.rb:924:in `find_every'' ./test/../lib/active_record/base.rb:381:in `find'' ./test/finder_test.rb:391:in `test_find_by_records'' 3) Error: test_find_by_records_and_ids(FinderTest): ActiveRecord::StatementInvalid: OCIError: ORA-01722: invalid number: SELECT * FROM posts WHERE (id in (''--- !ruby/object:Post attributes: body: Such a lovely day title: Welcome to the weblog taggings_count: 0 type: Post id: 1 author_id: 1 '',2)) ./test/../lib/active_record/connection_adapters/abstract_adapter.rb:120:in `log'' ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:275:in `execute'' ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:475:in `select'' ./test/../lib/active_record/connection_adapters/oracle_adapter.rb:266:in `select_all'' ./test/../lib/active_record/base.rb:390:in `find_by_sql'' ./test/../lib/active_record/base.rb:924:in `find_every'' ./test/../lib/active_record/base.rb:381:in `find'' ./test/finder_test.rb:396:in `test_find_by_records_and_ids'' 891 tests, 3130 assertions, 1 failures, 2 errors rake aborted! Command failed with status (1): [/usr/pkg/ruby184/bin/ruby -Ilib:test:test/...] (See full trace by running task with --trace)