Rails core - Jul 2006 - Feedback long overdue on #5396 (ActiveSupport::Multibyte)

Would some gentle soul from the core look at the patch and say what  
you guys think? We have a pure-Ruby normalizer-casefolder done and  
it''s plenty fast (thx to Manfred Stienstra from Fingertips).
It''s
already in the plugin (and we kept plowing for more than a month on  
this). In it''s current form the plugin can be directly mixed into  
ActiveSupport (we did all the refactoring in advance so that it fits  
nicely into the module scheme). We are also preparing a rdoc primer  
on how to handle basic Unicode issues.

The ticket has a patch that shows how the API fits into the current  
Rails code, with some fixes along the way (and more are coming).

We still haven''t heard _a word_ from the core on the API.

Pretty please?

-- 
Julik

> The ticket has a patch that shows how the API fits into the current
> Rails code, with some fixes along the way (and more are coming).
>
> We still haven''t heard _a word_ from the core on the API.
>
> Pretty please?
Hi Julik,

We have actually talked about this, sorry we didn''t get back to you.
Trac''s down at present, but my understanding of the patch is:

* String#chars and we can call @string.chars.size to get the number of
chars in the String (vs number of bytes
* Fixes to helpers like truncate to use .chars.size not .size
* A fallback implementation of String#chars for people who don''t have
the unicode gem install.

If that''s correct,  I see no reason not to apply it and I''ll
assign
the patch to me.

We''ll get it in for 1.2

-- 
Cheers

Koz

On 13-jul-2006, at 23:40, Michael Koziarski wrote:
>
> * String#chars and we can call @string.chars.size to get the number of
> chars in the String (vs number of bytes
Actually, the char proxy implements _all_ string functions.
> If that''s correct,  I see no reason not to apply it and
I''ll assign
> the patch to me.
>
> We''ll get it in for 1.2
Thanks, I''m really, really happy with this!

Manfred