Overriding PATH but not LD_LIBRARY_PATH is bogus, as it may result in the use of mismatched binaries and libraries. Signed-off-by: Jan Beulich <jbeulich@suse.com> --- a/tools/hotplug/Linux/xen-hotplug-common.sh +++ b/tools/hotplug/Linux/xen-hotplug-common.sh @@ -31,6 +31,7 @@ dir=$(dirname "$0") exec 2>>/var/log/xen/xen-hotplug.log export PATH="${BINDIR}:${SBINDIR}:${LIBEXEC}:${PRIVATE_BINDIR}:/sbin:/bin:/usr/bin:/usr/sbin:$PATH" +export LD_LIBRARY_PATH="${LIBDIR}${LD_LIBRARY_PATH+:}$LD_LIBRARY_PATH" export LANG="POSIX" unset $(set | grep ^LC_ | cut -d= -f1) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Ian Campbell
2013-Jun-26 13:59 UTC
Re: [PATCH] also override library path for hotplug scripts
On Tue, 2013-06-25 at 15:12 +0100, Jan Beulich wrote:> Overriding PATH but not LD_LIBRARY_PATH is bogus, as it may result in > the use of mismatched binaries and libraries. > > Signed-off-by: Jan Beulich <jbeulich@suse.com>Acked-by: Ian Campbell <ian.campbell@citrix.com> George, opinion RE 4.3? I think it should be pretty safe.> > --- a/tools/hotplug/Linux/xen-hotplug-common.sh > +++ b/tools/hotplug/Linux/xen-hotplug-common.sh > @@ -31,6 +31,7 @@ dir=$(dirname "$0") > exec 2>>/var/log/xen/xen-hotplug.log > > export PATH="${BINDIR}:${SBINDIR}:${LIBEXEC}:${PRIVATE_BINDIR}:/sbin:/bin:/usr/bin:/usr/sbin:$PATH" > +export LD_LIBRARY_PATH="${LIBDIR}${LD_LIBRARY_PATH+:}$LD_LIBRARY_PATH" > export LANG="POSIX" > unset $(set | grep ^LC_ | cut -d= -f1) > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
George Dunlap
2013-Jun-26 15:44 UTC
Re: [PATCH] also override library path for hotplug scripts
On 26/06/13 14:59, Ian Campbell wrote:> On Tue, 2013-06-25 at 15:12 +0100, Jan Beulich wrote: >> Overriding PATH but not LD_LIBRARY_PATH is bogus, as it may result in >> the use of mismatched binaries and libraries. >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > Acked-by: Ian Campbell <ian.campbell@citrix.com> > > George, opinion RE 4.3? I think it should be pretty safe.Hmm, so this is only changing things for Xen hotplug scripts. Yes, on the whole it seems like the risk of *not* applying this patch is bigger than the risk of applying it. Re the release: Acked-by: George Dunlap <george.dunlap@eu.citrix.com>