Xen devel - Feb 2013 - [PATCH] xen: arm32: Use system wide TLB flushes, not just inner-shareable

We currently setup page table walks etc as outer-shareable. Given we
don''t
really make the distinction between inner- and outer-shareable yet err on
theside of safety.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Cc: Tim Deegan <tim@xen.org>
---
 xen/include/asm-arm/flushtlb.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/include/asm-arm/flushtlb.h b/xen/include/asm-arm/flushtlb.h
index 210abfa..5067e5d 100644
--- a/xen/include/asm-arm/flushtlb.h
+++ b/xen/include/asm-arm/flushtlb.h
@@ -19,7 +19,7 @@ static inline void flush_tlb_local(void)
 {
     dsb();
 
-    WRITE_CP32((uint32_t) 0, TLBIALLIS);
+    WRITE_CP32((uint32_t) 0, TLBIALL);
 
     dsb();
     isb();
@@ -30,7 +30,7 @@ static inline void flush_tlb_all_local(void)
 {
     dsb();
 
-    WRITE_CP32((uint32_t) 0, TLBIALLNSNHIS);
+    WRITE_CP32((uint32_t) 0, TLBIALLNSNH);
 
     dsb();
     isb();
-- 
1.7.9.1

At 15:40 +0000 on 08 Feb (1360338056), Ian Campbell
wrote:
> We currently setup page table walks etc as outer-shareable. Given we
don''t
> really make the distinction between inner- and outer-shareable yet err on
> theside of safety.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
> Cc: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
> Cc: Tim Deegan <tim@xen.org>
> ---
>  xen/include/asm-arm/flushtlb.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/include/asm-arm/flushtlb.h
b/xen/include/asm-arm/flushtlb.h
> index 210abfa..5067e5d 100644
> --- a/xen/include/asm-arm/flushtlb.h
> +++ b/xen/include/asm-arm/flushtlb.h
> @@ -19,7 +19,7 @@ static inline void flush_tlb_local(void)
>  {
>      dsb();
>  
> -    WRITE_CP32((uint32_t) 0, TLBIALLIS);
> +    WRITE_CP32((uint32_t) 0, TLBIALL);
>  
>      dsb();
>      isb();
> @@ -30,7 +30,7 @@ static inline void flush_tlb_all_local(void)
>  {
>      dsb();
>  
> -    WRITE_CP32((uint32_t) 0, TLBIALLNSNHIS);
> +    WRITE_CP32((uint32_t) 0, TLBIALLNSNH);
>  
>      dsb();
>      isb();
> -- 
> 1.7.9.1
>

On Fri, 2013-02-08 at 15:43 +0000, Tim Deegan wrote:
> At 15:40 +0000 on 08 Feb (1360338056), Ian Campbell wrote:
> > We currently setup page table walks etc as outer-shareable. Given we
don''t
> > really make the distinction between inner- and outer-shareable yet err
on
> > theside of safety.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Acked-by: Tim Deegan <tim@xen.org>
Applied, thanks.